diff mbox series

tee: optee: use dev_info in print_os_revision

Message ID 20200302122153.20670-1-patrick.delaunay@st.com
State Accepted
Commit 71126d53df7aea9abb42b99b69c8d8b9cb5aa043
Delegated to: Tom Rini
Headers show
Series tee: optee: use dev_info in print_os_revision | expand

Commit Message

Patrick DELAUNAY March 2, 2020, 12:21 p.m. UTC
Display TEE version at information level; this patch replaces
debug() call to dev_info() in print_os_revision() function.

Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
---

 drivers/tee/optee/core.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

Comments

Jens Wiklander March 3, 2020, 11:44 a.m. UTC | #1
On Mon, Mar 2, 2020 at 1:22 PM Patrick Delaunay <patrick.delaunay@st.com> wrote:
>
> Display TEE version at information level; this patch replaces
> debug() call to dev_info() in print_os_revision() function.
>
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
> ---
>
>  drivers/tee/optee/core.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)

Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

Cheers,
Jens
Tom Rini April 21, 2020, 12:26 p.m. UTC | #2
On Mon, Mar 02, 2020 at 01:21:53PM +0100, Patrick Delaunay wrote:

> Display TEE version at information level; this patch replaces
> debug() call to dev_info() in print_os_revision() function.
> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
> Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c
index 9fb5e658f9..5260dab3ac 100644
--- a/drivers/tee/optee/core.c
+++ b/drivers/tee/optee/core.c
@@ -512,7 +512,7 @@  static bool is_optee_api(optee_invoke_fn *invoke_fn)
 	       res.a2 == OPTEE_MSG_UID_2 && res.a3 == OPTEE_MSG_UID_3;
 }
 
-static void print_os_revision(optee_invoke_fn *invoke_fn)
+static void print_os_revision(struct udevice *dev, optee_invoke_fn *invoke_fn)
 {
 	union {
 		struct arm_smccc_res smccc;
@@ -527,11 +527,12 @@  static void print_os_revision(optee_invoke_fn *invoke_fn)
 		  &res.smccc);
 
 	if (res.result.build_id)
-		debug("OP-TEE revision %lu.%lu (%08lx)\n", res.result.major,
-		      res.result.minor, res.result.build_id);
+		dev_info(dev, "OP-TEE: revision %lu.%lu (%08lx)\n",
+			 res.result.major, res.result.minor,
+			 res.result.build_id);
 	else
-		debug("OP-TEE revision %lu.%lu\n", res.result.major,
-		      res.result.minor);
+		dev_info(dev, "OP-TEE: revision %lu.%lu\n",
+			 res.result.major, res.result.minor);
 }
 
 static bool api_revision_is_compatible(optee_invoke_fn *invoke_fn)
@@ -626,7 +627,7 @@  static int optee_probe(struct udevice *dev)
 		return -ENOENT;
 	}
 
-	print_os_revision(pdata->invoke_fn);
+	print_os_revision(dev, pdata->invoke_fn);
 
 	if (!api_revision_is_compatible(pdata->invoke_fn)) {
 		debug("%s: OP-TEE api revision mismatch\n", __func__);