diff mbox series

tiny-printf: revert patch to fix spl eth boot

Message ID 20200225181528.2457-1-moseschristopherb@gmail.com
State Superseded
Delegated to: Lokesh Vutla
Headers show
Series tiny-printf: revert patch to fix spl eth boot | expand

Commit Message

Moses Christopher Feb. 25, 2020, 6:15 p.m. UTC 
From: Moses Christopher Bollavarapu <moseschristopherb@gmail.com>

  - Revert commit 831c16111959 ("tiny-printf: Reorder code to support %p")

    The mentioned commit does not handle the ethaddr properly.
    Hence, I tried to disable SPL_TINY_PRINTF, but then it was suggested
    to keep using the tiny-printf library in SPL and revert the patch
    that caused the issue.

  - The issue is observed in both Beaglebone Black and Guardian Board,
    while trying to boot the board using USB-ETH in SPL stage.

Signed-off-by: Moses Christopher Bollavarapu <moseschristopherb@gmail.com>
---
 lib/tiny-printf.c | 10 ----------
 1 file changed, 10 deletions(-)
diff mbox series

Patch

diff --git a/lib/tiny-printf.c b/lib/tiny-printf.c
index 1138c7012a..8ee0ffb9ca 100644
--- a/lib/tiny-printf.c
+++ b/lib/tiny-printf.c
@@ -268,20 +268,10 @@  static int _vprintf(struct printf_info *info, const char *fmt, va_list va)
 				}
 				break;
 			case 'p':
-#ifdef DEBUG
 				pointer(info, fmt, va_arg(va, void *));
-				/*
-				 * Skip this because it pulls in _ctype which is
-				 * 256 bytes, and we don't generally implement
-				 * pointer anyway
-				 */
 				while (isalnum(fmt[0]))
 					fmt++;
 				break;
-#else
-				islong = true;
-				/* no break */
-#endif
 			case 'x':
 				if (islong) {
 					num = va_arg(va, unsigned long);