diff mbox series

rockchip: make_fit_atf: use correct fdt_x references in config nodes

Message ID 20200117202604.3226605-1-heiko@sntech.de
State Accepted
Commit dfa64707da22d816c8e43141f7aaaf3a3078cd06
Delegated to: Kever Yang
Headers show
Series rockchip: make_fit_atf: use correct fdt_x references in config nodes | expand

Commit Message

Heiko Stuebner Jan. 17, 2020, 8:26 p.m. UTC 
From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>

The script iterates over the given devicetrees and creates both
fdt_x node as well as a conf-node for each passed dt.

But there is a slight bug in that it always references fdt_1 in each
conf node instead of the matching fdt_x as expected.

So fix that by referencing the number of the current dt similar to
how the fdt_x nodes gets created.

Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
---
 arch/arm/mach-rockchip/make_fit_atf.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kever Yang Feb. 19, 2020, 8:17 a.m. UTC | #1 
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
<kever.yang@rock-chips.com>

Thanks,
- Kever

Heiko Stuebner <heiko@sntech.de> 于2020年1月18日周六 上午4:26写道：

> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>
> The script iterates over the given devicetrees and creates both
> fdt_x node as well as a conf-node for each passed dt.
>
> But there is a slight bug in that it always references fdt_1 in each
> conf node instead of the matching fdt_x as expected.
>
> So fix that by referencing the number of the current dt similar to
> how the fdt_x nodes gets created.
>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> ---
>  arch/arm/mach-rockchip/make_fit_atf.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-rockchip/make_fit_atf.py
> b/arch/arm/mach-rockchip/make_fit_atf.py
> index 3c045a5e17..aaec2cd270 100755
> --- a/arch/arm/mach-rockchip/make_fit_atf.py
> +++ b/arch/arm/mach-rockchip/make_fit_atf.py
> @@ -107,7 +107,7 @@ def append_conf_section(file, cnt, dtname, segments):
>              file.write(';\n')
>      if segments <= 1:
>          file.write(';\n')
> -    file.write('\t\t\tfdt = "fdt_1";\n')
> +    file.write('\t\t\tfdt = "fdt_%d";\n' % cnt)
>      file.write('\t\t};\n')
>      file.write('\n')
>
> --
> 2.24.1
>
>
diff mbox series

Patch

diff --git a/arch/arm/mach-rockchip/make_fit_atf.py b/arch/arm/mach-rockchip/make_fit_atf.py
index 3c045a5e17..aaec2cd270 100755
--- a/arch/arm/mach-rockchip/make_fit_atf.py
+++ b/arch/arm/mach-rockchip/make_fit_atf.py
@@ -107,7 +107,7 @@  def append_conf_section(file, cnt, dtname, segments):
             file.write(';\n')
     if segments <= 1:
         file.write(';\n')
-    file.write('\t\t\tfdt = "fdt_1";\n')
+    file.write('\t\t\tfdt = "fdt_%d";\n' % cnt)
     file.write('\t\t};\n')
     file.write('\n')