| Message ID | 20191219142444.18696-1-oliver.graute@kococonnector.com |
|---|---|
| State | Accepted |
| Commit | d1d78db1dbcb699192bc2251addc0b6a8d32993b |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | [v1,1/2] imx: imx8qm_rom7720: added missing USDHC Base address defines | expand |
Hi Oliver, On Thu, Dec 19, 2019 at 11:25 AM Oliver Graute <oliver.graute@kococonnector.com> wrote: > +#define USDHC1_BASE_ADDR 0x5B010000 > +#define USDHC2_BASE_ADDR 0x5B020000 > +#define USDHC3_BASE_ADDR 0x5B030000 These defines would be better placed in a common SoC header file instead of in the board file. It is OK for now to do like this and we can do a cleanup later: Reviewed-by: Fabio Estevam <festevam@gmail.com>
diff --git a/include/configs/imx8qm_rom7720.h b/include/configs/imx8qm_rom7720.h index 865863eb7c..8e1427da8a 100644 --- a/include/configs/imx8qm_rom7720.h +++ b/include/configs/imx8qm_rom7720.h @@ -18,6 +18,10 @@ #define CONFIG_FSL_USDHC #define CONFIG_SYS_FSL_ESDHC_ADDR 0 +#define USDHC1_BASE_ADDR 0x5B010000 +#define USDHC2_BASE_ADDR 0x5B020000 +#define USDHC3_BASE_ADDR 0x5B030000 + #define CONFIG_SUPPORT_EMMC_BOOT /* eMMC specific */ #define CONFIG_ENV_OVERWRITE
Added missing USDHC Base address defines Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com> Cc: Stefano Babic <sbabic@denx.de> Cc: Fabio Estevam <festevam@gmail.com> Cc: Peng Fan <peng.fan@nxp.com> Cc: Simon Glass <sjg@chromium.org> Cc: Ye Li <ye.li@nxp.com> Cc: uboot-imx <uboot-imx@nxp.com> --- include/configs/imx8qm_rom7720.h | 4 ++++ 1 file changed, 4 insertions(+)