diff mbox series

[U-Boot,1/3] mx7ulp_evk: Disable CONFIG_NET

Message ID 20191023140855.19446-1-festevam@gmail.com
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show
Series [U-Boot,1/3] mx7ulp_evk: Disable CONFIG_NET | expand

Commit Message

Fabio Estevam Oct. 23, 2019, 2:08 p.m. UTC
Currently the following build warning is seen:

===================== WARNING ======================
This board does not use CONFIG_DM_ETH (Driver Model
for Ethernet drivers). Please update the board to use
CONFIG_DM_ETH before the v2020.07 release. Failure to
update by the deadline may result in board removal.
See doc/driver-model/migration.rst for more info.
===================================================

Since the mx7ulp-evk board does not have networking support, explicitly
disable networking.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 configs/mx7ulp_evk_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Peng Fan Oct. 24, 2019, 1:10 a.m. UTC | #1
> Subject: [PATCH 1/3] mx7ulp_evk: Disable CONFIG_NET
> 
> Currently the following build warning is seen:
> 
> ===================== WARNING ====================== This board
> does not use CONFIG_DM_ETH (Driver Model for Ethernet drivers). Please
> update the board to use CONFIG_DM_ETH before the v2020.07 release.
> Failure to update by the deadline may result in board removal.
> See doc/driver-model/migration.rst for more info.
> ===================================================
> 
> Since the mx7ulp-evk board does not have networking support, explicitly
> disable networking.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  configs/mx7ulp_evk_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configs/mx7ulp_evk_defconfig b/configs/mx7ulp_evk_defconfig
> index ffd217d515..d79c39d621 100644
> --- a/configs/mx7ulp_evk_defconfig
> +++ b/configs/mx7ulp_evk_defconfig
> @@ -17,6 +17,7 @@ CONFIG_CMD_FAT=y
>  CONFIG_OF_CONTROL=y
>  CONFIG_DEFAULT_DEVICE_TREE="imx7ulp-evk"
>  CONFIG_ENV_IS_IN_MMC=y
> +# CONFIG_NET is not set
>  CONFIG_DM=y
>  CONFIG_DM_GPIO=y
>  CONFIG_IMX_RGPIO2P=y

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> --
> 2.17.1
Fabio Estevam Jan. 15, 2020, 3:46 p.m. UTC | #2
Hi Stefano,

On Wed, Oct 23, 2019 at 11:08 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> Currently the following build warning is seen:
>
> ===================== WARNING ======================
> This board does not use CONFIG_DM_ETH (Driver Model
> for Ethernet drivers). Please update the board to use
> CONFIG_DM_ETH before the v2020.07 release. Failure to
> update by the deadline may result in board removal.
> See doc/driver-model/migration.rst for more info.
> ===================================================
>
> Since the mx7ulp-evk board does not have networking support, explicitly
> disable networking.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

It seems that this series has been forgotten. Would you like me to resend it?
Stefano Babic Jan. 15, 2020, 3:58 p.m. UTC | #3
Hi Fabio,

On 15/01/20 16:46, Fabio Estevam wrote:
> Hi Stefano,
> 
> On Wed, Oct 23, 2019 at 11:08 AM Fabio Estevam <festevam@gmail.com> wrote:
>>
>> Currently the following build warning is seen:
>>
>> ===================== WARNING ======================
>> This board does not use CONFIG_DM_ETH (Driver Model
>> for Ethernet drivers). Please update the board to use
>> CONFIG_DM_ETH before the v2020.07 release. Failure to
>> update by the deadline may result in board removal.
>> See doc/driver-model/migration.rst for more info.
>> ===================================================
>>
>> Since the mx7ulp-evk board does not have networking support, explicitly
>> disable networking.
>>
>> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> 
> It seems that this series has been forgotten.

..I will say lost...

> Would you like me to resend it?

I found the series in patchwork, I rebased 1/3 and applied the whole
series to -next branch. It flows into -master at my next PR.

Thanks for pointing to this,
Stefano
diff mbox series

Patch

diff --git a/configs/mx7ulp_evk_defconfig b/configs/mx7ulp_evk_defconfig
index ffd217d515..d79c39d621 100644
--- a/configs/mx7ulp_evk_defconfig
+++ b/configs/mx7ulp_evk_defconfig
@@ -17,6 +17,7 @@  CONFIG_CMD_FAT=y
 CONFIG_OF_CONTROL=y
 CONFIG_DEFAULT_DEVICE_TREE="imx7ulp-evk"
 CONFIG_ENV_IS_IN_MMC=y
+# CONFIG_NET is not set
 CONFIG_DM=y
 CONFIG_DM_GPIO=y
 CONFIG_IMX_RGPIO2P=y