diff mbox series

[U-Boot,3/7] imx: mx6sabresd: fix splash logo drawing

Message ID 20190919173015.18692-4-agust@denx.de
State Accepted
Commit b0413fc14b183842687bddb2d8f907bfdce9aa23
Delegated to: Anatolij Gustschin
Headers show
Series Fix splash logo for imx6 boards | expand

Commit Message

Anatolij Gustschin Sept. 19, 2019, 5:30 p.m. UTC
After mxc_ipuv3 DM_VIDEO conversion showing splash image
doesn't work. Fix this. Also enable white on black console
configuration as it used to be with cfb_console driver.

Signed-off-by: Anatolij Gustschin <agust@denx.de>
---
 configs/mx6sabresd_defconfig      | 2 ++
 include/configs/mx6sabre_common.h | 1 +
 2 files changed, 3 insertions(+)

Comments

Fabio Estevam Sept. 19, 2019, 6:26 p.m. UTC | #1
Hi Anatolij,

On Thu, Sep 19, 2019 at 2:30 PM Anatolij Gustschin <agust@denx.de> wrote:
>
> After mxc_ipuv3 DM_VIDEO conversion showing splash image
> doesn't work. Fix this. Also enable white on black console
> configuration as it used to be with cfb_console driver.
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>

Thanks for fixing it!

Reported-by: Fabio Estevam <festevam@gmail.com>
Tested-by: Fabio Estevam <festevam@gmail.com>
Fabio Estevam Sept. 19, 2019, 6:30 p.m. UTC | #2
Hi Anatolij,

On Thu, Sep 19, 2019 at 3:26 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Anatolij,
>
> On Thu, Sep 19, 2019 at 2:30 PM Anatolij Gustschin <agust@denx.de> wrote:
> >
> > After mxc_ipuv3 DM_VIDEO conversion showing splash image
> > doesn't work. Fix this. Also enable white on black console
> > configuration as it used to be with cfb_console driver.
> >
> > Signed-off-by: Anatolij Gustschin <agust@denx.de>
>
> Thanks for fixing it!
>
> Reported-by: Fabio Estevam <festevam@gmail.com>
> Tested-by: Fabio Estevam <festevam@gmail.com>

One thing I noticed is that now I don't see the U-Boot version string
shown in the splashscreen as we used to see before the DM conversion.

Thanks

No
Anatolij Gustschin Sept. 20, 2019, 3:46 p.m. UTC | #3
Hi Fabio,

On Thu, 19 Sep 2019 15:30:43 -0300
Fabio Estevam festevam@gmail.com wrote:
...
> One thing I noticed is that now I don't see the U-Boot version string
> shown in the splashscreen as we used to see before the DM conversion.

Thanks for testing! I've sent a patch to address this:

 http://patchwork.ozlabs.org/patch/1165305

--
Anatolij
diff mbox series

Patch

diff --git a/configs/mx6sabresd_defconfig b/configs/mx6sabresd_defconfig
index 2c88fe67c2..a0a6f40583 100644
--- a/configs/mx6sabresd_defconfig
+++ b/configs/mx6sabresd_defconfig
@@ -47,6 +47,7 @@  CONFIG_CMD_USB_MASS_STORAGE=y
 CONFIG_CMD_DHCP=y
 CONFIG_CMD_MII=y
 CONFIG_CMD_PING=y
+CONFIG_CMD_BMP=y
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_EXT2=y
 CONFIG_CMD_EXT4=y
@@ -99,4 +100,5 @@  CONFIG_CI_UDC=y
 CONFIG_USB_HOST_ETHER=y
 CONFIG_USB_ETHER_ASIX=y
 CONFIG_DM_VIDEO=y
+CONFIG_SYS_WHITE_ON_BLACK=y
 CONFIG_VIDEO_IPUV3=y
diff --git a/include/configs/mx6sabre_common.h b/include/configs/mx6sabre_common.h
index c137612b01..d704cda2a6 100644
--- a/include/configs/mx6sabre_common.h
+++ b/include/configs/mx6sabre_common.h
@@ -62,6 +62,7 @@ 
 	"dfu_alt_info=spl raw 0x400\0" \
 	"fdt_high=0xffffffff\0"	  \
 	"initrd_high=0xffffffff\0" \
+	"splashimage=" __stringify(CONFIG_LOADADDR) "\0" \
 	"mmcdev=" __stringify(CONFIG_SYS_MMC_ENV_DEV) "\0" \
 	"mmcpart=1\0" \
 	"finduuid=part uuid mmc ${mmcdev}:2 uuid\0" \