| Message ID | 20190807170559.26107-1-aford173@gmail.com |
|---|---|
| State | Accepted |
| Commit | a3ecce373af981f701b1c71a98da3df188c21960 |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | [U-Boot,V2,1/2] ARM: imx6qlogic: Cleanup board_init_f | expand |
Hi Adam, On Wed, Aug 7, 2019 at 2:06 PM Adam Ford <aford173@gmail.com> wrote: > > Per the workflow found in crt0.S, we don't need to clear BSS in > board_init_f nor do we need to call board_init_r since that will be > done for us from main when we return from board_init_f. > > This patch removes the unneeded function calls from board_init_f. > > Signed-off-by: Adam Ford <aford173@gmail.com> > --- > V2: Limit this patch to only removing unneeded function calls. Reviewed-by: Fabio Estevam <festevam@gmail.com>
diff --git a/board/logicpd/imx6/imx6logic.c b/board/logicpd/imx6/imx6logic.c index 6e3ffa72d7..d97f9e18af 100644 --- a/board/logicpd/imx6/imx6logic.c +++ b/board/logicpd/imx6/imx6logic.c @@ -349,11 +349,5 @@ void board_init_f(ulong dummy) /* UART clocks enabled and gd valid - init serial console */ preloader_console_init(); - - /* Clear the BSS. */ - memset(__bss_start, 0, __bss_end - __bss_start); - - /* load/boot image from boot device */ - board_init_r(NULL, 0); } #endif
Per the workflow found in crt0.S, we don't need to clear BSS in board_init_f nor do we need to call board_init_r since that will be done for us from main when we return from board_init_f. This patch removes the unneeded function calls from board_init_f. Signed-off-by: Adam Ford <aford173@gmail.com> --- V2: Limit this patch to only removing unneeded function calls.