diff mbox series

[U-Boot,2/2] ARM: imx6q_logic: Enable DM_SERIAL

Message ID 20190807163552.25400-2-aford173@gmail.com
State Superseded
Delegated to: Stefano Babic
Headers show
Series [U-Boot,1/2] ARM: imx6qlogic: Cleanup board_init_f and enable spl_early_init | expand

Commit Message

Adam Ford Aug. 7, 2019, 4:35 p.m. UTC
With spl_early_init() now enabled in board_init_f, the
preloader_console_init() function can correctly initialize the
serial port based on the device tree during SPL.
This patch enables DM_SERIAL in both U-Boot and SPL.

Signed-off-by: Adam Ford <aford173@gmail.com>

Comments

Fabio Estevam Aug. 7, 2019, 4:40 p.m. UTC | #1
On Wed, Aug 7, 2019 at 1:36 PM Adam Ford <aford173@gmail.com> wrote:
>
> With spl_early_init() now enabled in board_init_f, the
> preloader_console_init() function can correctly initialize the
> serial port based on the device tree during SPL.
> This patch enables DM_SERIAL in both U-Boot and SPL.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
>
> diff --git a/configs/imx6q_logic_defconfig b/configs/imx6q_logic_defconfig
> index b95c9783a4..2c77b9c218 100644
> --- a/configs/imx6q_logic_defconfig
> +++ b/configs/imx6q_logic_defconfig
> @@ -4,7 +4,6 @@ CONFIG_SYS_TEXT_BASE=0x17800000
>  CONFIG_SPL_GPIO_SUPPORT=y
>  CONFIG_SPL_LIBCOMMON_SUPPORT=y
>  CONFIG_SPL_LIBGENERIC_SUPPORT=y
> -CONFIG_SYS_MALLOC_F_LEN=0x2000

Unrelated change?
Adam Ford Aug. 7, 2019, 4:42 p.m. UTC | #2
On Wed, Aug 7, 2019 at 11:39 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> On Wed, Aug 7, 2019 at 1:36 PM Adam Ford <aford173@gmail.com> wrote:
> >
> > With spl_early_init() now enabled in board_init_f, the
> > preloader_console_init() function can correctly initialize the
> > serial port based on the device tree during SPL.
> > This patch enables DM_SERIAL in both U-Boot and SPL.
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> >
> > diff --git a/configs/imx6q_logic_defconfig b/configs/imx6q_logic_defconfig
> > index b95c9783a4..2c77b9c218 100644
> > --- a/configs/imx6q_logic_defconfig
> > +++ b/configs/imx6q_logic_defconfig
> > @@ -4,7 +4,6 @@ CONFIG_SYS_TEXT_BASE=0x17800000
> >  CONFIG_SPL_GPIO_SUPPORT=y
> >  CONFIG_SPL_LIBCOMMON_SUPPORT=y
> >  CONFIG_SPL_LIBGENERIC_SUPPORT=y
> > -CONFIG_SYS_MALLOC_F_LEN=0x2000
>
> Unrelated change?

It appears to be an artifact of the make savedefconfig.  Newer updates
make CONFIG_SYS_MALLOC_F_LEN=0x2000 by default, so savedefconfig just
removed it.
I will do a V2 patch serial splitting the first patch into two
separate parts, then I'll remove this artifact from the 2nd patch.

adam
diff mbox series

Patch

diff --git a/configs/imx6q_logic_defconfig b/configs/imx6q_logic_defconfig
index b95c9783a4..2c77b9c218 100644
--- a/configs/imx6q_logic_defconfig
+++ b/configs/imx6q_logic_defconfig
@@ -4,7 +4,6 @@  CONFIG_SYS_TEXT_BASE=0x17800000
 CONFIG_SPL_GPIO_SUPPORT=y
 CONFIG_SPL_LIBCOMMON_SUPPORT=y
 CONFIG_SPL_LIBGENERIC_SUPPORT=y
-CONFIG_SYS_MALLOC_F_LEN=0x2000
 CONFIG_TARGET_MX6LOGICPD=y
 CONFIG_SPL_MMC_SUPPORT=y
 CONFIG_SPL_SERIAL_SUPPORT=y
@@ -84,6 +83,7 @@  CONFIG_DM_REGULATOR=y
 CONFIG_DM_REGULATOR_PFUZE100=y
 CONFIG_DM_REGULATOR_FIXED=y
 CONFIG_DM_REGULATOR_GPIO=y
+CONFIG_DM_SERIAL=y
 CONFIG_MXC_UART=y
 CONFIG_USB=y
 CONFIG_DM_USB=y