| Message ID | 20190725094056.13872-1-kever.yang@rock-chips.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot] part: always enable part_get_info_ptr() for driver | expand |
On Thu, Jul 25, 2019 at 05:40:56PM +0800, Kever Yang wrote: > The partition driver has its Kconfig option, and the part_get_info_prt() > interface are mendatory interface for partition drivers, > always enable the macro to make partition driver works correctly. > > Signed-off-by: Kever Yang <kever.yang@rock-chips.com> This makes some boards such as r8a77995_draak overflow their memory map.
Tom, On 2019/8/8 上午3:30, Tom Rini wrote: > On Thu, Jul 25, 2019 at 05:40:56PM +0800, Kever Yang wrote: > >> The partition driver has its Kconfig option, and the part_get_info_prt() >> interface are mendatory interface for partition drivers, >> always enable the macro to make partition driver works correctly. >> >> Signed-off-by: Kever Yang <kever.yang@rock-chips.com> > This makes some boards such as r8a77995_draak overflow their memory map. > Is it overflow in SPL? then these board have very limited space left for SPL. There use to have a CONFIG_SPL_LIBDISK_SUPPORT to decide if we need partition driver and now it convert to use CONFIG_PARTITIONS&CONFIG_SPL_FRAMEWORK after: 91ff686562 blk: Rework guard around part_init call If the board really needs the partition driver, then we must have part_get_info_prt() to make it work, or else we'd better disable the the partition driver in SPL to remove the no use code. Do you think SPL of boards like r8a77995_draak really need partition driver? Thanks, - Kever
diff --git a/include/part.h b/include/part.h index ebca546db5..7d00fae56f 100644 --- a/include/part.h +++ b/include/part.h @@ -241,22 +241,15 @@ static inline int blk_get_device_part_str(const char *ifname, #endif /* - * We don't support printing partition information in SPL and only support - * getting partition information in a few cases. + * We don't support printing partition information in SPL */ #ifdef CONFIG_SPL_BUILD # define part_print_ptr(x) NULL -# if defined(CONFIG_SPL_FS_EXT4) || defined(CONFIG_SPL_FS_FAT) || \ - defined(CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION) -# define part_get_info_ptr(x) x -# else -# define part_get_info_ptr(x) NULL -# endif #else #define part_print_ptr(x) x -#define part_get_info_ptr(x) x #endif +#define part_get_info_ptr(x) x struct part_driver { const char *name;
The partition driver has its Kconfig option, and the part_get_info_prt() interface are mendatory interface for partition drivers, always enable the macro to make partition driver works correctly. Signed-off-by: Kever Yang <kever.yang@rock-chips.com> --- include/part.h | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-)