diff mbox series

[U-Boot] arm: dts: imx: fsl-imx8qm.dtsi: add gpio aliases to fix gpio command

Message ID 20190724090832.14404-1-peng.fan@nxp.com
State Accepted
Commit ab1c482440ef33f34d7a4d7a14fe5e99a3704e42
Delegated to: Stefano Babic
Headers show
Series [U-Boot] arm: dts: imx: fsl-imx8qm.dtsi: add gpio aliases to fix gpio command | expand

Commit Message

Peng Fan July 24, 2019, 8:53 a.m. UTC 
The gpio command currently uses equal bank names "GPIO0_"
for all existing gpio banks, i. e.:

U-Boot# gpio status -a
Bank GPIO0_:
GPIO0_0: input: 0 [ ]
GPIO0_1: input: 0 [ ]
...

Bank GPIO0_:
GPIO0_0: input: 0 [ ]
GPIO0_1: input: 0 [ ]
    ...

So the command is broken, it is not possible to address
a desired bank. Add gpio aliases to fix this.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 arch/arm/dts/fsl-imx8qm.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Anatolij Gustschin July 29, 2019, 7:02 p.m. UTC | #1 
On Wed, 24 Jul 2019 08:53:08 +0000
Peng Fan peng.fan@nxp.com wrote:
... 
> So the command is broken, it is not possible to address
> a desired bank. Add gpio aliases to fix this.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Reviewed-by: Anatolij Gustschin <agust@denx.de>

--
Anatolij
Peng Fan Aug. 13, 2019, 8:30 a.m. UTC | #2 
> Subject: [PATCH] arm: dts: imx: fsl-imx8qm.dtsi: add gpio aliases to fix gpio
> command
> 
> The gpio command currently uses equal bank names "GPIO0_"
> for all existing gpio banks, i. e.:
> 
> U-Boot# gpio status -a
> Bank GPIO0_:
> GPIO0_0: input: 0 [ ]
> GPIO0_1: input: 0 [ ]
> ...
> 
> Bank GPIO0_:
> GPIO0_0: input: 0 [ ]
> GPIO0_1: input: 0 [ ]
>     ...
> 
> So the command is broken, it is not possible to address a desired bank. Add
> gpio aliases to fix this.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---

Applied to nxp-imx-8-13,
https://github.com/MrVan/u-boot/tree/nxp-imx-8-13

Regards,
Peng.
diff mbox series

Patch

diff --git a/arch/arm/dts/fsl-imx8qm.dtsi b/arch/arm/dts/fsl-imx8qm.dtsi
index af060db3a1..6808f68f9d 100644
--- a/arch/arm/dts/fsl-imx8qm.dtsi
+++ b/arch/arm/dts/fsl-imx8qm.dtsi
@@ -21,6 +21,13 @@ 
 	aliases {
 		ethernet0 = &fec1;
 		ethernet1 = &fec2;
+		gpio0 = &gpio1;
+		gpio1 = &gpio2;
+		gpio2 = &gpio3;
+		gpio3 = &gpio4;
+		gpio4 = &gpio5;
+		gpio5 = &gpio6;
+		gpio6 = &gpio7;
 		serial0 = &lpuart0;
 		serial1 = &lpuart1;
 		serial2 = &lpuart2;