| Message ID | 20190618220153.11245-3-lukma@denx.de |
|---|---|
| State | Superseded |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | DM: Convert i.MX28 gpio, pinmux, spi and eth drivers to DM/DTS | expand |
On 6/19/19 12:01 AM, Lukasz Majewski wrote: > The fec_mxc.c driver can be reused by i.MX28 when DM_ETH is enabled. > One only needs to add proper compatible and dependency on FEC_MXC in the > Kconfig. > > Signed-off-by: Lukasz Majewski <lukma@denx.de> Tags should be "net: fec:" , see git log --oneline drivers/net/fec . Driver additions should always use "subsystem: driver:" tag, when in doubt, check git log.
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index e6a4fdf30e..60273dc737 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -190,7 +190,7 @@ config FEC_MXC_MDIO_BASE config FEC_MXC bool "FEC Ethernet controller" - depends on MX5 || MX6 || MX7 || IMX8 || VF610 + depends on MX28 || MX5 || MX6 || MX7 || IMX8 || VF610 help This driver supports the 10/100 Fast Ethernet controller for NXP i.MX processors. diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c index d7c080943a..96e3ad9a1a 100644 --- a/drivers/net/fec_mxc.c +++ b/drivers/net/fec_mxc.c @@ -1485,6 +1485,7 @@ static int fecmxc_ofdata_to_platdata(struct udevice *dev) } static const struct udevice_id fecmxc_ids[] = { + { .compatible = "fsl,imx28-fec" }, { .compatible = "fsl,imx6q-fec" }, { .compatible = "fsl,imx6sl-fec" }, { .compatible = "fsl,imx6sx-fec" },
The fec_mxc.c driver can be reused by i.MX28 when DM_ETH is enabled. One only needs to add proper compatible and dependency on FEC_MXC in the Kconfig. Signed-off-by: Lukasz Majewski <lukma@denx.de> --- Changes in v4: - Sort the entries for compatibles and Kconfig Changes in v3: - Set more apropriate tags Changes in v2: None drivers/net/Kconfig | 2 +- drivers/net/fec_mxc.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-)