diff mbox series

[U-Boot,1/1] trace: trace buffer may exceed 2GiB

Message ID 20190614195222.16123-1-xypron.glpk@gmx.de
State Accepted
Commit 7ea33579576d2bcd19df76bd8769e7ab3b4a169b
Delegated to: Simon Glass
Headers show
Series [U-Boot,1/1] trace: trace buffer may exceed 2GiB | expand

Commit Message

Heinrich Schuchardt June 14, 2019, 7:52 p.m. UTC
Correct the debug output for the trace buffer size to accommodate trace
buffers exceeding 2GiB.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 common/board_f.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--
2.20.1

Comments

Simon Glass June 22, 2019, 7:10 p.m. UTC | #1
On Fri, 14 Jun 2019 at 20:52, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> Correct the debug output for the trace buffer size to accommodate trace
> buffers exceeding 2GiB.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  common/board_f.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
Simon Glass June 28, 2019, 1:55 p.m. UTC | #2
On Sat, 22 Jun 2019 at 13:10, Simon Glass <sjg@chromium.org> wrote:
>
> On Fri, 14 Jun 2019 at 20:52, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> >
> > Correct the debug output for the trace buffer size to accommodate trace
> > buffers exceeding 2GiB.
> >
> > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> > ---
> >  common/board_f.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-dm/next, thanks!
diff mbox series

Patch

diff --git a/common/board_f.c b/common/board_f.c
index 0fc938dc87..4760d728f3 100644
--- a/common/board_f.c
+++ b/common/board_f.c
@@ -442,8 +442,8 @@  static int reserve_trace(void)
 #ifdef CONFIG_TRACE
 	gd->relocaddr -= CONFIG_TRACE_BUFFER_SIZE;
 	gd->trace_buff = map_sysmem(gd->relocaddr, CONFIG_TRACE_BUFFER_SIZE);
-	debug("Reserving %dk for trace data at: %08lx\n",
-	      CONFIG_TRACE_BUFFER_SIZE >> 10, gd->relocaddr);
+	debug("Reserving %luk for trace data at: %08lx\n",
+	      (unsigned long)CONFIG_TRACE_BUFFER_SIZE >> 10, gd->relocaddr);
 #endif

 	return 0;