Message ID | 20190518175954.262021-8-sjg@chromium.org |
---|---|
State | Accepted |
Commit | f2980ece06363e584541829bf40d46ad9760d535 |
Delegated to: | Simon Glass |
Headers | show
Return-Path: <u-boot-bounces@lists.denx.de> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="EZRD5t+H"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 455tNJ4n13z9sB8 for <incoming@patchwork.ozlabs.org>; Sun, 19 May 2019 04:04:48 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 5F656C21E02; Sat, 18 May 2019 18:01:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 8E46BC21DD9; Sat, 18 May 2019 18:00:32 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 6925FC21DFA; Sat, 18 May 2019 18:00:15 +0000 (UTC) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by lists.denx.de (Postfix) with ESMTPS id 42DC9C21E30 for <u-boot@lists.denx.de>; Sat, 18 May 2019 18:00:15 +0000 (UTC) Received: by mail-io1-f66.google.com with SMTP id x24so7989237ion.5 for <u-boot@lists.denx.de>; Sat, 18 May 2019 11:00:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZEmWkn7053nDy2KDm7tW+fnYdSLDMo5xV+UtWxNIMh8=; b=EZRD5t+HxdXE5rckm/LdABHgnj7Se3Z2GgXXFGOdESZ5xA9NAazpmGSOXoAGXjnWEV kcZDhcKOIrpKJ9Vx366nJDZfj1JYGHXWVUFzYswWfUKDH9tbSp2lN8mTvojSxh5J1IsO LuICXuVy0rvvObz5xGCnL2nBmDkPuvR99ajs4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZEmWkn7053nDy2KDm7tW+fnYdSLDMo5xV+UtWxNIMh8=; b=BZDWsjkWM4NYjXHQkSAY1wBN5MZyL+RBBm+T8essp9HuKkMcu6ICTqBP+qQKeUmksr fpaUbS6VjAhR0KATHh5IqhvKEsKQf+Qc9u+8GxoKXqwmLOo8uX0o+liWCTJQurOp/NRP 4u12wu5s/8+SHp5PevA6M3ev11QmF1PcTNQKZjhF30eiuMnM0NvO48w8Tt/kP2I9xupk V+Zqsga0u+uD63v9YSwhyoXIV3y4m7C6Cy7uQBbeBC11LPw53Ye2a0Phe9uDDUcyncw9 0zBlIZgLXlx3SMQjaAVmHGTi1O3qT2yTxUumB50w1KxeLNGLsx4UAa2ztkmkaaRg3tOF GDCg== X-Gm-Message-State: APjAAAUrg083VToulIK/gVj8eh5rEYUDvJMHjalb4ldSFIHWpMdqVL8a 1EckP1t22vs5xEDYqoYYYKh5rnXFX3M= X-Google-Smtp-Source: APXvYqx1nIu+Nut6hGRAmTkfAh2xf2INVPthDX7rEuzRsuDc/rN5nQ44pN5ZOHev00WcOnG4fIswMw== X-Received: by 2002:a6b:b415:: with SMTP id d21mr34140471iof.189.1558202414158; Sat, 18 May 2019 11:00:14 -0700 (PDT) Received: from kiwi.bld.corp.google.com ([2620:15c:183:0:8223:87c:a681:66aa]) by smtp.gmail.com with ESMTPSA id f1sm3968703iop.53.2019.05.18.11.00.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 18 May 2019 11:00:13 -0700 (PDT) From: Simon Glass <sjg@chromium.org> To: U-Boot Mailing List <u-boot@lists.denx.de> Date: Sat, 18 May 2019 11:59:44 -0600 Message-Id: <20190518175954.262021-8-sjg@chromium.org> X-Mailer: git-send-email 2.21.0.1020.gf2820cf01a-goog In-Reply-To: <20190518175954.262021-1-sjg@chromium.org> References: <20190518175954.262021-1-sjg@chromium.org> MIME-Version: 1.0 Cc: Tom Rini <trini@konsulko.com> Subject: [U-Boot] [PATCH 07/17] sandbox: Quit when hang() is called X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion <u-boot.lists.denx.de> List-Unsubscribe: <https://lists.denx.de/options/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=unsubscribe> List-Archive: <http://lists.denx.de/pipermail/u-boot/> List-Post: <mailto:u-boot@lists.denx.de> List-Help: <mailto:u-boot-request@lists.denx.de?subject=help> List-Subscribe: <https://lists.denx.de/listinfo/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de> |
Series |
sandbox: Various bug fixes
|
expand
|
diff --git a/lib/hang.c b/lib/hang.c index c5a78694be6..4d026a3e64c 100644 --- a/lib/hang.c +++ b/lib/hang.c @@ -9,6 +9,7 @@ #include <common.h> #include <bootstage.h> +#include <os.h> /** * hang - stop processing by staying in an endless loop @@ -26,6 +27,8 @@ void hang(void) puts("### ERROR ### Please RESET the board ###\n"); #endif bootstage_error(BOOTSTAGE_ID_NEED_RESET); + if (IS_ENABLED(CONFIG_SANDBOX)) + os_exit(1); for (;;) ; }
It doesn't make a lot of sense to hang on sandbox when hang() is called, since the only way out is Ctrl-C. In fact, Ctrl-C does not work if the terminal is in raw mode, which it will be if the command-line has not been reached yet. In that case, Ctrl-Z / kill -9 must be used, which is not very friendly. Avoid all of this by quiting when hang() is called. Signed-off-by: Simon Glass <sjg@chromium.org> --- lib/hang.c | 3 +++ 1 file changed, 3 insertions(+)