diff mbox series

[U-Boot,v8] rockchip: dts: rk3399: nanopi4: Use CD pin as RK_FUNC_1

Message ID 20190509034921.2865-1-jagan@amarulasolutions.com
State Accepted
Commit adc91db0e6f83653da06066bc60633d7a437bcbd
Delegated to: Kever Yang
Headers show
Series [U-Boot,v8] rockchip: dts: rk3399: nanopi4: Use CD pin as RK_FUNC_1 | expand

Commit Message

Jagan Teki May 9, 2019, 3:49 a.m. UTC 
Attaching GPIO functionality to SDMMC0_DET pin (which
does in Linux base dts) make dwmmc driver "fail to detect
the card".

  Card did not respond to voltage select!

It may be because the existing driver can't support gpio
card detection. So, change the pinctrl functionality from
RK_FUNC_GPIO to RK_FUNC_1 like other rk3399 dts does via
sdmmc_cd pin.

Add this change in -u-boot.dtsi so once we have a proper
fix or more details we may drop it this in future.

Cc: Robin Murphy <robin.murphy@arm.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v8:
- drop pinctrl-names
- update proper commit

 arch/arm/dts/rk3399-nanopi4-u-boot.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 arch/arm/dts/rk3399-nanopi4-u-boot.dtsi
diff mbox series

Patch

diff --git a/arch/arm/dts/rk3399-nanopi4-u-boot.dtsi b/arch/arm/dts/rk3399-nanopi4-u-boot.dtsi
new file mode 100644
index 0000000000..bb8bdf08c5
--- /dev/null
+++ b/arch/arm/dts/rk3399-nanopi4-u-boot.dtsi
@@ -0,0 +1,8 @@ 
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2019 Jagan Teki <jagan@amarulasolutions.com>
+ */
+
+&sdmmc {
+	pinctrl-0 = <&sdmmc_bus4 &sdmmc_clk &sdmmc_cmd &sdmmc_cd>;
+};