| Message ID | 20190507083722.44876-1-christoph.muellner@theobroma-systems.com |
|---|---|
| State | Accepted |
| Commit | 9828ed6259595e938e50455e8f45d018a19b7770 |
| Delegated to: | Kever Yang |
| Headers | show |
| Series | [U-Boot] rockchip: rk3399-puma: Move ENV_OFFSET to end of SPI NOR. | expand |
On Tue, 7 May 2019 at 02:37, Christoph Muellner <christoph.muellner@theobroma-systems.com> wrote: > > Puma SoMs have a 4 MB SPI NOR flash. > Therefore we can move the environment to the end of the flash > (4 MiB - 16 kiB) in order to not overlap with SPL. > > Reported-by: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> > Signed-off-by: Christoph Muellner <christoph.muellner@theobroma-systems.com> > --- > > board/theobroma-systems/puma_rk3399/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org>
Hi Christoph, On 05/07/2019 04:37 PM, Christoph Muellner wrote: > Puma SoMs have a 4 MB SPI NOR flash. > Therefore we can move the environment to the end of the flash > (4 MiB - 16 kiB) in order to not overlap with SPL. > > Reported-by: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> > Signed-off-by: Christoph Muellner <christoph.muellner@theobroma-systems.com> Reviewed-by: Kever Yang <kever.yang@rock-chips.com> Thanks, - Kever > --- > > board/theobroma-systems/puma_rk3399/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/board/theobroma-systems/puma_rk3399/Kconfig b/board/theobroma-systems/puma_rk3399/Kconfig > index 8a94cbd9ed..9e23252754 100644 > --- a/board/theobroma-systems/puma_rk3399/Kconfig > +++ b/board/theobroma-systems/puma_rk3399/Kconfig > @@ -16,6 +16,6 @@ config ENV_SIZE > default 0x2000 > > config ENV_OFFSET > - default 0x3c000 if ENV_IS_IN_SPI_FLASH > + default 0x3fc000 if ENV_IS_IN_SPI_FLASH > > endif
On 05/28/2019 08:46 PM, Kever Yang wrote: > Hi Christoph, > > > On 05/07/2019 04:37 PM, Christoph Muellner wrote: >> Puma SoMs have a 4 MB SPI NOR flash. >> Therefore we can move the environment to the end of the flash >> (4 MiB - 16 kiB) in order to not overlap with SPL. >> >> Reported-by: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> >> Signed-off-by: Christoph Muellner <christoph.muellner@theobroma-systems.com> > Reviewed-by: Kever Yang <kever.yang@rock-chips.com> Applied to u-boot-rockchip/master, thanks! > > Thanks, > - Kever >> --- >> >> board/theobroma-systems/puma_rk3399/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/board/theobroma-systems/puma_rk3399/Kconfig b/board/theobroma-systems/puma_rk3399/Kconfig >> index 8a94cbd9ed..9e23252754 100644 >> --- a/board/theobroma-systems/puma_rk3399/Kconfig >> +++ b/board/theobroma-systems/puma_rk3399/Kconfig >> @@ -16,6 +16,6 @@ config ENV_SIZE >> default 0x2000 >> >> config ENV_OFFSET >> - default 0x3c000 if ENV_IS_IN_SPI_FLASH >> + default 0x3fc000 if ENV_IS_IN_SPI_FLASH >> >> endif > > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot
diff --git a/board/theobroma-systems/puma_rk3399/Kconfig b/board/theobroma-systems/puma_rk3399/Kconfig index 8a94cbd9ed..9e23252754 100644 --- a/board/theobroma-systems/puma_rk3399/Kconfig +++ b/board/theobroma-systems/puma_rk3399/Kconfig @@ -16,6 +16,6 @@ config ENV_SIZE default 0x2000 config ENV_OFFSET - default 0x3c000 if ENV_IS_IN_SPI_FLASH + default 0x3fc000 if ENV_IS_IN_SPI_FLASH endif
Puma SoMs have a 4 MB SPI NOR flash. Therefore we can move the environment to the end of the flash (4 MiB - 16 kiB) in order to not overlap with SPL. Reported-by: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> Signed-off-by: Christoph Muellner <christoph.muellner@theobroma-systems.com> --- board/theobroma-systems/puma_rk3399/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)