diff mbox series

[U-Boot] board: am335x: Drop duplicate pinmux configuration

Message ID 20190425141200.19315-1-paul@betafive.co.uk
State Accepted
Commit bb7b45a356376b52dd4d3a3acc2dde1fcfa75c4e
Delegated to: Tom Rini
Headers show
Series [U-Boot] board: am335x: Drop duplicate pinmux configuration | expand

Commit Message

paul@betafive.co.uk April 25, 2019, 2:12 p.m. UTC 
From: Paul Barker <paul.barker@sancloud.co.uk>

In commit ad6054f1fe128f797b6eb2964afca6674b584785 where support for the
Sancloud BeagleBone Enhanced (BBE) was added, new conditional
configuration of either MII pin muxing or RGMII pin muxing is done
depending on the board type. However, the old call to set up MII pin
muxing was not removed.

This may result in misconfiguration of the pin muxing for the BBE or
duplicate configuration for other boards and so we remove this obsolete
call.

Signed-off-by: Paul Barker <paul.barker@sancloud.co.uk>
---
 board/ti/am335x/mux.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Tom Rini May 3, 2019, 6:20 p.m. UTC | #1 
On Thu, Apr 25, 2019 at 03:12:00PM +0100, paul@betafive.co.uk wrote:

> From: Paul Barker <paul.barker@sancloud.co.uk>
> 
> In commit ad6054f1fe128f797b6eb2964afca6674b584785 where support for the
> Sancloud BeagleBone Enhanced (BBE) was added, new conditional
> configuration of either MII pin muxing or RGMII pin muxing is done
> depending on the board type. However, the old call to set up MII pin
> muxing was not removed.
> 
> This may result in misconfiguration of the pin muxing for the BBE or
> duplicate configuration for other boards and so we remove this obsolete
> call.
> 
> Signed-off-by: Paul Barker <paul.barker@sancloud.co.uk>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/board/ti/am335x/mux.c b/board/ti/am335x/mux.c
index 04f4b8e6934..37a599768b1 100644
--- a/board/ti/am335x/mux.c
+++ b/board/ti/am335x/mux.c
@@ -399,7 +399,6 @@  void enable_board_pin_mux(void)
 			configure_module_pin_mux(mii1_pin_mux);
 		}
 		/* Beaglebone LT pinmux */
-		configure_module_pin_mux(mii1_pin_mux);
 		configure_module_pin_mux(mmc0_pin_mux);
 #if defined(CONFIG_NAND) && defined(CONFIG_EMMC_BOOT)
 		configure_module_pin_mux(nand_pin_mux);