| Message ID | 20190413091359.29612-4-judge.packham@gmail.com |
|---|---|
| State | Accepted |
| Commit | 4ad2c8953d456814ac33e26b6a3193dc4002ac4b |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Remove select CRC32 and CONFIG_CRC32 | expand |
Am 13.04.19 um 11:13 schrieb Chris Packham: > There is no check for CONFIG_CRC32 so the #define in image.h does > nothing. Remove it. > > Reported-by: Robert P. J. Day <rpjday@crashcourse.ca> > Signed-off-by: Chris Packham <judge.packham@gmail.com> > --- > > include/image.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/image.h b/include/image.h > index 765ffecee0a7..6b2661ed0bd6 100644 > --- a/include/image.h > +++ b/include/image.h > @@ -68,7 +68,6 @@ struct fdt_region; > # define IMAGE_ENABLE_SHA1 1 > # endif > # else > -# define CONFIG_CRC32 /* FIT images need CRC32 support */ > # define IMAGE_ENABLE_CRC32 1 > # define IMAGE_ENABLE_MD5 1 > # define IMAGE_ENABLE_SHA1 1 > Reviewed-by: Stefano Babic <sbabic@denx.de> Best regards, Stefano
Hello Chris, Am 13.04.2019 um 11:13 schrieb Chris Packham: > There is no check for CONFIG_CRC32 so the #define in image.h does > nothing. Remove it. > > Reported-by: Robert P. J. Day <rpjday@crashcourse.ca> > Signed-off-by: Chris Packham <judge.packham@gmail.com> > --- > > include/image.h | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Heiko Schocher <hs@denx.de> bye, Heiko
On Sat, Apr 13, 2019 at 09:13:58PM +1200, Chris Packham wrote: > There is no check for CONFIG_CRC32 so the #define in image.h does > nothing. Remove it. > > Reported-by: Robert P. J. Day <rpjday@crashcourse.ca> > Signed-off-by: Chris Packham <judge.packham@gmail.com> > Reviewed-by: Stefano Babic <sbabic@denx.de> > Reviewed-by: Heiko Schocher <hs@denx.de> Applied to u-boot/master, thanks!
diff --git a/include/image.h b/include/image.h index 765ffecee0a7..6b2661ed0bd6 100644 --- a/include/image.h +++ b/include/image.h @@ -68,7 +68,6 @@ struct fdt_region; # define IMAGE_ENABLE_SHA1 1 # endif # else -# define CONFIG_CRC32 /* FIT images need CRC32 support */ # define IMAGE_ENABLE_CRC32 1 # define IMAGE_ENABLE_MD5 1 # define IMAGE_ENABLE_SHA1 1
There is no check for CONFIG_CRC32 so the #define in image.h does nothing. Remove it. Reported-by: Robert P. J. Day <rpjday@crashcourse.ca> Signed-off-by: Chris Packham <judge.packham@gmail.com> --- include/image.h | 1 - 1 file changed, 1 deletion(-)