diff mbox series

[U-Boot,1/2] sysreset: select DM_GPIO instead of GPIO

Message ID 20190413083524.24384-1-judge.packham@gmail.com
State Accepted
Commit 26680b9f3a874c0f7010cb239db0c6fa76d9a400
Delegated to: Tom Rini
Headers show
Series [U-Boot,1/2] sysreset: select DM_GPIO instead of GPIO | expand

Commit Message

Chris Packham April 13, 2019, 8:35 a.m. UTC
CONFIG_GPIO does not exist. sysreset_gpio.c uses the DM gpio APIs so the
correct option to select is DM_GPIO.

Reported-by: Robert P. J. Day <rpjday@crashcourse.ca>
Signed-off-by: Chris Packham <judge.packham@gmail.com>
---

 drivers/sysreset/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Glass April 15, 2019, 4:24 p.m. UTC | #1
On Sat, 13 Apr 2019 at 02:35, Chris Packham <judge.packham@gmail.com> wrote:
>
> CONFIG_GPIO does not exist. sysreset_gpio.c uses the DM gpio APIs so the
> correct option to select is DM_GPIO.
>
> Reported-by: Robert P. J. Day <rpjday@crashcourse.ca>
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> ---
>
>  drivers/sysreset/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Simon Glass <sjg@chromium.org>
Tom Rini May 10, 2019, 3:10 p.m. UTC | #2
On Sat, Apr 13, 2019 at 08:35:23PM +1200, Chris Packham wrote:

> CONFIG_GPIO does not exist. sysreset_gpio.c uses the DM gpio APIs so the
> correct option to select is DM_GPIO.
> 
> Reported-by: Robert P. J. Day <rpjday@crashcourse.ca>
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/drivers/sysreset/Kconfig b/drivers/sysreset/Kconfig
index 8ce3e2e20761..73d141184953 100644
--- a/drivers/sysreset/Kconfig
+++ b/drivers/sysreset/Kconfig
@@ -17,7 +17,7 @@  if SYSRESET
 
 config SYSRESET_GPIO
 	bool "Enable support for GPIO reset driver"
-	select GPIO
+	select DM_GPIO
 	help
 	  Reset support via GPIO pin connected reset logic. This is used for
 	  example on Microblaze where reset logic can be controlled via GPIO