diff mbox series

[U-Boot,2/2] configs: turris_omnia: use MMC driver model

Message ID 20190411025659.1780-2-delroth@gmail.com
State Awaiting Upstream
Delegated to: Stefan Roese
Headers show
Series [U-Boot,1/2] mmc: mv_sdhci: add driver model support | expand

Commit Message

Pierre Bourdon April 11, 2019, 2:56 a.m. UTC
Enable DM_MMC for compliance with the driver model migration.

Signed-off-by: Pierre Bourdon <delroth@gmail.com>
Cc: Marek Behun <marek.behun@nic.cz>
---
 configs/turris_omnia_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Stefan Roese April 11, 2019, 9:26 a.m. UTC | #1
On 11.04.19 04:56, Pierre Bourdon wrote:
> Enable DM_MMC for compliance with the driver model migration.
> 
> Signed-off-by: Pierre Bourdon <delroth@gmail.com>
> Cc: Marek Behun <marek.behun@nic.cz>
> ---
>   configs/turris_omnia_defconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/configs/turris_omnia_defconfig b/configs/turris_omnia_defconfig
> index c406b25753..fd9dc5a61b 100644
> --- a/configs/turris_omnia_defconfig
> +++ b/configs/turris_omnia_defconfig
> @@ -42,6 +42,7 @@ CONFIG_SCSI_AHCI=y
>   CONFIG_ATSHA204A=y
>   CONFIG_MMC_SDHCI=y
>   CONFIG_MMC_SDHCI_MV=y
> +CONFIG_DM_MMC=y
>   CONFIG_SPI_FLASH=y
>   CONFIG_PHY_MARVELL=y
>   CONFIG_PHY_GIGE=y
> 

With the new DM enabled MMC driver (thanks again), we should probably
better select DM_MMC in arch/arm/Kconfig for ARCH_MVEBU. This way, all
those boards will get moved to the new driver version.

What do you think?

Thanks,
Stefan
Pierre Bourdon April 13, 2019, 1:20 p.m. UTC | #2
On Thu, Apr 11, 2019 at 11:26 AM Stefan Roese <sr@denx.de> wrote:
> With the new DM enabled MMC driver (thanks again), we should probably
> better select DM_MMC in arch/arm/Kconfig for ARCH_MVEBU. This way, all
> those boards will get moved to the new driver version.
>
> What do you think?

I've only tested one specific board with this and I lack the knowledge
/ experience to properly judge the level of risk involved with
switching the default for all mvebu boards. If your call is that this
would be a safe change, sure, let's go for it.

DM_MMC is supposed to be a requirement for v2019.04 anyway, if I
understand correctly.
Stefan Roese April 26, 2019, 10:42 a.m. UTC | #3
On 11.04.19 04:56, Pierre Bourdon wrote:
> Enable DM_MMC for compliance with the driver model migration.
> 
> Signed-off-by: Pierre Bourdon <delroth@gmail.com>
> Cc: Marek Behun <marek.behun@nic.cz>

Applied to u-boot-marvell/master.

Thanks,
Stefan
diff mbox series

Patch

diff --git a/configs/turris_omnia_defconfig b/configs/turris_omnia_defconfig
index c406b25753..fd9dc5a61b 100644
--- a/configs/turris_omnia_defconfig
+++ b/configs/turris_omnia_defconfig
@@ -42,6 +42,7 @@  CONFIG_SCSI_AHCI=y
 CONFIG_ATSHA204A=y
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_MV=y
+CONFIG_DM_MMC=y
 CONFIG_SPI_FLASH=y
 CONFIG_PHY_MARVELL=y
 CONFIG_PHY_GIGE=y