| Message ID | 20181121151320.23792-1-guillaume.gardet@free.fr |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot] omap3: beagle: Enable DM_MMC and BLK for u-boot only, not SPL | expand |
On Wed, Nov 21, 2018 at 04:13:20PM +0100, Guillaume GARDET wrote: > Also disable USB_STORAGE as it is not ready for the switch. > Tested on a Beagleboard xM rev. B. > > Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr> > > Cc: Tom Rini <trini@konsulko.com> > Cc: Simon Glass <sjg@chromium.org> In the case of USB_STORAGE we need to turn on DM_USB and then it works.
Le 21/11/2018 à 18:06, Tom Rini a écrit : > On Wed, Nov 21, 2018 at 04:13:20PM +0100, Guillaume GARDET wrote: > >> Also disable USB_STORAGE as it is not ready for the switch. >> Tested on a Beagleboard xM rev. B. >> >> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr> >> >> Cc: Tom Rini <trini@konsulko.com> >> Cc: Simon Glass <sjg@chromium.org> > In the case of USB_STORAGE we need to turn on DM_USB and then it works. If DM_USB is enabled, no USB controller are detected, so we loose Ethernet. Did I miss an additional option to enable? Guillaume
On Mon, Dec 17, 2018 at 11:04 AM Guillaume Gardet <guillaume.gardet@free.fr> wrote: > > > Le 21/11/2018 à 18:06, Tom Rini a écrit : > > On Wed, Nov 21, 2018 at 04:13:20PM +0100, Guillaume GARDET wrote: > > > >> Also disable USB_STORAGE as it is not ready for the switch. > >> Tested on a Beagleboard xM rev. B. > >> > >> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr> > >> > >> Cc: Tom Rini <trini@konsulko.com> > >> Cc: Simon Glass <sjg@chromium.org> > > In the case of USB_STORAGE we need to turn on DM_USB and then it works. > > > If DM_USB is enabled, no USB controller are detected, so we loose Ethernet. Did I miss an additional option to enable? AFASK, the MUSB driver didn't yet support gadget mode when used with DM_USB... at least until recently. I noticed that part of the MUSB driver was updated, but the omap2430 glue hasn't been updated yet. I am not 100% sure, but I think the Beagle xM is a DM3730 which uses the omap2430 glue. I doubt TI will update the omap2430 glue, so I started some stuff. I've got on patch that seems to show the usb gadget controller in the DM tree, but my board hangs when I try to use a gadget. It's not ready for the mailing list yet, but I can push this stuff to my github later today if someone wants to look at it and/or test/improve it. adam > > Guillaume > > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot
On Mon, Dec 17, 2018 at 1:34 PM Adam Ford <aford173@gmail.com> wrote: > > On Mon, Dec 17, 2018 at 11:04 AM Guillaume Gardet > <guillaume.gardet@free.fr> wrote: > > > > > > Le 21/11/2018 à 18:06, Tom Rini a écrit : > > > On Wed, Nov 21, 2018 at 04:13:20PM +0100, Guillaume GARDET wrote: > > > > > >> Also disable USB_STORAGE as it is not ready for the switch. > > >> Tested on a Beagleboard xM rev. B. > > >> > > >> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr> > > >> > > >> Cc: Tom Rini <trini@konsulko.com> > > >> Cc: Simon Glass <sjg@chromium.org> > > > In the case of USB_STORAGE we need to turn on DM_USB and then it works. > > > > > > If DM_USB is enabled, no USB controller are detected, so we loose Ethernet. Did I miss an additional option to enable? > > AFASK, the MUSB driver didn't yet support gadget mode when used with > DM_USB... at least until recently. I noticed that part of the MUSB > driver was updated, but the omap2430 glue hasn't been updated yet. I > am not 100% sure, but I think the Beagle xM is a DM3730 which uses the > omap2430 glue. I doubt TI will update the omap2430 glue, so I started > some stuff. I've got on patch that seems to show the usb gadget > controller in the DM tree, but my board hangs when I try to use a > gadget. > > It's not ready for the mailing list yet, but I can push this stuff to > my github later today if someone wants to look at it and/or > test/improve it. Guillaume, I 'think' I got the peripheral mode working on my DM3730. Like before, it only supports host or gadget, and I set the patch up to look at whether or not CONFIG_USB_MUSB_GADGET is set. I was able to get Fastboot devices to appear and an sdp device to appear. I wasn't setup to actually run data through those interfaces, but my host machine recognized them. Feel free to try the patches and please give feedback. They are located: https://patchwork.ozlabs.org/project/uboot/list/?series=82418 adam > > adam > > > > Guillaume > > > > > > _______________________________________________ > > U-Boot mailing list > > U-Boot@lists.denx.de > > https://lists.denx.de/listinfo/u-boot
On Mon, Dec 17, 2018 at 01:34:53PM -0600, Adam Ford wrote: > On Mon, Dec 17, 2018 at 11:04 AM Guillaume Gardet > <guillaume.gardet@free.fr> wrote: > > > > > > Le 21/11/2018 à 18:06, Tom Rini a écrit : > > > On Wed, Nov 21, 2018 at 04:13:20PM +0100, Guillaume GARDET wrote: > > > > > >> Also disable USB_STORAGE as it is not ready for the switch. > > >> Tested on a Beagleboard xM rev. B. > > >> > > >> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr> > > >> > > >> Cc: Tom Rini <trini@konsulko.com> > > >> Cc: Simon Glass <sjg@chromium.org> > > > In the case of USB_STORAGE we need to turn on DM_USB and then it works. > > > > > > If DM_USB is enabled, no USB controller are detected, so we loose Ethernet. Did I miss an additional option to enable? > > AFASK, the MUSB driver didn't yet support gadget mode when used with > DM_USB... at least until recently. I noticed that part of the MUSB > driver was updated, but the omap2430 glue hasn't been updated yet. I > am not 100% sure, but I think the Beagle xM is a DM3730 which uses the > omap2430 glue. I doubt TI will update the omap2430 glue, so I started > some stuff. I've got on patch that seems to show the usb gadget > controller in the DM tree, but my board hangs when I try to use a > gadget. > > It's not ready for the mailing list yet, but I can push this stuff to > my github later today if someone wants to look at it and/or > test/improve it. Thanks for looking into all this. Another thing missing right now is the logic to move to SPL FIT images and pick the right DTB for the variant we're on as for example my bb xM doesn't work at all once we switch to mostly DM :)
diff --git a/configs/omap3_beagle_defconfig b/configs/omap3_beagle_defconfig index 4fb8aec57d..b4ea714aef 100644 --- a/configs/omap3_beagle_defconfig +++ b/configs/omap3_beagle_defconfig @@ -37,6 +37,7 @@ CONFIG_OF_CONTROL=y CONFIG_DEFAULT_DEVICE_TREE="omap3-beagle" CONFIG_ENV_IS_IN_NAND=y CONFIG_SPL_DM=y +# CONFIG_SPL_BLK is not set CONFIG_USB_FUNCTION_FASTBOOT=y CONFIG_FASTBOOT_BUF_ADDR=0x82000000 CONFIG_LED_STATUS=y @@ -52,6 +53,8 @@ CONFIG_LED_STATUS_GREEN_ENABLE=y CONFIG_LED_STATUS_GREEN=2 CONFIG_LED_STATUS_CMD=y CONFIG_TWL4030_LED=y +CONFIG_DM_MMC=y +# CONFIG_SPL_DM_MMC is not set CONFIG_MMC_OMAP_HS=y CONFIG_NAND=y CONFIG_SYS_NAND_BUSWIDTH_16BIT=y @@ -66,7 +69,6 @@ CONFIG_USB_OMAP3=y CONFIG_USB_MUSB_GADGET=y CONFIG_USB_MUSB_OMAP2PLUS=y CONFIG_TWL4030_USB=y -CONFIG_USB_STORAGE=y CONFIG_USB_GADGET=y CONFIG_USB_GADGET_MANUFACTURER="TI" CONFIG_USB_GADGET_VENDOR_NUM=0x0451
Also disable USB_STORAGE as it is not ready for the switch. Tested on a Beagleboard xM rev. B. Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr> Cc: Tom Rini <trini@konsulko.com> Cc: Simon Glass <sjg@chromium.org> --- configs/omap3_beagle_defconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)