| Message ID | 20180921085948.26975-4-heiko@sntech.de |
|---|---|
| State | Accepted |
| Commit | 598a26a8fb94b7b86ecd2f4762eb5fcf46b9664e |
| Delegated to: | Philipp Tomsich |
| Headers | show |
| Series | rockchip: allow rk3188 to boot from mmc devices | expand |
On 21.09.2018, at 10:59, Heiko Stuebner <heiko@sntech.de> wrote: > > The dwmmc controllers on rk3188 do not have idma support, so need to > use the fifo-mode and it my tests they became confused and stopped > working if the frequency was to high. > > While I only tested in somewhat bigger steps, 32MHz for example > hung the controller, while reducing it to 16MHz worked just fine > and is reasonably fast to load a kernel from mmc. > > Signed-off-by: Heiko Stuebner <heiko@sntech.de> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> The dwmmc controllers on rk3188 do not have idma support, so need to > use the fifo-mode and it my tests they became confused and stopped > working if the frequency was to high. > > While I only tested in somewhat bigger steps, 32MHz for example > hung the controller, while reducing it to 16MHz worked just fine > and is reasonably fast to load a kernel from mmc. > > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > --- > arch/arm/dts/rk3188-radxarock-u-boot.dtsi | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > Applied to u-boot-rockchip, thanks!
diff --git a/arch/arm/dts/rk3188-radxarock-u-boot.dtsi b/arch/arm/dts/rk3188-radxarock-u-boot.dtsi index 013535abcd..1bb5408592 100644 --- a/arch/arm/dts/rk3188-radxarock-u-boot.dtsi +++ b/arch/arm/dts/rk3188-radxarock-u-boot.dtsi @@ -11,6 +11,21 @@ u-boot,dm-spl; }; +&mmc0 { + fifo-mode; + max-frequency = <16000000>; +}; + +&mmc1 { + fifo-mode; + max-frequency = <16000000>; +}; + +&emmc { + fifo-mode; + max-frequency = <16000000>; +}; + &uart2 { status = "okay"; u-boot,dm-spl;
The dwmmc controllers on rk3188 do not have idma support, so need to use the fifo-mode and it my tests they became confused and stopped working if the frequency was to high. While I only tested in somewhat bigger steps, 32MHz for example hung the controller, while reducing it to 16MHz worked just fine and is reasonably fast to load a kernel from mmc. Signed-off-by: Heiko Stuebner <heiko@sntech.de> --- arch/arm/dts/rk3188-radxarock-u-boot.dtsi | 15 +++++++++++++++ 1 file changed, 15 insertions(+)