| Message ID | 20180831115828.15831-1-lukma@denx.de |
|---|---|
| State | Accepted |
| Commit | 21c22db014a7c5d9c182a6da15f365b4d4f26774 |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | [U-Boot,1/4] ARM: bootscript: Remove hard-coded rootpath from K+P's tpcboot.cmd | expand |
Dear Tom, Stefano, > The 'rootpath' can be provided by DHCP server. Removing this line > prevents from overwriting it. > > To do that on the DHCP server side (isc-dhcp-server) modify dhcpd.conf > and add 'option root-path "192.168.X.Y:/srv/tftp/rootfs";' > > Signed-off-by: Lukasz Majewski <lukma@denx.de> > --- > > board/k+p/bootscripts/tpcboot.cmd | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/board/k+p/bootscripts/tpcboot.cmd > b/board/k+p/bootscripts/tpcboot.cmd index 16b93ebe3f..9290317730 > 100644 --- a/board/k+p/bootscripts/tpcboot.cmd > +++ b/board/k+p/bootscripts/tpcboot.cmd > @@ -65,7 +65,6 @@ fi" > # > # Provide 'boot_nfs' command > #------------------------------------------------------------ > -setenv rootpath "/srv/tftp/KP/rootfs" > setenv nfsargs "setenv bootargs root=/dev/nfs rw \ > nfsroot=${serverip}:${rootpath},nolock,nfsvers=3" > setenv addip "setenv bootargs ${bootargs} \ Is there any chance that this series would be applied before v2018.09 release? Those are fixes related to a particular board(s), which I do maintain. Thanks in advance. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Hi Lukasz, On 07/09/2018 00:53, Lukasz Majewski wrote: > Dear Tom, Stefano, > >> The 'rootpath' can be provided by DHCP server. Removing this line >> prevents from overwriting it. >> >> To do that on the DHCP server side (isc-dhcp-server) modify dhcpd.conf >> and add 'option root-path "192.168.X.Y:/srv/tftp/rootfs";' >> >> Signed-off-by: Lukasz Majewski <lukma@denx.de> >> --- >> >> board/k+p/bootscripts/tpcboot.cmd | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/board/k+p/bootscripts/tpcboot.cmd >> b/board/k+p/bootscripts/tpcboot.cmd index 16b93ebe3f..9290317730 >> 100644 --- a/board/k+p/bootscripts/tpcboot.cmd >> +++ b/board/k+p/bootscripts/tpcboot.cmd >> @@ -65,7 +65,6 @@ fi" >> # >> # Provide 'boot_nfs' command >> #------------------------------------------------------------ >> -setenv rootpath "/srv/tftp/KP/rootfs" >> setenv nfsargs "setenv bootargs root=/dev/nfs rw \ >> nfsroot=${serverip}:${rootpath},nolock,nfsvers=3" >> setenv addip "setenv bootargs ${bootargs} \ > > Is there any chance that this series would be applied before v2018.09 > release? > > Those are fixes related to a particular board(s), which I do maintain. > Patches were sent just a week ago, merge window was closed. This is the same case as Otavio's and I will merge them after release. Best regards, Stefano
Hi Stefano, > Hi Lukasz, > > On 07/09/2018 00:53, Lukasz Majewski wrote: > > Dear Tom, Stefano, > > > >> The 'rootpath' can be provided by DHCP server. Removing this line > >> prevents from overwriting it. > >> > >> To do that on the DHCP server side (isc-dhcp-server) modify > >> dhcpd.conf and add 'option root-path > >> "192.168.X.Y:/srv/tftp/rootfs";' > >> > >> Signed-off-by: Lukasz Majewski <lukma@denx.de> > >> --- > >> > >> board/k+p/bootscripts/tpcboot.cmd | 1 - > >> 1 file changed, 1 deletion(-) > >> > >> diff --git a/board/k+p/bootscripts/tpcboot.cmd > >> b/board/k+p/bootscripts/tpcboot.cmd index 16b93ebe3f..9290317730 > >> 100644 --- a/board/k+p/bootscripts/tpcboot.cmd > >> +++ b/board/k+p/bootscripts/tpcboot.cmd > >> @@ -65,7 +65,6 @@ fi" > >> # > >> # Provide 'boot_nfs' command > >> #------------------------------------------------------------ > >> -setenv rootpath "/srv/tftp/KP/rootfs" > >> setenv nfsargs "setenv bootargs root=/dev/nfs rw \ > >> nfsroot=${serverip}:${rootpath},nolock,nfsvers=3" > >> setenv addip "setenv bootargs ${bootargs} \ > > > > Is there any chance that this series would be applied before > > v2018.09 release? > > > > Those are fixes related to a particular board(s), which I do > > maintain. > > Patches were sent just a week ago, merge window was closed. This is > the same case as Otavio's and I will merge them after release. Ok. No problem :-) > > Best regards, > Stefano > Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
diff --git a/board/k+p/bootscripts/tpcboot.cmd b/board/k+p/bootscripts/tpcboot.cmd index 16b93ebe3f..9290317730 100644 --- a/board/k+p/bootscripts/tpcboot.cmd +++ b/board/k+p/bootscripts/tpcboot.cmd @@ -65,7 +65,6 @@ fi" # # Provide 'boot_nfs' command #------------------------------------------------------------ -setenv rootpath "/srv/tftp/KP/rootfs" setenv nfsargs "setenv bootargs root=/dev/nfs rw \ nfsroot=${serverip}:${rootpath},nolock,nfsvers=3" setenv addip "setenv bootargs ${bootargs} \
The 'rootpath' can be provided by DHCP server. Removing this line prevents from overwriting it. To do that on the DHCP server side (isc-dhcp-server) modify dhcpd.conf and add 'option root-path "192.168.X.Y:/srv/tftp/rootfs";' Signed-off-by: Lukasz Majewski <lukma@denx.de> --- board/k+p/bootscripts/tpcboot.cmd | 1 - 1 file changed, 1 deletion(-)