| Message ID | 20180621144716.27976-1-ramon.fried@gmail.com |
|---|---|
| State | Accepted |
| Commit | 8d545790729434f4ba718dd9a6a1b55dcf7e94c4 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot] test: Add ut_assertnull macro | expand |
Hi Simon. Would love to get this reviewed. can you assist ? Thanks. Ramon. On Fri, Jun 22, 2018 at 12:47 AM Ramon Fried <ramon.fried@gmail.com> wrote: > > Add ut_assertnull macro to include/test/ut.h > For testing of functions that returns NULL on errors. > > Signed-off-by: Ramon Fried <ramon.fried@gmail.com> > --- > include/test/ut.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/include/test/ut.h b/include/test/ut.h > index 59b23a25a4..fce75fd12a 100644 > --- a/include/test/ut.h > +++ b/include/test/ut.h > @@ -90,6 +90,18 @@ void ut_failf(struct unit_test_state *uts, const char *fname, int line, > } \ > } > > +/* Assert that a pointer is NULL */ > +#define ut_assertnull(expr) { \ > + const void *val = (expr); \ > + \ > + if (val != NULL) { \ > + ut_failf(uts, __FILE__, __LINE__, __func__, \ > + #expr " != NULL", \ > + "Expected NULL, got %p", val); \ > + return CMD_RET_FAILURE; \ > + } \ > +} > + > /* Assert that a pointer is not NULL */ > #define ut_assertnonnull(expr) { \ > const void *val = (expr); \ > -- > 2.17.1 >
On 21 June 2018 at 08:47, Ramon Fried <ramon.fried@gmail.com> wrote: > Add ut_assertnull macro to include/test/ut.h > For testing of functions that returns NULL on errors. > > Signed-off-by: Ramon Fried <ramon.fried@gmail.com> > --- > include/test/ut.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > Reviewed-by: Simon Glass <sjg@chromium.org>
On July 10, 2018 11:49:31 PM GMT+03:00, Simon Glass <sjg@chromium.org> wrote: >On 21 June 2018 at 08:47, Ramon Fried <ramon.fried@gmail.com> wrote: >> Add ut_assertnull macro to include/test/ut.h >> For testing of functions that returns NULL on errors. >> >> Signed-off-by: Ramon Fried <ramon.fried@gmail.com> >> --- >> include/test/ut.h | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> > >Reviewed-by: Simon Glass <sjg@chromium.org> Thanks!
On Thu, Jun 21, 2018 at 05:47:16PM +0300, Ramon Fried wrote: > Add ut_assertnull macro to include/test/ut.h > For testing of functions that returns NULL on errors. > > Signed-off-by: Ramon Fried <ramon.fried@gmail.com> > Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot/master, thanks!
diff --git a/include/test/ut.h b/include/test/ut.h index 59b23a25a4..fce75fd12a 100644 --- a/include/test/ut.h +++ b/include/test/ut.h @@ -90,6 +90,18 @@ void ut_failf(struct unit_test_state *uts, const char *fname, int line, } \ } +/* Assert that a pointer is NULL */ +#define ut_assertnull(expr) { \ + const void *val = (expr); \ + \ + if (val != NULL) { \ + ut_failf(uts, __FILE__, __LINE__, __func__, \ + #expr " != NULL", \ + "Expected NULL, got %p", val); \ + return CMD_RET_FAILURE; \ + } \ +} + /* Assert that a pointer is not NULL */ #define ut_assertnonnull(expr) { \ const void *val = (expr); \
Add ut_assertnull macro to include/test/ut.h For testing of functions that returns NULL on errors. Signed-off-by: Ramon Fried <ramon.fried@gmail.com> --- include/test/ut.h | 12 ++++++++++++ 1 file changed, 12 insertions(+)