diff mbox series

[U-Boot] spi: kirkwood: add orion-spi compatible string

Message ID 20180507225424.31343-1-judge.packham@gmail.com
State Accepted
Delegated to: Jagannadha Sutradharudu Teki
Headers show
Series [U-Boot] spi: kirkwood: add orion-spi compatible string | expand

Commit Message

Chris Packham May 7, 2018, 10:54 p.m. UTC
This matches the compatible string used by the Linux kernel. This will
allow u-boot to use the same device tree files.

Signed-off-by: Chris Packham <judge.packham@gmail.com>
---
This applies on top of Jagan's series
http://patchwork.ozlabs.org/project/uboot/list/?series=33927

 drivers/spi/kirkwood_spi.c | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Jagan Teki May 8, 2018, 5:17 a.m. UTC | #1
On Tue, May 8, 2018 at 4:24 AM, Chris Packham <judge.packham@gmail.com> wrote:
> This matches the compatible string used by the Linux kernel. This will
> allow u-boot to use the same device tree files.
>
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> ---
> This applies on top of Jagan's series
> http://patchwork.ozlabs.org/project/uboot/list/?series=33927
>
>  drivers/spi/kirkwood_spi.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/spi/kirkwood_spi.c b/drivers/spi/kirkwood_spi.c
> index 036fc36b8329..6a5ab8a1cba4 100644
> --- a/drivers/spi/kirkwood_spi.c
> +++ b/drivers/spi/kirkwood_spi.c
> @@ -226,6 +226,10 @@ static int mvebu_spi_ofdata_to_platdata(struct udevice *bus)
>         return 0;
>  }
>
> +static const struct mvebu_spi_dev orion_spi_dev_data = {
> +       .is_errata_50mhz_ac = false,
> +};
> +
>  static const struct mvebu_spi_dev armada_xp_spi_dev_data = {
>         .is_errata_50mhz_ac = false,
>  };
> @@ -239,6 +243,10 @@ static const struct mvebu_spi_dev armada_380_spi_dev_data = {
>  };
>
>  static const struct udevice_id mvebu_spi_ids[] = {
> +       {
> +               .compatible = "marvell,orion-spi",
> +               .data = (ulong)&orion_spi_dev_data

Reviewed-by: Jagan Teki <jagan@openedev.com>
Michael Walle July 9, 2018, 6:52 p.m. UTC | #2
Am 2018-05-08 00:54, schrieb Chris Packham:
> This matches the compatible string used by the Linux kernel. This will
> allow u-boot to use the same device tree files.

This patch is still missing to make SPI on kirkwoods work. Is there 
anything missing which prevents it from being applied?

-michael

> 
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> ---
> This applies on top of Jagan's series
> http://patchwork.ozlabs.org/project/uboot/list/?series=33927
> 
>  drivers/spi/kirkwood_spi.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/spi/kirkwood_spi.c b/drivers/spi/kirkwood_spi.c
> index 036fc36b8329..6a5ab8a1cba4 100644
> --- a/drivers/spi/kirkwood_spi.c
> +++ b/drivers/spi/kirkwood_spi.c
> @@ -226,6 +226,10 @@ static int mvebu_spi_ofdata_to_platdata(struct
> udevice *bus)
>  	return 0;
>  }
> 
> +static const struct mvebu_spi_dev orion_spi_dev_data = {
> +	.is_errata_50mhz_ac = false,
> +};
> +
>  static const struct mvebu_spi_dev armada_xp_spi_dev_data = {
>  	.is_errata_50mhz_ac = false,
>  };
> @@ -239,6 +243,10 @@ static const struct mvebu_spi_dev
> armada_380_spi_dev_data = {
>  };
> 
>  static const struct udevice_id mvebu_spi_ids[] = {
> +	{
> +		.compatible = "marvell,orion-spi",
> +		.data = (ulong)&orion_spi_dev_data
> +	},
>  	{
>  		.compatible = "marvell,armada-375-spi",
>  		.data = (ulong)&armada_375_spi_dev_data
Jagan Teki Aug. 1, 2018, 6:50 a.m. UTC | #3
On Tue, May 8, 2018 at 10:47 AM, Jagan Teki <jagannadh.teki@gmail.com> wrote:
> On Tue, May 8, 2018 at 4:24 AM, Chris Packham <judge.packham@gmail.com> wrote:
>> This matches the compatible string used by the Linux kernel. This will
>> allow u-boot to use the same device tree files.
>>
>> Signed-off-by: Chris Packham <judge.packham@gmail.com>
>> ---
>> This applies on top of Jagan's series
>> http://patchwork.ozlabs.org/project/uboot/list/?series=33927
>>
>>  drivers/spi/kirkwood_spi.c | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/spi/kirkwood_spi.c b/drivers/spi/kirkwood_spi.c
>> index 036fc36b8329..6a5ab8a1cba4 100644
>> --- a/drivers/spi/kirkwood_spi.c
>> +++ b/drivers/spi/kirkwood_spi.c
>> @@ -226,6 +226,10 @@ static int mvebu_spi_ofdata_to_platdata(struct udevice *bus)
>>         return 0;
>>  }
>>
>> +static const struct mvebu_spi_dev orion_spi_dev_data = {
>> +       .is_errata_50mhz_ac = false,
>> +};
>> +
>>  static const struct mvebu_spi_dev armada_xp_spi_dev_data = {
>>         .is_errata_50mhz_ac = false,
>>  };
>> @@ -239,6 +243,10 @@ static const struct mvebu_spi_dev armada_380_spi_dev_data = {
>>  };
>>
>>  static const struct udevice_id mvebu_spi_ids[] = {
>> +       {
>> +               .compatible = "marvell,orion-spi",
>> +               .data = (ulong)&orion_spi_dev_data
>
> Reviewed-by: Jagan Teki <jagan@openedev.com>

Applied to u-boot-spi/master
diff mbox series

Patch

diff --git a/drivers/spi/kirkwood_spi.c b/drivers/spi/kirkwood_spi.c
index 036fc36b8329..6a5ab8a1cba4 100644
--- a/drivers/spi/kirkwood_spi.c
+++ b/drivers/spi/kirkwood_spi.c
@@ -226,6 +226,10 @@  static int mvebu_spi_ofdata_to_platdata(struct udevice *bus)
 	return 0;
 }
 
+static const struct mvebu_spi_dev orion_spi_dev_data = {
+	.is_errata_50mhz_ac = false,
+};
+
 static const struct mvebu_spi_dev armada_xp_spi_dev_data = {
 	.is_errata_50mhz_ac = false,
 };
@@ -239,6 +243,10 @@  static const struct mvebu_spi_dev armada_380_spi_dev_data = {
 };
 
 static const struct udevice_id mvebu_spi_ids[] = {
+	{
+		.compatible = "marvell,orion-spi",
+		.data = (ulong)&orion_spi_dev_data
+	},
 	{
 		.compatible = "marvell,armada-375-spi",
 		.data = (ulong)&armada_375_spi_dev_data