| Message ID | 20171204020513.18708-8-andre.przywara@arm.com |
|---|---|
| State | Accepted |
| Commit | 4d4db83d184c6d89d55239bbc83b01b566cffdc9 |
| Delegated to: | Simon Glass |
| Headers | show |
| Series | Fix incorrect usage of the (FIT) DT node unit address | expand |
Hi Andre, On 3 December 2017 at 19:05, Andre Przywara <andre.przywara@arm.com> wrote: > The DT spec demands a unit-address in a node name to match the "reg" > property in that node. Newer dtc versions will throw warnings if this is > not the case. > Remove the unit address from the config node name when U-Boot deals with > secure firmware FIT images. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > arch/arm/cpu/armv8/sec_firmware.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org> After this series, what remains to be converted? - Simon
Hi Andre, On 3 December 2017 at 19:05, Andre Przywara <andre.przywara@arm.com> wrote: > The DT spec demands a unit-address in a node name to match the "reg" > property in that node. Newer dtc versions will throw warnings if this is > not the case. > Remove the unit address from the config node name when U-Boot deals with > secure firmware FIT images. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > arch/arm/cpu/armv8/sec_firmware.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org> After this series, what remains to be converted? - Simon Applied to u-boot-dm thanks!
Hi Andre, On 3 December 2017 at 19:05, Andre Przywara <andre.przywara@arm.com> wrote: > The DT spec demands a unit-address in a node name to match the "reg" > property in that node. Newer dtc versions will throw warnings if this is > not the case. > Remove the unit address from the config node name when U-Boot deals with > secure firmware FIT images. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > arch/arm/cpu/armv8/sec_firmware.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org> After this series, what remains to be converted? - Simon Applied to u-boot-dm thanks! Applied to u-boot-dm thanks!
diff --git a/arch/arm/cpu/armv8/sec_firmware.c b/arch/arm/cpu/armv8/sec_firmware.c index 927eae4f74..b56ea785c5 100644 --- a/arch/arm/cpu/armv8/sec_firmware.c +++ b/arch/arm/cpu/armv8/sec_firmware.c @@ -30,7 +30,7 @@ phys_addr_t sec_firmware_addr; #define SEC_FIRMWARE_FIT_IMAGE "firmware" #endif #ifndef SEC_FIRMEWARE_FIT_CNF_NAME -#define SEC_FIRMEWARE_FIT_CNF_NAME "config@1" +#define SEC_FIRMEWARE_FIT_CNF_NAME "config-1" #endif #ifndef SEC_FIRMWARE_TARGET_EL #define SEC_FIRMWARE_TARGET_EL 2
The DT spec demands a unit-address in a node name to match the "reg" property in that node. Newer dtc versions will throw warnings if this is not the case. Remove the unit address from the config node name when U-Boot deals with secure firmware FIT images. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- arch/arm/cpu/armv8/sec_firmware.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)