diff mbox series

[U-Boot] armv8: ls1043ardb: disable PPA loading during SPL stage for SD boot

Message ID 20170918065837.33867-1-yangbo.lu@nxp.com
State Accepted
Commit e2c43a42425f0a8f80bf7e563767a78d28965565
Delegated to: York Sun
Headers show
Series [U-Boot] armv8: ls1043ardb: disable PPA loading during SPL stage for SD boot | expand

Commit Message

Yangbo Lu Sept. 18, 2017, 6:58 a.m. UTC
PPA loading during SPL stage is not required for nornal
SD boot scenario.

Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
---
 configs/ls1043ardb_sdcard_defconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

York Sun Sept. 18, 2017, 2:57 p.m. UTC | #1
On 09/18/2017 12:16 AM, Yangbo Lu wrote:
> PPA loading during SPL stage is not required for nornal
> SD boot scenario.
> 

Once PPA is loaded during SPL boot, RAM version U-Boot won't load it 
again. It is used for falcon boot. Does it hurt anything?

York
Yangbo Lu Sept. 19, 2017, 1:56 a.m. UTC | #2
Hi York,

Yes. We got below crash on ls1046ardb if we write ppa to SD card.

=> cpld reset sd
U-Boot SPL 2017.07-g25cd705 (Sep 15 2017 - 03:27:02)
Initializing DDR....using SPD
WARNING: Calling __hwconfig without a buffer and before environment is ready
WARNING: Calling __hwconfig without a buffer and before environment is ready
WARNING: Calling __hwconfig without a buffer and before environment is ready
WARNING: Calling __hwconfig without a buffer and before environment is ready
PPA Firmware: Version LSDK-17.09-TC3
"Synchronous Abort" handler, esr 0x96000040
ELR: 1000a270
LR: 1000277c
x0 : ec000cb28a045000 x1 : 000000008f080318
x2 : 000000000000bcd0 x3 : 0000000000000000
x4 : 000000000000179a x5 : 000000000000bcd0
x6 : aa1e03ec1000000d x7 : 0000000000000094
x8 : 000000001001f770 x9 : 0000000000000080
x10: 000000001001f5fd x11: 0000000000000000
x12: 00000000ffffffff x13: 00000000ffffffff
x14: 000000001001f80c x15: 000000008f080240
x16: 000000001001f644 x17: 0000000000000001
x18: 000000001001fa20 x19: ec000cb28a045000
x20: 000000008f080240 x21: 000000008f000000
x22: 0000000001570604 x23: 0000000001570600
x24: 000000000157060c x25: 0000000001570608
x26: 00000000100128e4 x27: 000000000000bcd0
x28: 00000000fff7a990 x29: 000000001001f8b0
Resetting CPU ...
resetting ...



Thanks a lot.

Best regards,
Yangbo Lu


-----Original Message-----
From: York Sun 

Sent: 2017年9月18日 22:58
To: Y.b. Lu <yangbo.lu@nxp.com>; u-boot@lists.denx.de
Subject: Re: [PATCH] armv8: ls1043ardb: disable PPA loading during SPL stage for SD boot

On 09/18/2017 12:16 AM, Yangbo Lu wrote:
> PPA loading during SPL stage is not required for nornal SD boot 

> scenario.

> 


Once PPA is loaded during SPL boot, RAM version U-Boot won't load it again. It is used for falcon boot. Does it hurt anything?

York
York Sun Sept. 19, 2017, 2:24 a.m. UTC | #3
On 09/18/2017 06:56 PM, Y.b. Lu wrote:
> Hi York,
> 
> Yes. We got below crash on ls1046ardb if we write ppa to SD card.
> 
> => cpld reset sd
> U-Boot SPL 2017.07-g25cd705 (Sep 15 2017 - 03:27:02)
> Initializing DDR....using SPD
> WARNING: Calling __hwconfig without a buffer and before environment is ready
> WARNING: Calling __hwconfig without a buffer and before environment is ready
> WARNING: Calling __hwconfig without a buffer and before environment is ready
> WARNING: Calling __hwconfig without a buffer and before environment is ready
> PPA Firmware: Version LSDK-17.09-TC3
> "Synchronous Abort" handler, esr 0x96000040
> ELR: 1000a270
> LR: 1000277c
> x0 : ec000cb28a045000 x1 : 000000008f080318
> x2 : 000000000000bcd0 x3 : 0000000000000000
> x4 : 000000000000179a x5 : 000000000000bcd0
> x6 : aa1e03ec1000000d x7 : 0000000000000094
> x8 : 000000001001f770 x9 : 0000000000000080
> x10: 000000001001f5fd x11: 0000000000000000
> x12: 00000000ffffffff x13: 00000000ffffffff
> x14: 000000001001f80c x15: 000000008f080240
> x16: 000000001001f644 x17: 0000000000000001
> x18: 000000001001fa20 x19: ec000cb28a045000
> x20: 000000008f080240 x21: 000000008f000000
> x22: 0000000001570604 x23: 0000000001570600
> x24: 000000000157060c x25: 0000000001570608
> x26: 00000000100128e4 x27: 000000000000bcd0
> x28: 00000000fff7a990 x29: 000000001001f8b0
> Resetting CPU ...
> resetting ...
> 

I see. We have out-of-sync PPA image. Let's take your patch for now.

York
York Sun Sept. 25, 2017, 5:34 p.m. UTC | #4
On 09/18/2017 12:16 AM, Yangbo Lu wrote:
> PPA loading during SPL stage is not required for nornal
> SD boot scenario.
> 
> Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
> ---

Applied to fsl-qoriq mater. Thanks.

York
diff mbox series

Patch

diff --git a/configs/ls1043ardb_sdcard_defconfig b/configs/ls1043ardb_sdcard_defconfig
index efdaaa3d69..f6ea06bfb0 100644
--- a/configs/ls1043ardb_sdcard_defconfig
+++ b/configs/ls1043ardb_sdcard_defconfig
@@ -3,7 +3,6 @@  CONFIG_TARGET_LS1043ARDB=y
 CONFIG_SPL_LIBCOMMON_SUPPORT=y
 CONFIG_SPL_LIBGENERIC_SUPPORT=y
 CONFIG_FSL_LS_PPA=y
-CONFIG_SPL_FSL_LS_PPA=y
 CONFIG_SPL_MMC_SUPPORT=y
 CONFIG_SPL_SERIAL_SUPPORT=y
 CONFIG_SPL_DRIVERS_MISC_SUPPORT=y