| Message ID | 20170223163040.9303-2-heiko@sntech.de |
|---|---|
| State | Superseded |
| Delegated to: | Simon Glass |
| Headers | show |
On 23 February 2017 at 09:30, Heiko Stuebner <heiko@sntech.de> wrote: > Commit c67c8c604b6c ("board_init.c: Always use memset()") dropped the naive > memset alternative from board_init_f_init_reserve. > So activate CONFIG_TPL_LIBGENERIC for that common memset implementation. > We cannot use the ARCH-specific memset, as that would incur 200bytes of > additional TPL size, space we do not have. > > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > --- > arch/arm/mach-rockchip/rk3188/Kconfig | 3 +++ > configs/rock_defconfig | 2 ++ > 2 files changed, 5 insertions(+) Acked-by: Simon Glass <sjg@chromium.org>
diff --git a/arch/arm/mach-rockchip/rk3188/Kconfig b/arch/arm/mach-rockchip/rk3188/Kconfig index 5afc23ad2f..d129fcda99 100644 --- a/arch/arm/mach-rockchip/rk3188/Kconfig +++ b/arch/arm/mach-rockchip/rk3188/Kconfig @@ -27,6 +27,9 @@ config SPL_SERIAL_SUPPORT config TPL_LIBCOMMON_SUPPORT default y +config TPL_LIBGENERIC_SUPPORT + default y + config TPL_SERIAL_SUPPORT default y diff --git a/configs/rock_defconfig b/configs/rock_defconfig index 2705909e6c..86048c8fd7 100644 --- a/configs/rock_defconfig +++ b/configs/rock_defconfig @@ -34,6 +34,8 @@ CONFIG_REGMAP=y CONFIG_SYSCON=y # CONFIG_SPL_SIMPLE_BUS is not set # CONFIG_SPL_MMC_SUPPORT is not set +# CONFIG_SPL_USE_ARCH_MEMSET is not set +# CONFIG_SPL_USE_ARCH_MEMCPY is not set CONFIG_MMC_DW=y CONFIG_MMC_DW_ROCKCHIP=y CONFIG_CLK=y
Commit c67c8c604b6c ("board_init.c: Always use memset()") dropped the naive memset alternative from board_init_f_init_reserve. So activate CONFIG_TPL_LIBGENERIC for that common memset implementation. We cannot use the ARCH-specific memset, as that would incur 200bytes of additional TPL size, space we do not have. Signed-off-by: Heiko Stuebner <heiko@sntech.de> --- arch/arm/mach-rockchip/rk3188/Kconfig | 3 +++ configs/rock_defconfig | 2 ++ 2 files changed, 5 insertions(+)