| Message ID | 20170209040012.20324-4-lokeshvutla@ti.com |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
On Thu, Feb 09, 2017 at 09:30:10AM +0530, Lokesh Vutla wrote: > Add u-boot specific dtsi so that this will be > included automatically while building dts. > > Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> Reviewed-by: Tom Rini <trini@konsulko.com>
On Friday 10 February 2017 09:00 AM, Tom Rini wrote: > On Thu, Feb 09, 2017 at 09:30:10AM +0530, Lokesh Vutla wrote: > >> Add u-boot specific dtsi so that this will be >> included automatically while building dts. >> >> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> > > Reviewed-by: Tom Rini <trini@konsulko.com> > As I said earlier, I see a problem with this approach. We want this omap5-u-boot.dtsi only for SPL. But Makefile.lib tries to append this for each dtb in proper U-Boot as well. As we might not need any of these in U-Boot before relocation, the behavior is unexpected(sometimes U-boot does not comes up ). I would like to go ahead with V1 of this series, what do you say? Thanks and regards, Lokesh
On Fri, Feb 10, 2017 at 05:22:12PM +0530, Lokesh Vutla wrote: > > > On Friday 10 February 2017 09:00 AM, Tom Rini wrote: > > On Thu, Feb 09, 2017 at 09:30:10AM +0530, Lokesh Vutla wrote: > > > >> Add u-boot specific dtsi so that this will be > >> included automatically while building dts. > >> > >> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> > > > > Reviewed-by: Tom Rini <trini@konsulko.com> > > As I said earlier, I see a problem with this approach. We want this > omap5-u-boot.dtsi only > for SPL. But Makefile.lib tries to append this for each dtb in proper > U-Boot as well. As we might not need any of these in U-Boot before > relocation, the behavior is unexpected(sometimes U-boot does not comes > up ). I would like to go ahead with V1 of this series, what do you say? All of the other platforms are able to have pre-reloc on nodes without issue, can you describe what's going on a bit more? Simon, any ideas? Thanks!
On Friday 10 February 2017 05:42 PM, Tom Rini wrote: > On Fri, Feb 10, 2017 at 05:22:12PM +0530, Lokesh Vutla wrote: >> >> >> On Friday 10 February 2017 09:00 AM, Tom Rini wrote: >>> On Thu, Feb 09, 2017 at 09:30:10AM +0530, Lokesh Vutla wrote: >>> >>>> Add u-boot specific dtsi so that this will be >>>> included automatically while building dts. >>>> >>>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> >>> >>> Reviewed-by: Tom Rini <trini@konsulko.com> >> >> As I said earlier, I see a problem with this approach. We want this >> omap5-u-boot.dtsi only >> for SPL. But Makefile.lib tries to append this for each dtb in proper >> U-Boot as well. As we might not need any of these in U-Boot before >> relocation, the behavior is unexpected(sometimes U-boot does not comes >> up ). I would like to go ahead with V1 of this series, what do you say? > > All of the other platforms are able to have pre-reloc on nodes without > issue, can you describe what's going on a bit more? Simon, any ideas? > Thanks! > So, when more nodes were added with pre-reloc, dm_scan_fdt() is failing with NOMEM. Then I realized that SYS_MALLOC_F_LEN is 0x400 which is very less. Increased the length to 0x2000 and everything working fine. Sorry for the noise :) Will be posting an updated series soon. Thanks and regards, Lokesh
diff --git a/arch/arm/dts/omap5-u-boot.dtsi b/arch/arm/dts/omap5-u-boot.dtsi new file mode 100644 index 0000000000..cd37ec4fe8 --- /dev/null +++ b/arch/arm/dts/omap5-u-boot.dtsi @@ -0,0 +1,46 @@ +/* + * Copyright (C) 2017 Texas Instruments Incorporated - http://www.ti.com/ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + * Based on "dra7.dtsi" + */ + +/{ + ocp { + u-boot,dm-pre-reloc; + }; +}; + +&uart1 { + u-boot,dm-pre-reloc; +}; + +&uart3 { + u-boot,dm-pre-reloc; +}; + +&mmc1 { + u-boot,dm-pre-reloc; +}; + +&mmc2 { + u-boot,dm-pre-reloc; +}; + +&l4_wkup { + u-boot,dm-pre-reloc; +}; + +&scm_wkup { + u-boot,dm-pre-reloc; +}; + +&qspi { + u-boot,dm-pre-reloc; + + m25p80@0 { + u-boot,dm-pre-reloc; + }; +};
Add u-boot specific dtsi so that this will be included automatically while building dts. Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> --- arch/arm/dts/omap5-u-boot.dtsi | 46 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 46 insertions(+) create mode 100644 arch/arm/dts/omap5-u-boot.dtsi