diff mbox

[U-Boot,2/6] ARM: OMAP2+: define _image_binary_end to fix SPL_OF_CONTROL

Message ID 20170208123337.27079-3-lokeshvutla@ti.com
State Accepted
Commit 4d451c00825ab7c4d25dc507d9a81e90ad3eb308
Delegated to: Tom Rini
Headers show

Commit Message

Lokesh Vutla Feb. 8, 2017, 12:33 p.m. UTC 
To make SPL_OF_CONTROL work on OAP2+ SoCs, _image_binary_end must be
defined in the linker script along with CONFIG_SPL_SEPARATE_BSS.

Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
 arch/arm/mach-omap2/u-boot-spl.lds | 2 ++
 1 file changed, 2 insertions(+)

Comments

Tom Rini Feb. 8, 2017, 1:50 p.m. UTC | #1 
On Wed, Feb 08, 2017 at 06:03:33PM +0530, Lokesh Vutla wrote:

> To make SPL_OF_CONTROL work on OAP2+ SoCs, _image_binary_end must be
> defined in the linker script along with CONFIG_SPL_SEPARATE_BSS.
> 
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>

Reviewed-by: Tom Rini <trini@konsulko.com>
Ladislav Michl Feb. 8, 2017, 4:33 p.m. UTC | #2 
On Wed, Feb 08, 2017 at 06:03:33PM +0530, Lokesh Vutla wrote:
> To make SPL_OF_CONTROL work on OAP2+ SoCs, _image_binary_end must be
                    OMAP2+  ---> ^^^^^

Just a nitpick, but helps grepping for changes in git log.

Thank you,
	ladis

> defined in the linker script along with CONFIG_SPL_SEPARATE_BSS.
> 
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> ---
>  arch/arm/mach-omap2/u-boot-spl.lds | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/mach-omap2/u-boot-spl.lds b/arch/arm/mach-omap2/u-boot-spl.lds
> index 8fec715ca5..e9da2a9dd1 100644
> --- a/arch/arm/mach-omap2/u-boot-spl.lds
> +++ b/arch/arm/mach-omap2/u-boot-spl.lds
> @@ -46,6 +46,8 @@ SECTIONS
>  		*(.__end)
>  	}
>  
> +	_image_binary_end = .;
> +
>  	.bss :
>  	{
>  		. = ALIGN(4);
> -- 
> 2.11.0
> 
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
Lokesh Vutla Feb. 9, 2017, 4:01 a.m. UTC | #3 
On Wednesday 08 February 2017 10:03 PM, Ladislav Michl wrote:
> On Wed, Feb 08, 2017 at 06:03:33PM +0530, Lokesh Vutla wrote:
>> To make SPL_OF_CONTROL work on OAP2+ SoCs, _image_binary_end must be
>                     OMAP2+  ---> ^^^^^
> 
> Just a nitpick, but helps grepping for changes in git log.

Oops. Updated version just posted.

Thanks and regards,
Lokesh
diff mbox

Patch

diff --git a/arch/arm/mach-omap2/u-boot-spl.lds b/arch/arm/mach-omap2/u-boot-spl.lds
index 8fec715ca5..e9da2a9dd1 100644
--- a/arch/arm/mach-omap2/u-boot-spl.lds
+++ b/arch/arm/mach-omap2/u-boot-spl.lds
@@ -46,6 +46,8 @@  SECTIONS
 		*(.__end)
 	}
 
+	_image_binary_end = .;
+
 	.bss :
 	{
 		. = ALIGN(4);