diff mbox

[U-Boot,01/12] aspeed: Add mach-aspeed directory and basic Kconfig

Message ID 20170104194656.124368-2-maxims@google.com
State Superseded
Delegated to: Tom Rini
Headers show

Commit Message

Maxim Sloyko Jan. 4, 2017, 7:46 p.m. UTC 
Signed-off-by: Maxim Sloyko <maxims@google.com>
---

 arch/arm/Kconfig              |  7 +++++++
 arch/arm/Makefile             |  1 +
 arch/arm/mach-aspeed/Kconfig  | 15 +++++++++++++++
 arch/arm/mach-aspeed/Makefile |  8 ++++++++
 4 files changed, 31 insertions(+)
 create mode 100644 arch/arm/mach-aspeed/Kconfig
 create mode 100644 arch/arm/mach-aspeed/Makefile

Comments

Rick Altherr Jan. 4, 2017, 7:58 p.m. UTC | #1 
On Wed, Jan 4, 2017 at 11:46 AM, Maxim Sloyko <maxims@google.com> wrote:

> Signed-off-by: Maxim Sloyko <maxims@google.com>
> ---
>
>  arch/arm/Kconfig              |  7 +++++++
>  arch/arm/Makefile             |  1 +
>  arch/arm/mach-aspeed/Kconfig  | 15 +++++++++++++++
>  arch/arm/mach-aspeed/Makefile |  8 ++++++++
>  4 files changed, 31 insertions(+)
>  create mode 100644 arch/arm/mach-aspeed/Kconfig
>  create mode 100644 arch/arm/mach-aspeed/Makefile
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 714dd8b514..135c544335 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -882,8 +882,15 @@ config TARGET_THUNDERX_88XX
>         select OF_CONTROL
>         select SYS_CACHE_SHIFT_7
>
> +config ARCH_ASPEED
> +       bool "Support Aspeed SoCs"
> +       select OF_CONTROL
> +       select DM
> +
>  endchoice
>
> +source "arch/arm/mach-aspeed/Kconfig"
> +
>  source "arch/arm/mach-at91/Kconfig"
>
>  source "arch/arm/mach-bcm283x/Kconfig"
> diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> index 236debb452..cc73e1038e 100644
> --- a/arch/arm/Makefile
> +++ b/arch/arm/Makefile
> @@ -50,6 +50,7 @@ PLATFORM_CPPFLAGS += $(arch-y) $(tune-y)
>
>  # Machine directory name.  This list is sorted alphanumerically
>  # by CONFIG_* macro name.
> +machine-$(CONFIG_ARCH_ASPEED)          += aspeed
>  machine-$(CONFIG_ARCH_AT91)            += at91
>  machine-$(CONFIG_ARCH_BCM283X)         += bcm283x
>  machine-$(CONFIG_ARCH_DAVINCI)         += davinci
> diff --git a/arch/arm/mach-aspeed/Kconfig b/arch/arm/mach-aspeed/Kconfig
> new file mode 100644
> index 0000000000..43cdbeda84
> --- /dev/null
> +++ b/arch/arm/mach-aspeed/Kconfig
> @@ -0,0 +1,15 @@
> +if ARCH_ASPEED
> +
> +config SYS_ARCH
> +       default "arm"
> +
> +config SYS_SOC
> +       default "aspeed"
> +
> +config ASPEED_AST2500
> +       bool "Support Aspeed AST2500 SoC"
> +       select CPU_ARM1176
> +       help
> +         The Aspeed AST2500 is a ARM-based SoC with arm1176 CPU
> +
> +endif
> diff --git a/arch/arm/mach-aspeed/Makefile b/arch/arm/mach-aspeed/Makefile
> new file mode 100644
> index 0000000000..8e276b4a9f
> --- /dev/null
> +++ b/arch/arm/mach-aspeed/Makefile
> @@ -0,0 +1,8 @@
> +#
> +# Copyright (c) 2014 Google, Inc
> +#
> +# SPDX-License-Identifier:     GPL-2.0+
> +#
> +
> +obj-$(CONFIG_ARCH_ASPEED) += ast_wdt.o
> +obj-$(CONFIG_ASPEED_AST2500) += ast2500/ ast2500-board.o
>

These files don't exist yet.


> --
> 2.11.0.390.gc69c2f50cf-goog
Tom Rini Jan. 4, 2017, 8:23 p.m. UTC | #2 
On Wed, Jan 04, 2017 at 11:58:17AM -0800, Rick Altherr wrote:
> On Wed, Jan 4, 2017 at 11:46 AM, Maxim Sloyko <maxims@google.com> wrote:
> 
> > Signed-off-by: Maxim Sloyko <maxims@google.com>
> > ---
> >
> >  arch/arm/Kconfig              |  7 +++++++
> >  arch/arm/Makefile             |  1 +
> >  arch/arm/mach-aspeed/Kconfig  | 15 +++++++++++++++
> >  arch/arm/mach-aspeed/Makefile |  8 ++++++++
> >  4 files changed, 31 insertions(+)
> >  create mode 100644 arch/arm/mach-aspeed/Kconfig
> >  create mode 100644 arch/arm/mach-aspeed/Makefile
> >
> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > index 714dd8b514..135c544335 100644
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -882,8 +882,15 @@ config TARGET_THUNDERX_88XX
> >         select OF_CONTROL
> >         select SYS_CACHE_SHIFT_7
> >
> > +config ARCH_ASPEED
> > +       bool "Support Aspeed SoCs"
> > +       select OF_CONTROL
> > +       select DM
> > +
> >  endchoice
> >
> > +source "arch/arm/mach-aspeed/Kconfig"
> > +
> >  source "arch/arm/mach-at91/Kconfig"
> >
> >  source "arch/arm/mach-bcm283x/Kconfig"
> > diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> > index 236debb452..cc73e1038e 100644
> > --- a/arch/arm/Makefile
> > +++ b/arch/arm/Makefile
> > @@ -50,6 +50,7 @@ PLATFORM_CPPFLAGS += $(arch-y) $(tune-y)
> >
> >  # Machine directory name.  This list is sorted alphanumerically
> >  # by CONFIG_* macro name.
> > +machine-$(CONFIG_ARCH_ASPEED)          += aspeed
> >  machine-$(CONFIG_ARCH_AT91)            += at91
> >  machine-$(CONFIG_ARCH_BCM283X)         += bcm283x
> >  machine-$(CONFIG_ARCH_DAVINCI)         += davinci
> > diff --git a/arch/arm/mach-aspeed/Kconfig b/arch/arm/mach-aspeed/Kconfig
> > new file mode 100644
> > index 0000000000..43cdbeda84
> > --- /dev/null
> > +++ b/arch/arm/mach-aspeed/Kconfig
> > @@ -0,0 +1,15 @@
> > +if ARCH_ASPEED
> > +
> > +config SYS_ARCH
> > +       default "arm"
> > +
> > +config SYS_SOC
> > +       default "aspeed"
> > +
> > +config ASPEED_AST2500
> > +       bool "Support Aspeed AST2500 SoC"
> > +       select CPU_ARM1176
> > +       help
> > +         The Aspeed AST2500 is a ARM-based SoC with arm1176 CPU
> > +
> > +endif
> > diff --git a/arch/arm/mach-aspeed/Makefile b/arch/arm/mach-aspeed/Makefile
> > new file mode 100644
> > index 0000000000..8e276b4a9f
> > --- /dev/null
> > +++ b/arch/arm/mach-aspeed/Makefile
> > @@ -0,0 +1,8 @@
> > +#
> > +# Copyright (c) 2014 Google, Inc
> > +#
> > +# SPDX-License-Identifier:     GPL-2.0+
> > +#
> > +
> > +obj-$(CONFIG_ARCH_ASPEED) += ast_wdt.o
> > +obj-$(CONFIG_ASPEED_AST2500) += ast2500/ ast2500-board.o
> >
> 
> These files don't exist yet.

Indeed.  The basic answer here is that the series should probably be 4-5
patches long.  I'll reply to 0/12 about my suggestion there, thanks!
Simon Glass Jan. 14, 2017, 5:13 p.m. UTC | #3 
Hi Maxim,

On 4 January 2017 at 12:46, Maxim Sloyko <maxims@google.com> wrote:
> Signed-off-by: Maxim Sloyko <maxims@google.com>
> ---
>
>  arch/arm/Kconfig              |  7 +++++++
>  arch/arm/Makefile             |  1 +
>  arch/arm/mach-aspeed/Kconfig  | 15 +++++++++++++++
>  arch/arm/mach-aspeed/Makefile |  8 ++++++++
>  4 files changed, 31 insertions(+)
>  create mode 100644 arch/arm/mach-aspeed/Kconfig
>  create mode 100644 arch/arm/mach-aspeed/Makefile
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 714dd8b514..135c544335 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -882,8 +882,15 @@ config TARGET_THUNDERX_88XX
>         select OF_CONTROL
>         select SYS_CACHE_SHIFT_7
>
> +config ARCH_ASPEED
> +       bool "Support Aspeed SoCs"
> +       select OF_CONTROL
> +       select DM
> +
>  endchoice
>
> +source "arch/arm/mach-aspeed/Kconfig"
> +
>  source "arch/arm/mach-at91/Kconfig"
>
>  source "arch/arm/mach-bcm283x/Kconfig"
> diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> index 236debb452..cc73e1038e 100644
> --- a/arch/arm/Makefile
> +++ b/arch/arm/Makefile
> @@ -50,6 +50,7 @@ PLATFORM_CPPFLAGS += $(arch-y) $(tune-y)
>
>  # Machine directory name.  This list is sorted alphanumerically
>  # by CONFIG_* macro name.
> +machine-$(CONFIG_ARCH_ASPEED)          += aspeed
>  machine-$(CONFIG_ARCH_AT91)            += at91
>  machine-$(CONFIG_ARCH_BCM283X)         += bcm283x
>  machine-$(CONFIG_ARCH_DAVINCI)         += davinci
> diff --git a/arch/arm/mach-aspeed/Kconfig b/arch/arm/mach-aspeed/Kconfig
> new file mode 100644
> index 0000000000..43cdbeda84
> --- /dev/null
> +++ b/arch/arm/mach-aspeed/Kconfig
> @@ -0,0 +1,15 @@
> +if ARCH_ASPEED
> +
> +config SYS_ARCH
> +       default "arm"
> +
> +config SYS_SOC
> +       default "aspeed"
> +
> +config ASPEED_AST2500
> +       bool "Support Aspeed AST2500 SoC"
> +       select CPU_ARM1176
> +       help
> +         The Aspeed AST2500 is a ARM-based SoC with arm1176 CPU

Can you please expand this a bit? E.g. a summary of peripherals it
has, what the chip is used for...

> +
> +endif
> diff --git a/arch/arm/mach-aspeed/Makefile b/arch/arm/mach-aspeed/Makefile
> new file mode 100644
> index 0000000000..8e276b4a9f
> --- /dev/null
> +++ b/arch/arm/mach-aspeed/Makefile
> @@ -0,0 +1,8 @@
> +#
> +# Copyright (c) 2014 Google, Inc
> +#
> +# SPDX-License-Identifier:     GPL-2.0+
> +#
> +
> +obj-$(CONFIG_ARCH_ASPEED) += ast_wdt.o
> +obj-$(CONFIG_ASPEED_AST2500) += ast2500/ ast2500-board.o
> --
> 2.11.0.390.gc69c2f50cf-goog
>

Regards,
Simon
Maxim Sloyko Jan. 18, 2017, 12:15 a.m. UTC | #4 
On Sat, Jan 14, 2017 at 9:13 AM, Simon Glass <sjg@chromium.org> wrote:

> Hi Maxim,
>
> On 4 January 2017 at 12:46, Maxim Sloyko <maxims@google.com> wrote:
> > Signed-off-by: Maxim Sloyko <maxims@google.com>
> > ---
> >
> >  arch/arm/Kconfig              |  7 +++++++
> >  arch/arm/Makefile             |  1 +
> >  arch/arm/mach-aspeed/Kconfig  | 15 +++++++++++++++
> >  arch/arm/mach-aspeed/Makefile |  8 ++++++++
> >  4 files changed, 31 insertions(+)
> >  create mode 100644 arch/arm/mach-aspeed/Kconfig
> >  create mode 100644 arch/arm/mach-aspeed/Makefile
> >
> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > index 714dd8b514..135c544335 100644
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -882,8 +882,15 @@ config TARGET_THUNDERX_88XX
> >         select OF_CONTROL
> >         select SYS_CACHE_SHIFT_7
> >
> > +config ARCH_ASPEED
> > +       bool "Support Aspeed SoCs"
> > +       select OF_CONTROL
> > +       select DM
> > +
> >  endchoice
> >
> > +source "arch/arm/mach-aspeed/Kconfig"
> > +
> >  source "arch/arm/mach-at91/Kconfig"
> >
> >  source "arch/arm/mach-bcm283x/Kconfig"
> > diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> > index 236debb452..cc73e1038e 100644
> > --- a/arch/arm/Makefile
> > +++ b/arch/arm/Makefile
> > @@ -50,6 +50,7 @@ PLATFORM_CPPFLAGS += $(arch-y) $(tune-y)
> >
> >  # Machine directory name.  This list is sorted alphanumerically
> >  # by CONFIG_* macro name.
> > +machine-$(CONFIG_ARCH_ASPEED)          += aspeed
> >  machine-$(CONFIG_ARCH_AT91)            += at91
> >  machine-$(CONFIG_ARCH_BCM283X)         += bcm283x
> >  machine-$(CONFIG_ARCH_DAVINCI)         += davinci
> > diff --git a/arch/arm/mach-aspeed/Kconfig b/arch/arm/mach-aspeed/Kconfig
> > new file mode 100644
> > index 0000000000..43cdbeda84
> > --- /dev/null
> > +++ b/arch/arm/mach-aspeed/Kconfig
> > @@ -0,0 +1,15 @@
> > +if ARCH_ASPEED
> > +
> > +config SYS_ARCH
> > +       default "arm"
> > +
> > +config SYS_SOC
> > +       default "aspeed"
> > +
> > +config ASPEED_AST2500
> > +       bool "Support Aspeed AST2500 SoC"
> > +       select CPU_ARM1176
> > +       help
> > +         The Aspeed AST2500 is a ARM-based SoC with arm1176 CPU
>
> Can you please expand this a bit? E.g. a summary of peripherals it
> has, what the chip is used for...
>

With 47 different types of peripherals it has, that would be a pretty big
summary :)
I expanded it to say that this is a BMC.


> > +
> > +endif
> > diff --git a/arch/arm/mach-aspeed/Makefile b/arch/arm/mach-aspeed/
> Makefile
> > new file mode 100644
> > index 0000000000..8e276b4a9f
> > --- /dev/null
> > +++ b/arch/arm/mach-aspeed/Makefile
> > @@ -0,0 +1,8 @@
> > +#
> > +# Copyright (c) 2014 Google, Inc
> > +#
> > +# SPDX-License-Identifier:     GPL-2.0+
> > +#
> > +
> > +obj-$(CONFIG_ARCH_ASPEED) += ast_wdt.o
> > +obj-$(CONFIG_ASPEED_AST2500) += ast2500/ ast2500-board.o
> > --
> > 2.11.0.390.gc69c2f50cf-goog
> >
>
> Regards,
> Simon
>
diff mbox

Patch

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 714dd8b514..135c544335 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -882,8 +882,15 @@  config TARGET_THUNDERX_88XX
 	select OF_CONTROL
 	select SYS_CACHE_SHIFT_7
 
+config ARCH_ASPEED
+	bool "Support Aspeed SoCs"
+	select OF_CONTROL
+	select DM
+
 endchoice
 
+source "arch/arm/mach-aspeed/Kconfig"
+
 source "arch/arm/mach-at91/Kconfig"
 
 source "arch/arm/mach-bcm283x/Kconfig"
diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index 236debb452..cc73e1038e 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -50,6 +50,7 @@  PLATFORM_CPPFLAGS += $(arch-y) $(tune-y)
 
 # Machine directory name.  This list is sorted alphanumerically
 # by CONFIG_* macro name.
+machine-$(CONFIG_ARCH_ASPEED)		+= aspeed
 machine-$(CONFIG_ARCH_AT91)		+= at91
 machine-$(CONFIG_ARCH_BCM283X)		+= bcm283x
 machine-$(CONFIG_ARCH_DAVINCI)		+= davinci
diff --git a/arch/arm/mach-aspeed/Kconfig b/arch/arm/mach-aspeed/Kconfig
new file mode 100644
index 0000000000..43cdbeda84
--- /dev/null
+++ b/arch/arm/mach-aspeed/Kconfig
@@ -0,0 +1,15 @@ 
+if ARCH_ASPEED
+
+config SYS_ARCH
+	default "arm"
+
+config SYS_SOC
+	default "aspeed"
+
+config ASPEED_AST2500
+	bool "Support Aspeed AST2500 SoC"
+	select CPU_ARM1176
+	help
+	  The Aspeed AST2500 is a ARM-based SoC with arm1176 CPU
+
+endif
diff --git a/arch/arm/mach-aspeed/Makefile b/arch/arm/mach-aspeed/Makefile
new file mode 100644
index 0000000000..8e276b4a9f
--- /dev/null
+++ b/arch/arm/mach-aspeed/Makefile
@@ -0,0 +1,8 @@ 
+#
+# Copyright (c) 2014 Google, Inc
+#
+# SPDX-License-Identifier:	GPL-2.0+
+#
+
+obj-$(CONFIG_ARCH_ASPEED) += ast_wdt.o
+obj-$(CONFIG_ASPEED_AST2500) += ast2500/ ast2500-board.o