diff mbox

[U-Boot,4/4] colibri_t20: fix ulpi reset polarity

Message ID 20161219143807.5479-5-marcel@ziswiler.com
State Accepted
Commit 3f33bd299fd438a04d37c3c25af1ab02a9b0d2f9
Delegated to: Tom Warren
Headers show

Commit Message

Marcel Ziswiler Dec. 19, 2016, 2:38 p.m. UTC 
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>

Fix ULPI reset polarity which caused a hard hang on Colibri T20 upon
attempting to start the USB subsystem:

This fixes my late commit d5a24d8b53d350364bd429b7104ec369b817e4b8
(colibri_t20: fix usb operation and controller order) inadvertently
having overwritten Stephen's previous commit
2f6a7e8ce5df8b99d84bfd486c6f99d92322ce04 (ARM: tegra: fix USB ULPI PHY
reset signal inversion confusion).

While at it also fix comment about on-module USB port.

Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

---

 arch/arm/dts/tegra20-colibri.dts | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Simon Glass Dec. 26, 2016, 5:23 a.m. UTC | #1 
On 20 December 2016 at 03:38, Marcel Ziswiler <marcel@ziswiler.com> wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> Fix ULPI reset polarity which caused a hard hang on Colibri T20 upon
> attempting to start the USB subsystem:
>
> This fixes my late commit d5a24d8b53d350364bd429b7104ec369b817e4b8
> (colibri_t20: fix usb operation and controller order) inadvertently
> having overwritten Stephen's previous commit
> 2f6a7e8ce5df8b99d84bfd486c6f99d92322ce04 (ARM: tegra: fix USB ULPI PHY
> reset signal inversion confusion).
>
> While at it also fix comment about on-module USB port.
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> ---
>
>  arch/arm/dts/tegra20-colibri.dts | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
diff mbox

Patch

diff --git a/arch/arm/dts/tegra20-colibri.dts b/arch/arm/dts/tegra20-colibri.dts
index 89adfb6..3c10dd6 100644
--- a/arch/arm/dts/tegra20-colibri.dts
+++ b/arch/arm/dts/tegra20-colibri.dts
@@ -16,7 +16,7 @@ 
 		i2c2 = "/i2c@7000c400";
 		mmc0 = "/sdhci@c8000600";
 		usb0 = "/usb@c5000000";
-		usb1 = "/usb@c5004000"; /* on-module only, for ASIX */
+		usb1 = "/usb@c5004000"; /* On-module only, for ASIX */
 		usb2 = "/usb@c5008000";
 	};
 
@@ -92,8 +92,10 @@ 
 	/* EHCI instance 1: ULPI -> USB3340 -> AX88772B */
 	usb@c5004000 {
 		status = "okay";
+		/* ULPI_RESET */
+		nvidia,phy-reset-gpio =
+				<&gpio TEGRA_GPIO(V, 1) GPIO_ACTIVE_LOW>;
 		/* VBUS_LAN */
-		nvidia,phy-reset-gpio = <&gpio TEGRA_GPIO(V, 1) GPIO_ACTIVE_HIGH>;
 		nvidia,vbus-gpio = <&gpio TEGRA_GPIO(BB, 1) GPIO_ACTIVE_HIGH>;
 	};