| Message ID | 20161127221536.9577-8-vz@mleia.com |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
On Mon, Nov 28, 2016 at 12:15:19AM +0200, Vladimir Zapolskiy wrote: > The change actually maps PCI I/O window to the same address on PCI bus > as it is stated by a comment, before the change transfers to the PCI I/O > space are failed due to misconfiguration of the most significant 14 bits > of the PCI address in PCIIOBR (note that it is set to 0x0). > > Most probably the problem remained unnoticed, because communcation > to all tested PCI devices is done over PCI memory space only. > > Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> Applied to u-boot/master, thanks!
diff --git a/drivers/pci/pci_sh7751.c b/drivers/pci/pci_sh7751.c index f189ed8..420ae81 100644 --- a/drivers/pci/pci_sh7751.c +++ b/drivers/pci/pci_sh7751.c @@ -164,7 +164,7 @@ int pci_sh7751_init(struct pci_controller *hose) p4_out(SH7751_PCI_MEM_BASE, SH7751_PCIMBR); /* Map IO window to same address on PCI bus */ - p4_out(0x2000 & 0xfffc0000, SH7751_PCIIOBR); + p4_out(SH7751_PCI_IO_BASE, SH7751_PCIIOBR); /* set BREQEN */ p4_out(inl(SH7751_BCR1) | 0x00080000, SH7751_BCR1);
The change actually maps PCI I/O window to the same address on PCI bus as it is stated by a comment, before the change transfers to the PCI I/O space are failed due to misconfiguration of the most significant 14 bits of the PCI address in PCIIOBR (note that it is set to 0x0). Most probably the problem remained unnoticed, because communcation to all tested PCI devices is done over PCI memory space only. Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> --- drivers/pci/pci_sh7751.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)