Message ID | 20110103165146.395B0CEF7A6@gemini.denx.de |
---|---|
State | Accepted |
Commit | de47cbe6860654cc6c0cf8820d9165f059c7cf38 |
Headers | show |
On Mon, Jan 03, 2011, Wolfgang Denk wrote:
> Um... I do not like this change; the resulting code is harder to read.
I don't mind either way; I had asked
<20101220111358.GA28532@bee.dooz.org> which one was the preferred
approach, but didn't get comments on this particular point; see
<20110103170050.GB10571@bee.dooz.org> for the rationale for picking
this option rather than the other one.
I've sent a second patch to also define struct global_data; feel free
to cherry pick any of the two patches or both
Thanks!
diff --git a/arch/i386/include/asm/global_data.h b/arch/i386/include/asm/global_data.h index e3f8a25..e9000c3 100644 --- a/arch/i386/include/asm/global_data.h +++ b/arch/i386/include/asm/global_data.h @@ -35,7 +35,7 @@ #ifndef __ASSEMBLY__ -typedef struct { +typedef struct global_data { bd_t *bd; unsigned long flags; unsigned long baudrate;