diff mbox

[U-Boot] tools: imximage: Fix the maximum DCD size for mx53/mx6

Message ID 1ea38d8bd17447239c0a41b4ad3b51dc@BLUPR03MB358.namprd03.prod.outlook.com
State Not Applicable
Delegated to: Stefano Babic
Headers show

Commit Message

Nitin Garg Sept. 1, 2014, 1:35 p.m. UTC 
Acked!

Regards,
Nitin Garg


-----Original Message-----
From: Fabio Estevam [mailto:fabio.estevam@freescale.com] 
Sent: Monday, September 01, 2014 7:56 AM
To: sbabic@denx.de
Cc: u-boot@lists.denx.de; jonas.d.karlsson@gmail.com; Li Ye-B37916; Garg Nitin-B37173; Estevam Fabio-R49496
Subject: [PATCH] tools: imximage: Fix the maximum DCD size for mx53/mx6

According to mx53 and mx6 reference manuals:

"The maximum size of the DCD limited to 1768 bytes."

As each DCD entry consists of 8 bytes, we have a total of 1768 / 8 = 221, and excluding the first entry, which is the header leads to 220 as the maximum number for DCD size.

Reported-by: Jonas Karlsson <jonas.d.karlsson@gmail.com>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 tools/imximage.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
1.9.1

Comments

Tom Rini Sept. 2, 2014, 2:15 p.m. UTC | #1 
On Mon, Sep 01, 2014 at 01:35:22PM +0000, Nitin Garg wrote:

> Acked!

Please note that patchwork won't pick that up, only a properly
formatted acked-by line, thanks!

> 
> Regards,
> Nitin Garg
> 
> 
> -----Original Message-----
> From: Fabio Estevam [mailto:fabio.estevam@freescale.com] 
> Sent: Monday, September 01, 2014 7:56 AM
> To: sbabic@denx.de
> Cc: u-boot@lists.denx.de; jonas.d.karlsson@gmail.com; Li Ye-B37916; Garg Nitin-B37173; Estevam Fabio-R49496
> Subject: [PATCH] tools: imximage: Fix the maximum DCD size for mx53/mx6
> 
> According to mx53 and mx6 reference manuals:
> 
> "The maximum size of the DCD limited to 1768 bytes."
> 
> As each DCD entry consists of 8 bytes, we have a total of 1768 / 8 = 221, and excluding the first entry, which is the header leads to 220 as the maximum number for DCD size.
> 
> Reported-by: Jonas Karlsson <jonas.d.karlsson@gmail.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  tools/imximage.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/imximage.h b/tools/imximage.h index 01f861e..5b5ad0e 100644
> --- a/tools/imximage.h
> +++ b/tools/imximage.h
> @@ -8,7 +8,7 @@
>  #ifndef _IMXIMAGE_H_
>  #define _IMXIMAGE_H_
>  
> -#define MAX_HW_CFG_SIZE_V2 121 /* Max number of registers imx can set for v2 */
> +#define MAX_HW_CFG_SIZE_V2 220 /* Max number of registers imx can set 
> +for v2 */
>  #define MAX_HW_CFG_SIZE_V1 60  /* Max number of registers imx can set for v1 */
>  #define APP_CODE_BARKER	0xB1
>  #define DCD_BARKER	0xB17219E9
> --
> 1.9.1
> 
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
diff mbox

Patch

diff --git a/tools/imximage.h b/tools/imximage.h index 01f861e..5b5ad0e 100644
--- a/tools/imximage.h
+++ b/tools/imximage.h
@@ -8,7 +8,7 @@ 
 #ifndef _IMXIMAGE_H_
 #define _IMXIMAGE_H_
 
-#define MAX_HW_CFG_SIZE_V2 121 /* Max number of registers imx can set for v2 */
+#define MAX_HW_CFG_SIZE_V2 220 /* Max number of registers imx can set 
+for v2 */
 #define MAX_HW_CFG_SIZE_V1 60  /* Max number of registers imx can set for v1 */
 #define APP_CODE_BARKER	0xB1
 #define DCD_BARKER	0xB17219E9