| Message ID | 1891241140.2278407.1344615826764.JavaMail.root@advansee.com |
|---|---|
| State | Rejected |
| Delegated to: | Marek Vasut |
| Headers | show |
Hi Benoit, On Fri, Aug 10, 2012 at 8:23 PM, Benoît Thébaudeau < benoit.thebaudeau@advansee.com> wrote: > Adjust time-out value for the new EHCI mechanism. > Could you please be a bit more specific? ;) How this timeout is related to the new mechanism? Is it really EHCI specific? If it is, that's hardcoding of lower layer details again, I think that's undesirable... But generally this series looks really good. Thanks a lot! Regards, Ilya.
Hi Ilya, On Fri, Aug 10, 2012 at 8:03:12 PM, Ilya Yanok wrote: > Hi Benoit, > On Fri, Aug 10, 2012 at 8:23 PM, Benoît Thébaudeau < > benoit.thebaudeau@advansee.com > wrote: > > Adjust time-out value for the new EHCI mechanism. > > Could you please be a bit more specific? ;) > How this timeout is related to the new mechanism? Is it really EHCI > specific? If it is, that's hardcoding of lower layer details again, > I think that's undesirable... Well, I did this specific patch a very long time ago, and I don't remember the details. I know that things did not work without it in my test conditions at that time. I've just run again all my tests with the current code on all my platforms without this patch, and everything works fine. So it was perhaps a device-related issue rather than an EHCI-related one. Since the rationale for this patch is no longer clear and things work fine without it, we can probably drop it. I let you and Marek decide. > But generally this series looks really good. Thanks a lot! Great. You're welcome. Best regards, Benoît
diff --git u-boot-usb-4f8254e.orig/common/usb_storage.c u-boot-usb-4f8254e/common/usb_storage.c index 822bd64..f0798b2 100644 --- u-boot-usb-4f8254e.orig/common/usb_storage.c +++ u-boot-usb-4f8254e/common/usb_storage.c @@ -712,7 +712,7 @@ int usb_stor_BBB_transport(ccb *srb, struct us_data *us) else pipe = pipeout; result = usb_bulk_msg(us->pusb_dev, pipe, srb->pdata, srb->datalen, - &data_actlen, USB_CNTL_TIMEOUT * 5); + &data_actlen, USB_CNTL_TIMEOUT * 100); /* special handling of STALL in DATA phase */ if ((result < 0) && (us->pusb_dev->status & USB_ST_STALLED)) { USB_STOR_PRINTF("DATA:stall\n");
Adjust time-out value for the new EHCI mechanism. Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau@advansee.com> Cc: Marek Vasut <marex@denx.de> Cc: Ilya Yanok <ilya.yanok@cogentembedded.com> Cc: Stefan Herbrechtsmeier <stefan@herbrechtsmeier.net> --- Changes for v2: None. Changes for v3: None. Changes for v4: None. .../common/usb_storage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)