| Message ID | 1546537660-9234-1-git-send-email-philipp.tomsich@theobroma-systems.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | [U-Boot] Kconfig: don't pollute Kconfig w/ i.MX8M options for everyone | expand |
On Thu, Jan 03, 2019 at 06:47:40PM +0100, Philipp Tomsich wrote: > No point in showing the various DRAM options (right in the top-level > menu for 'Device Drivers') for i.MX8M when configured for a different > architecture. This wraps an 'if ARCH_IMX8M' around these. > > Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > --- > > drivers/ddr/imx/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/ddr/imx/Kconfig b/drivers/ddr/imx/Kconfig > index 7e06fb2..09a35e5 100644 > --- a/drivers/ddr/imx/Kconfig > +++ b/drivers/ddr/imx/Kconfig > @@ -1 +1,3 @@ > +if ARCH_IMX8M > source "drivers/ddr/imx/imx8m/Kconfig" > +endif Ugh. We need drivers/ddr/imx/imx8m/Kconfig to have real 'depends on' lines like all of the other DDR controllers.
> On 03.01.2019, at 21:21, Tom Rini <trini@konsulko.com> wrote: > > On Thu, Jan 03, 2019 at 06:47:40PM +0100, Philipp Tomsich wrote: > >> No point in showing the various DRAM options (right in the top-level >> menu for 'Device Drivers') for i.MX8M when configured for a different >> architecture. This wraps an 'if ARCH_IMX8M' around these. >> >> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> >> --- >> >> drivers/ddr/imx/Kconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/ddr/imx/Kconfig b/drivers/ddr/imx/Kconfig >> index 7e06fb2..09a35e5 100644 >> --- a/drivers/ddr/imx/Kconfig >> +++ b/drivers/ddr/imx/Kconfig >> @@ -1 +1,3 @@ >> +if ARCH_IMX8M >> source "drivers/ddr/imx/imx8m/Kconfig" >> +endif > > Ugh. We need drivers/ddr/imx/imx8m/Kconfig to have real 'depends on' > lines like all of the other DDR controllers. Unfortunately, there’s more without meaningful 'depends on’: STM32_SDRAM and MPC83XX_SDRAM also caught my eye today (I went into menuconfig for the first time in a long time)—they just didn’t bother me as much as this one ;-) If I remember to do so, I’ll submit patches for those two as well ... Cheers, Phil.
> -----Original Message----- > From: Philipp Tomsich [mailto:philipp.tomsich@theobroma-systems.com] > Sent: 2019年1月4日 1:48 > To: u-boot@lists.denx.de > Cc: Tom Rini <trini@konsulko.com>; Philipp Tomsich > <philipp.tomsich@theobroma-systems.com>; Peng Fan <peng.fan@nxp.com>; > Masahiro Yamada <yamada.masahiro@socionext.com> > Subject: [PATCH] Kconfig: don't pollute Kconfig w/ i.MX8M options for > everyone > > No point in showing the various DRAM options (right in the top-level menu for > 'Device Drivers') for i.MX8M when configured for a different architecture. > This wraps an 'if ARCH_IMX8M' around these. > > Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > --- > > drivers/ddr/imx/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/ddr/imx/Kconfig b/drivers/ddr/imx/Kconfig index > 7e06fb2..09a35e5 100644 > --- a/drivers/ddr/imx/Kconfig > +++ b/drivers/ddr/imx/Kconfig > @@ -1 +1,3 @@ > +if ARCH_IMX8M > source "drivers/ddr/imx/imx8m/Kconfig" > +endif Thanks. Reviewed-by: Peng Fan <peng.fan@nxp.com> > -- > 2.1.4
Hi Philipp, On 04/01/19 01:18, Philipp Tomsich wrote: > > >> On 03.01.2019, at 21:21, Tom Rini <trini@konsulko.com >> <mailto:trini@konsulko.com>> wrote: >> >> On Thu, Jan 03, 2019 at 06:47:40PM +0100, Philipp Tomsich wrote: >> >>> No point in showing the various DRAM options (right in the top-level >>> menu for 'Device Drivers') for i.MX8M when configured for a different >>> architecture. This wraps an 'if ARCH_IMX8M' around these. >>> >>> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com >>> <mailto:philipp.tomsich@theobroma-systems.com>> >>> --- >>> >>> drivers/ddr/imx/Kconfig | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/ddr/imx/Kconfig b/drivers/ddr/imx/Kconfig >>> index 7e06fb2..09a35e5 100644 >>> --- a/drivers/ddr/imx/Kconfig >>> +++ b/drivers/ddr/imx/Kconfig >>> @@ -1 +1,3 @@ >>> +if ARCH_IMX8M >>> source "drivers/ddr/imx/imx8m/Kconfig" >>> +endif >> >> Ugh. We need drivers/ddr/imx/imx8m/Kconfig to have real 'depends on' >> lines like all of the other DDR controllers. > > Unfortunately, there’s more without meaningful 'depends on’: STM32_SDRAM and > MPC83XX_SDRAM also caught my eye today (I went into menuconfig for the first > time in a long time)—they just didn’t bother me as much as this one ;-) > > If I remember to do so, I’ll submit patches for those two as well ... > Nevertheless, and I agree your patch is working, too, the common way in Kconfig is to add suitable "depends on" as suggested by Tom and as we have on other DDR drivers instead of a global #if ARCH_IMX8m (I agree that for an user does not change a lot, by the way). Best regards, Stefano
diff --git a/drivers/ddr/imx/Kconfig b/drivers/ddr/imx/Kconfig index 7e06fb2..09a35e5 100644 --- a/drivers/ddr/imx/Kconfig +++ b/drivers/ddr/imx/Kconfig @@ -1 +1,3 @@ +if ARCH_IMX8M source "drivers/ddr/imx/imx8m/Kconfig" +endif
No point in showing the various DRAM options (right in the top-level menu for 'Device Drivers') for i.MX8M when configured for a different architecture. This wraps an 'if ARCH_IMX8M' around these. Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> --- drivers/ddr/imx/Kconfig | 2 ++ 1 file changed, 2 insertions(+)