| Message ID | 1545123245-77250-5-git-send-email-chee.hong.ang@intel.com |
|---|---|
| State | Superseded |
| Delegated to: | Marek Vasut |
| Headers | show |
| Series | Stratix10 FPGA reconfiguration support | expand |
On 12/18/2018 09:54 AM, chee.hong.ang@intel.com wrote: > From: "Ang, Chee Hong" <chee.hong.ang@intel.com> > > Enable Stratix10 FPGA reconfiguration support in defconfig. > > Signed-off-by: Ang, Chee Hong <chee.hong.ang@intel.com> > --- > configs/socfpga_stratix10_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configs/socfpga_stratix10_defconfig b/configs/socfpga_stratix10_defconfig > index 5f3d733..155c406 100644 > --- a/configs/socfpga_stratix10_defconfig > +++ b/configs/socfpga_stratix10_defconfig > @@ -10,6 +10,7 @@ CONFIG_NR_DRAM_BANKS=1 > CONFIG_BOOTDELAY=5 > CONFIG_SPL_SPI_LOAD=y > CONFIG_HUSH_PARSER=y > +CONFIG_FPGA_STRATIX10=y > CONFIG_SYS_PROMPT="SOCFPGA_STRATIX10 # " > CONFIG_CMD_MEMTEST=y > # CONFIG_CMD_FLASH is not set > Can you send a subsequent patch which uses Kconfig imply to select FPGA_STRATIX10 on S10 instead of adding it in defconfig ?
On Tue, 2018-12-18 at 18:47 +0100, Marek Vasut wrote: > On 12/18/2018 09:54 AM, chee.hong.ang@intel.com wrote: > > > > From: "Ang, Chee Hong" <chee.hong.ang@intel.com> > > > > Enable Stratix10 FPGA reconfiguration support in defconfig. > > > > Signed-off-by: Ang, Chee Hong <chee.hong.ang@intel.com> > > --- > > configs/socfpga_stratix10_defconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/configs/socfpga_stratix10_defconfig > > b/configs/socfpga_stratix10_defconfig > > index 5f3d733..155c406 100644 > > --- a/configs/socfpga_stratix10_defconfig > > +++ b/configs/socfpga_stratix10_defconfig > > @@ -10,6 +10,7 @@ CONFIG_NR_DRAM_BANKS=1 > > CONFIG_BOOTDELAY=5 > > CONFIG_SPL_SPI_LOAD=y > > CONFIG_HUSH_PARSER=y > > +CONFIG_FPGA_STRATIX10=y > > CONFIG_SYS_PROMPT="SOCFPGA_STRATIX10 # " > > CONFIG_CMD_MEMTEST=y > > # CONFIG_CMD_FLASH is not set > > > Can you send a subsequent patch which uses Kconfig imply to select > FPGA_STRATIX10 on S10 instead of adding it in defconfig ? Noted. Will address this in next patchsets.
On 12/19/2018 05:55 AM, Ang, Chee Hong wrote: > On Tue, 2018-12-18 at 18:47 +0100, Marek Vasut wrote: >> On 12/18/2018 09:54 AM, chee.hong.ang@intel.com wrote: >>> >>> From: "Ang, Chee Hong" <chee.hong.ang@intel.com> >>> >>> Enable Stratix10 FPGA reconfiguration support in defconfig. >>> >>> Signed-off-by: Ang, Chee Hong <chee.hong.ang@intel.com> >>> --- >>> configs/socfpga_stratix10_defconfig | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/configs/socfpga_stratix10_defconfig >>> b/configs/socfpga_stratix10_defconfig >>> index 5f3d733..155c406 100644 >>> --- a/configs/socfpga_stratix10_defconfig >>> +++ b/configs/socfpga_stratix10_defconfig >>> @@ -10,6 +10,7 @@ CONFIG_NR_DRAM_BANKS=1 >>> CONFIG_BOOTDELAY=5 >>> CONFIG_SPL_SPI_LOAD=y >>> CONFIG_HUSH_PARSER=y >>> +CONFIG_FPGA_STRATIX10=y >>> CONFIG_SYS_PROMPT="SOCFPGA_STRATIX10 # " >>> CONFIG_CMD_MEMTEST=y >>> # CONFIG_CMD_FLASH is not set >>> >> Can you send a subsequent patch which uses Kconfig imply to select >> FPGA_STRATIX10 on S10 instead of adding it in defconfig ? > Noted. Will address this in next patchsets. I asked you for an incremental patch, not for reposting the whole patchset (also, please track changelog with new versions of patches). But travis would seem to indicate, again, that the patches break some other target [1]. Can you please at least build test the next version of patches on all systems before posting them ? You can very well just set up the travis CI with your github repo/fork of u-boot repo, push a branch there and wait for travis to build that branch on all supported systems and tell you what the situation is. It saves me time, which I otherwise spend on applying, rejecting and dropping of your patches after they fail to build. [1] https://travis-ci.org/marex/u-boot-socfpga/jobs/469629378#L1142
On Wed, 2018-12-19 at 09:41 +0100, Marek Vasut wrote: > On 12/19/2018 05:55 AM, Ang, Chee Hong wrote: > > > > On Tue, 2018-12-18 at 18:47 +0100, Marek Vasut wrote: > > > > > > On 12/18/2018 09:54 AM, chee.hong.ang@intel.com wrote: > > > > > > > > > > > > From: "Ang, Chee Hong" <chee.hong.ang@intel.com> > > > > > > > > Enable Stratix10 FPGA reconfiguration support in defconfig. > > > > > > > > Signed-off-by: Ang, Chee Hong <chee.hong.ang@intel.com> > > > > --- > > > > configs/socfpga_stratix10_defconfig | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/configs/socfpga_stratix10_defconfig > > > > b/configs/socfpga_stratix10_defconfig > > > > index 5f3d733..155c406 100644 > > > > --- a/configs/socfpga_stratix10_defconfig > > > > +++ b/configs/socfpga_stratix10_defconfig > > > > @@ -10,6 +10,7 @@ CONFIG_NR_DRAM_BANKS=1 > > > > CONFIG_BOOTDELAY=5 > > > > CONFIG_SPL_SPI_LOAD=y > > > > CONFIG_HUSH_PARSER=y > > > > +CONFIG_FPGA_STRATIX10=y > > > > CONFIG_SYS_PROMPT="SOCFPGA_STRATIX10 # " > > > > CONFIG_CMD_MEMTEST=y > > > > # CONFIG_CMD_FLASH is not set > > > > > > > Can you send a subsequent patch which uses Kconfig imply to > > > select > > > FPGA_STRATIX10 on S10 instead of adding it in defconfig ? > > Noted. Will address this in next patchsets. > I asked you for an incremental patch, not for reposting the whole > patchset (also, please track changelog with new versions of patches). > > But travis would seem to indicate, again, that the patches break some > other target [1]. Can you please at least build test the next version > of > patches on all systems before posting them ? > > You can very well just set up the travis CI with your github > repo/fork > of u-boot repo, push a branch there and wait for travis to build that > branch on all supported systems and tell you what the situation is. > It > saves me time, which I otherwise spend on applying, rejecting and > dropping of your patches after they fail to build. > > [1] https://travis-ci.org/marex/u-boot-socfpga/jobs/469629378#L1142 Ok. I only test the build for current (S10) target. Some of the code are not tested with other build target. I will setup the travis CI and test it on my side before submitting new patchsets. But 1 of the build error is due to your code base missing the following patch: http://u-boot.10912.n7.nabble.com/PATCH-v2-Add-generic-FPGA-reconfig-ma ilbox-API-for-S10-td343559.html#a343560 All current patch has dependency on the patch mentioned above. You will get build errors without this patch applied before current patchsets. >
On 12/19/2018 10:48 AM, Ang, Chee Hong wrote: > On Wed, 2018-12-19 at 09:41 +0100, Marek Vasut wrote: >> On 12/19/2018 05:55 AM, Ang, Chee Hong wrote: >>> >>> On Tue, 2018-12-18 at 18:47 +0100, Marek Vasut wrote: >>>> >>>> On 12/18/2018 09:54 AM, chee.hong.ang@intel.com wrote: >>>>> >>>>> >>>>> From: "Ang, Chee Hong" <chee.hong.ang@intel.com> >>>>> >>>>> Enable Stratix10 FPGA reconfiguration support in defconfig. >>>>> >>>>> Signed-off-by: Ang, Chee Hong <chee.hong.ang@intel.com> >>>>> --- >>>>> configs/socfpga_stratix10_defconfig | 1 + >>>>> 1 file changed, 1 insertion(+) >>>>> >>>>> diff --git a/configs/socfpga_stratix10_defconfig >>>>> b/configs/socfpga_stratix10_defconfig >>>>> index 5f3d733..155c406 100644 >>>>> --- a/configs/socfpga_stratix10_defconfig >>>>> +++ b/configs/socfpga_stratix10_defconfig >>>>> @@ -10,6 +10,7 @@ CONFIG_NR_DRAM_BANKS=1 >>>>> CONFIG_BOOTDELAY=5 >>>>> CONFIG_SPL_SPI_LOAD=y >>>>> CONFIG_HUSH_PARSER=y >>>>> +CONFIG_FPGA_STRATIX10=y >>>>> CONFIG_SYS_PROMPT="SOCFPGA_STRATIX10 # " >>>>> CONFIG_CMD_MEMTEST=y >>>>> # CONFIG_CMD_FLASH is not set >>>>> >>>> Can you send a subsequent patch which uses Kconfig imply to >>>> select >>>> FPGA_STRATIX10 on S10 instead of adding it in defconfig ? >>> Noted. Will address this in next patchsets. >> I asked you for an incremental patch, not for reposting the whole >> patchset (also, please track changelog with new versions of patches). >> >> But travis would seem to indicate, again, that the patches break some >> other target [1]. Can you please at least build test the next version >> of >> patches on all systems before posting them ? >> >> You can very well just set up the travis CI with your github >> repo/fork >> of u-boot repo, push a branch there and wait for travis to build that >> branch on all supported systems and tell you what the situation is. >> It >> saves me time, which I otherwise spend on applying, rejecting and >> dropping of your patches after they fail to build. >> >> [1] https://travis-ci.org/marex/u-boot-socfpga/jobs/469629378#L1142 > > Ok. I only test the build for current (S10) target. Some of the code > are not tested with other build target. I will setup the travis CI and > test it on my side before submitting new patchsets. > But 1 of the build error is due to your code base missing the following > patch: > http://u-boot.10912.n7.nabble.com/PATCH-v2-Add-generic-FPGA-reconfig-ma > ilbox-API-for-S10-td343559.html#a343560 > All current patch has dependency on the patch mentioned above. > You will get build errors without this patch applied before current > patchsets. Then please submit the complete series, the dependency is not mentioned anywhere. And yes, please do keep testing.
diff --git a/configs/socfpga_stratix10_defconfig b/configs/socfpga_stratix10_defconfig index 5f3d733..155c406 100644 --- a/configs/socfpga_stratix10_defconfig +++ b/configs/socfpga_stratix10_defconfig @@ -10,6 +10,7 @@ CONFIG_NR_DRAM_BANKS=1 CONFIG_BOOTDELAY=5 CONFIG_SPL_SPI_LOAD=y CONFIG_HUSH_PARSER=y +CONFIG_FPGA_STRATIX10=y CONFIG_SYS_PROMPT="SOCFPGA_STRATIX10 # " CONFIG_CMD_MEMTEST=y # CONFIG_CMD_FLASH is not set