diff mbox series

[U-Boot,3/4] configs: wb45n_defconfig: Remove SPL

Message ID 1542615470-17992-4-git-send-email-eugen.hristev@microchip.com
State Changes Requested
Delegated to: Tom Rini
Headers show
Series at91: SPL size check for at91 boards | expand

Commit Message

Eugen Hristev Nov. 19, 2018, 8:23 a.m. UTC 
Due the size of SPL being too big, remove the SPL support.
---8<---
arm-linux-gnueabi-ld: SPL image too big
--->8---

Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
---
 configs/wb45n_defconfig | 6 ------
 1 file changed, 6 deletions(-)

Comments

Ben Whitten Nov. 19, 2018, 10:29 a.m. UTC | #1 
Hi,

A shame as these boards only really need to start NAND and
boot uboot proper. Out of interest how much is it over in the
builder?

If SPL can't be shrunk any further then fair enough and;
Acked-by: Ben Whitten <ben.whitten@lairdtech.com>

Thanks,
Ben

> -----Original Message-----
> From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On
> Behalf Of Eugen.Hristev@microchip.com
> Sent: 19 November 2018 08:23
> To: u-boot@lists.denx.de
> Cc: Nicolas.Ferre@microchip.com
> Subject: [U-Boot] [PATCH 3/4] configs: wb45n_defconfig:
> Remove SPL
> 
> Due the size of SPL being too big, remove the SPL support.
> ---8<---
> arm-linux-gnueabi-ld: SPL image too big
> --->8---
> 
> Signed-off-by: Eugen Hristev
> <eugen.hristev@microchip.com>
> ---
>  configs/wb45n_defconfig | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/configs/wb45n_defconfig
> b/configs/wb45n_defconfig
> index 9d881e5..aef4e75 100644
> --- a/configs/wb45n_defconfig
> +++ b/configs/wb45n_defconfig
> @@ -3,17 +3,11 @@ CONFIG_SYS_THUMB_BUILD=y
>  CONFIG_ARCH_AT91=y
>  CONFIG_SYS_TEXT_BASE=0x23f00000
>  CONFIG_TARGET_WB45N=y
> -CONFIG_SPL_GPIO_SUPPORT=y
> -CONFIG_SPL_LIBCOMMON_SUPPORT=y
> -CONFIG_SPL_LIBGENERIC_SUPPORT=y
> -CONFIG_SPL_SERIAL_SUPPORT=y
> -CONFIG_SPL=y
>  CONFIG_NR_DRAM_BANKS=1
>  CONFIG_FIT=y
> 
> CONFIG_SYS_EXTRA_OPTIONS="AT91SAM9X5,SYS_USE_NA
> NDFLASH"
>  CONFIG_BOOTDELAY=3
>  CONFIG_BOARD_EARLY_INIT_F=y
> -CONFIG_SPL_NAND_SUPPORT=y
>  CONFIG_HUSH_PARSER=y
>  CONFIG_CMD_BOOTZ=y
>  CONFIG_CMD_MEMTEST=y
> --
> 2.7.4
> 
> ______________________________________________
> _
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
Ben Whitten Nov. 19, 2018, 2:27 p.m. UTC | #2 
Just compiled with the bootlin toolchain
' armv5-eabi--musl--stable-2018.02-2' from within buildroot
and it looks like an image is produced within size.
text	   data	    bss	    dec	    hex	filename
  17965	   1180	   4480	  23625	   5c49	u-boot-spl

It looks like the assertion calculates the assertion
incorrectly, will comment on that patch.

Ben
> -----Original Message-----
> From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On
> Behalf Of Ben Whitten
> Sent: 19 November 2018 10:30
> To: Eugen.Hristev@microchip.com; u-boot@lists.denx.de
> Cc: Nicolas.Ferre@microchip.com
> Subject: Re: [U-Boot] [PATCH 3/4] configs:
> wb45n_defconfig: Remove SPL
> 
> Hi,
> 
> A shame as these boards only really need to start NAND and
> boot uboot proper. Out of interest how much is it over in
> the
> builder?
> 
> If SPL can't be shrunk any further then fair enough and;
> Acked-by: Ben Whitten <ben.whitten@lairdtech.com>
> 
> Thanks,
> Ben
> 
> > -----Original Message-----
> > From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On
> > Behalf Of Eugen.Hristev@microchip.com
> > Sent: 19 November 2018 08:23
> > To: u-boot@lists.denx.de
> > Cc: Nicolas.Ferre@microchip.com
> > Subject: [U-Boot] [PATCH 3/4] configs: wb45n_defconfig:
> > Remove SPL
> >
> > Due the size of SPL being too big, remove the SPL support.
> > ---8<---
> > arm-linux-gnueabi-ld: SPL image too big
> > --->8---
> >
> > Signed-off-by: Eugen Hristev
> > <eugen.hristev@microchip.com>
> > ---
> >  configs/wb45n_defconfig | 6 ------
> >  1 file changed, 6 deletions(-)
> >
> > diff --git a/configs/wb45n_defconfig
> > b/configs/wb45n_defconfig
> > index 9d881e5..aef4e75 100644
> > --- a/configs/wb45n_defconfig
> > +++ b/configs/wb45n_defconfig
> > @@ -3,17 +3,11 @@ CONFIG_SYS_THUMB_BUILD=y
> >  CONFIG_ARCH_AT91=y
> >  CONFIG_SYS_TEXT_BASE=0x23f00000
> >  CONFIG_TARGET_WB45N=y
> > -CONFIG_SPL_GPIO_SUPPORT=y
> > -CONFIG_SPL_LIBCOMMON_SUPPORT=y
> > -CONFIG_SPL_LIBGENERIC_SUPPORT=y
> > -CONFIG_SPL_SERIAL_SUPPORT=y
> > -CONFIG_SPL=y
> >  CONFIG_NR_DRAM_BANKS=1
> >  CONFIG_FIT=y
> >
> >
> CONFIG_SYS_EXTRA_OPTIONS="AT91SAM9X5,SYS_USE_NA
> > NDFLASH"
> >  CONFIG_BOOTDELAY=3
> >  CONFIG_BOARD_EARLY_INIT_F=y
> > -CONFIG_SPL_NAND_SUPPORT=y
> >  CONFIG_HUSH_PARSER=y
> >  CONFIG_CMD_BOOTZ=y
> >  CONFIG_CMD_MEMTEST=y
> > --
> > 2.7.4
> >
> >
> ______________________________________________
> > _
> > U-Boot mailing list
> > U-Boot@lists.denx.de
> > https://lists.denx.de/listinfo/u-boot
> ______________________________________________
> _
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
diff mbox series

Patch

diff --git a/configs/wb45n_defconfig b/configs/wb45n_defconfig
index 9d881e5..aef4e75 100644
--- a/configs/wb45n_defconfig
+++ b/configs/wb45n_defconfig
@@ -3,17 +3,11 @@  CONFIG_SYS_THUMB_BUILD=y
 CONFIG_ARCH_AT91=y
 CONFIG_SYS_TEXT_BASE=0x23f00000
 CONFIG_TARGET_WB45N=y
-CONFIG_SPL_GPIO_SUPPORT=y
-CONFIG_SPL_LIBCOMMON_SUPPORT=y
-CONFIG_SPL_LIBGENERIC_SUPPORT=y
-CONFIG_SPL_SERIAL_SUPPORT=y
-CONFIG_SPL=y
 CONFIG_NR_DRAM_BANKS=1
 CONFIG_FIT=y
 CONFIG_SYS_EXTRA_OPTIONS="AT91SAM9X5,SYS_USE_NANDFLASH"
 CONFIG_BOOTDELAY=3
 CONFIG_BOARD_EARLY_INIT_F=y
-CONFIG_SPL_NAND_SUPPORT=y
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_BOOTZ=y
 CONFIG_CMD_MEMTEST=y