diff mbox series

[U-Boot,v2,01/19] cmd: Kconfig: Do not include EEPROM if DM_I2C is used without DM_I2C_COMPAT

Message ID 1538757935-6481-2-git-send-email-jjhiblot@ti.com
State Superseded
Delegated to: Tom Rini
Headers show
Series DM_I2C_COMPAT removal for all ti platforms | expand

Commit Message

Jean-Jacques Hiblot Oct. 5, 2018, 4:45 p.m. UTC
The implementation of the EEPROM commands does not support the DM I2C API.
Prevent compilation breakage by not enabling it if the non-DM API is not
available (if DM_I2C is used without DM_I2C_COMPAT)

Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>

---

Changes in v2:
- Add missing commit log to the commit disabling CMD_EEPROM when non-DM API
  is not available

 cmd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Simon Glass Oct. 11, 2018, 3:13 a.m. UTC | #1
On 5 October 2018 at 10:45, Jean-Jacques Hiblot <jjhiblot@ti.com> wrote:
> The implementation of the EEPROM commands does not support the DM I2C API.
> Prevent compilation breakage by not enabling it if the non-DM API is not
> available (if DM_I2C is used without DM_I2C_COMPAT)
>
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
>
> ---
>
> Changes in v2:
> - Add missing commit log to the commit disabling CMD_EEPROM when non-DM API
>   is not available
>
>  cmd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Simon Glass <sjg@chromium.org>

Or perhaps we should convert or delete it?
diff mbox series

Patch

diff --git a/cmd/Kconfig b/cmd/Kconfig
index 7ed3c9c..b4e1cbf 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -445,6 +445,7 @@  config CRC32_VERIFY
 
 config CMD_EEPROM
 	bool "eeprom - EEPROM subsystem"
+	depends on !DM_I2C || DM_I2C_COMPAT
 	help
 	  (deprecated, needs conversion to driver model)
 	  Provides commands to read and write EEPROM (Electrically Erasable