| Message ID | 1534240262-8904-2-git-send-email-philipp.tomsich@theobroma-systems.com |
|---|---|
| State | Superseded |
| Delegated to: | Philipp Tomsich |
| Headers | show |
| Series | Update RV3029 driver to DM and add DM-backed bootcount support | expand |
On 08/14/2018 11:51 AM, Philipp Tomsich wrote: > The MicroCrystal RV3029 driver didn't have a Kconfig entry and was not used > anywhere. Add it to Kconfig to make it selectable. > > Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > Tested-by: Klaus Goger <klaus.goger@theobroma-systems.com> > --- > > drivers/rtc/Kconfig | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig > index 5436509..8a6e796 100644 > --- a/drivers/rtc/Kconfig > +++ b/drivers/rtc/Kconfig > @@ -42,6 +42,16 @@ config RTC_ISL1208 > This driver supports reading and writing the RTC/calendar and detects > total power failures. > > +config RTC_RV3029 > + bool "Enable RV3029 driver" > + depends on DM_RTC > + help > + The MicroCrystal RV3029 is a I2C Real Time Clock (RTC) with 8-byte %s/a I2C/an I2C/ > + battery-backed SRAM. > + > + This driver supports reading and writing the RTC/calendar and the What do you mean by calendar? If you just mean the RTC date register, just drop the misleading word. %s/RTC\/calendar/RTC/ > + battery-baced SRAM section. %s/baced/backed/ Best regards Heinrich > + > config RTC_RX8010SJ > bool "Enable RX8010SJ driver" > depends on DM_RTC >
> On 14 Aug 2018, at 18:46, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > > On 08/14/2018 11:51 AM, Philipp Tomsich wrote: >> The MicroCrystal RV3029 driver didn't have a Kconfig entry and was not used >> anywhere. Add it to Kconfig to make it selectable. >> >> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> >> Tested-by: Klaus Goger <klaus.goger@theobroma-systems.com> >> --- >> >> drivers/rtc/Kconfig | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig >> index 5436509..8a6e796 100644 >> --- a/drivers/rtc/Kconfig >> +++ b/drivers/rtc/Kconfig >> @@ -42,6 +42,16 @@ config RTC_ISL1208 >> This driver supports reading and writing the RTC/calendar and detects >> total power failures. >> >> +config RTC_RV3029 >> + bool "Enable RV3029 driver" >> + depends on DM_RTC >> + help >> + The MicroCrystal RV3029 is a I2C Real Time Clock (RTC) with 8-byte > > %s/a I2C/an I2C/ > >> + battery-backed SRAM. >> + >> + This driver supports reading and writing the RTC/calendar and the > > What do you mean by calendar? If you just mean the RTC date register, > just drop the misleading word. > > %s/RTC\/calendar/RTC/ The RV3029 datasheet also describes the devices as a RTC/calendar: "The RV-3029 is a CMOS low power, real-time clock/calendar module…” In the same Kconfig, there’s the same duality (i.e. RTC _and_ calendar) in the help text for the RTC_PCF2127 RTC_ISL1208 Happy to drop this here, if that’s the consensus... > >> + battery-baced SRAM section. > > %s/baced/backed/ > > Best regards > > Heinrich > >> + >> config RTC_RX8010SJ >> bool "Enable RX8010SJ driver" >> depends on DM_RTC >> >
diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index 5436509..8a6e796 100644 --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -42,6 +42,16 @@ config RTC_ISL1208 This driver supports reading and writing the RTC/calendar and detects total power failures. +config RTC_RV3029 + bool "Enable RV3029 driver" + depends on DM_RTC + help + The MicroCrystal RV3029 is a I2C Real Time Clock (RTC) with 8-byte + battery-backed SRAM. + + This driver supports reading and writing the RTC/calendar and the + battery-baced SRAM section. + config RTC_RX8010SJ bool "Enable RX8010SJ driver" depends on DM_RTC