| Message ID | 1532338891-6848-3-git-send-email-patrick.delaunay@st.com |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | dm: led: remove auto probe in binding function | expand |
Hi Patrick, On 23 July 2018 at 03:41, Patrick Delaunay <patrick.delaunay@st.com> wrote: > This reverts commit bc882f5d5c7b4d6ed5e927bf838863af43c786e7. A revert should have a motivation and a discussion of the purpose, just like any other patch. Can you add it please? > > Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> > --- > > Changes in v2: None > > drivers/led/led_gpio.c | 9 --------- > 1 file changed, 9 deletions(-) Regards, Simon
Hi Simon, > From: sjg@google.com <sjg@google.com> On Behalf Of Simon Glass > Sent: mardi 24 juillet 2018 01:48 > > Hi Patrick, > > On 23 July 2018 at 03:41, Patrick Delaunay <patrick.delaunay@st.com> wrote: > > This reverts commit bc882f5d5c7b4d6ed5e927bf838863af43c786e7. > > A revert should have a motivation and a discussion of the purpose, just like any > other patch. Can you add it please? I wil add a motivaiton in v3. > > > > Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> > > --- > > > > Changes in v2: None > > > > drivers/led/led_gpio.c | 9 --------- > > 1 file changed, 9 deletions(-) > > Regards, > Simon Regards Patrick
diff --git a/drivers/led/led_gpio.c b/drivers/led/led_gpio.c index a36942b..533587d 100644 --- a/drivers/led/led_gpio.c +++ b/drivers/led/led_gpio.c @@ -10,7 +10,6 @@ #include <led.h> #include <asm/gpio.h> #include <dm/lists.h> -#include <dm/uclass-internal.h> struct led_gpio_priv { struct gpio_desc gpio; @@ -118,14 +117,6 @@ static int led_gpio_bind(struct udevice *parent) return ret; uc_plat = dev_get_uclass_platdata(dev); uc_plat->label = label; - - if (ofnode_read_bool(node, "default-state")) { - struct udevice *devp; - - ret = uclass_get_device_tail(dev, 0, &devp); - if (ret) - return ret; - } } return 0;
This reverts commit bc882f5d5c7b4d6ed5e927bf838863af43c786e7. Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> --- Changes in v2: None drivers/led/led_gpio.c | 9 --------- 1 file changed, 9 deletions(-)