| Message ID | 1524112377-13724-9-git-send-email-alex.kiernan@gmail.com |
|---|---|
| State | Accepted |
| Commit | ab9e12f651d9211aa0d3c9b9e579c38bd8704054 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Fix SPL build without CONFIG_SPL_SERIAL_SUPPORT | expand |
On Thu, Apr 19, 2018 at 04:32:57AM +0000, Alex Kiernan wrote: > If SPL serial support is disabled nothing brings in sprintf, snprintf > or simple_strtoul: > > env/built-in.o: In function `regex_callback': > env/attr.c:128: undefined reference to `sprintf' > disk/built-in.o: In function `blk_get_device_by_str': > disk/part.c:386: undefined reference to `simple_strtoul' > disk/part.c:395: undefined reference to `simple_strtoul' > disk/built-in.o: In function `blk_get_device_part_str': > disk/part.c:522: undefined reference to `simple_strtoul' > disk/built-in.o: In function `part_set_generic_name': > disk/part.c:704: undefined reference to `sprintf' > drivers/built-in.o: In function `init_peripheral_ep': > drivers/usb/musb-new/musb_gadget.c:1826: undefined reference to `sprintf' > drivers/built-in.o: In function `musb_core_init': > drivers/usb/musb-new/musb_core.c:1451: undefined reference to `snprintf' > > Add those dependencies here. > > Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com> Applied to u-boot/master, thanks!
diff --git a/disk/Kconfig b/disk/Kconfig index 8af2a95..28fb81c 100644 --- a/disk/Kconfig +++ b/disk/Kconfig @@ -4,6 +4,10 @@ menu "Partition Types" config PARTITIONS bool "Enable Partition Labels (disklabels) support" default y + select SPL_SPRINTF if SPL + select TPL_SPRINTF if TPL + select SPL_STRTO if SPL + select TPL_STRTO if TPL help Partition Labels (disklabels) Supported: Zero or more of the following: diff --git a/drivers/usb/musb-new/Kconfig b/drivers/usb/musb-new/Kconfig index ea5bae2..f8f2205 100644 --- a/drivers/usb/musb-new/Kconfig +++ b/drivers/usb/musb-new/Kconfig @@ -5,12 +5,16 @@ comment "MUSB Controller Driver" config USB_MUSB_HOST bool "MUSB host mode support" + select SPL_SPRINTF if SPL + select TPL_SPRINTF if TPL help Enables the MUSB USB dual-role controller in host mode. config USB_MUSB_GADGET bool "MUSB gadget mode support" select USB_GADGET_DUALSPEED + select SPL_SPRINTF if SPL + select TPL_SPRINTF if TPL help Enables the MUSB USB dual-role controller in gadget mode.
If SPL serial support is disabled nothing brings in sprintf, snprintf or simple_strtoul: env/built-in.o: In function `regex_callback': env/attr.c:128: undefined reference to `sprintf' disk/built-in.o: In function `blk_get_device_by_str': disk/part.c:386: undefined reference to `simple_strtoul' disk/part.c:395: undefined reference to `simple_strtoul' disk/built-in.o: In function `blk_get_device_part_str': disk/part.c:522: undefined reference to `simple_strtoul' disk/built-in.o: In function `part_set_generic_name': disk/part.c:704: undefined reference to `sprintf' drivers/built-in.o: In function `init_peripheral_ep': drivers/usb/musb-new/musb_gadget.c:1826: undefined reference to `sprintf' drivers/built-in.o: In function `musb_core_init': drivers/usb/musb-new/musb_core.c:1451: undefined reference to `snprintf' Add those dependencies here. Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com> --- Changes in v2: - Guard select if SPL/TPL_{SPRINTF,STRTO} symbols with SPL/TPL disk/Kconfig | 4 ++++ drivers/usb/musb-new/Kconfig | 4 ++++ 2 files changed, 8 insertions(+)