| Message ID | 1522073505-13066-3-git-send-email-bryan.odonoghue@linaro.org |
|---|---|
| State | Changes Requested |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | imx: hab: Add helper functions for scripted HAB auth | expand |
On Mon, Mar 26, 2018 at 11:11 AM, Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote: > +/* Specify the offset of the IVT in the IMX header as expected by BootROM */ > +#define BOOTROM_IVT_HDR_OFFSET 0xC00 You introduce this new define, but there is no user for it.
On 26/03/18 15:15, Fabio Estevam wrote: > On Mon, Mar 26, 2018 at 11:11 AM, Bryan O'Donoghue > <bryan.odonoghue@linaro.org> wrote: > >> +/* Specify the offset of the IVT in the IMX header as expected by BootROM */ >> +#define BOOTROM_IVT_HDR_OFFSET 0xC00 > > You introduce this new define, but there is no user for it. > Ah not _yet_ There's a bunch of code in a BSP mod I plan to bomb the list with that makes use of this.
On Mon, Mar 26, 2018 at 11:30 AM, Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote: > Ah not _yet_ > > There's a bunch of code in a BSP mod I plan to bomb the list with that makes > use of this. In this case, please make this patch part of the series where we actually see its usage, thanks.
On 26/03/18 15:31, Fabio Estevam wrote: > On Mon, Mar 26, 2018 at 11:30 AM, Bryan O'Donoghue > <bryan.odonoghue@linaro.org> wrote: > >> Ah not _yet_ >> >> There's a bunch of code in a BSP mod I plan to bomb the list with that makes >> use of this. > > In this case, please make this patch part of the series where we > actually see its usage, thanks. > sure OK
diff --git a/include/imximage.h b/include/imximage.h index 553b852..800fd63 100644 --- a/include/imximage.h +++ b/include/imximage.h @@ -14,6 +14,9 @@ #define APP_CODE_BARKER 0xB1 #define DCD_BARKER 0xB17219E9 +/* Specify the offset of the IVT in the IMX header as expected by BootROM */ +#define BOOTROM_IVT_HDR_OFFSET 0xC00 + /* * NOTE: This file must be kept in sync with arch/arm/include/asm/\ * mach-imx/imximage.cfg because tools/imximage.c can not
This patch adds BOOTROM_IVT_HDR_OFFSET at 0xC00. The BootROM expects to find the IVT header at a particular offset in an i.MX image. Defining the expected offset of the IVT header in the first-stage BootROM image format is of use of later stage authentication routines where those routines continue to follow the first-stage authentication layout. This patch defines the first stage offset with an upcoming set of BSP patches making use of that offset subsequently. Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> Cc: Utkarsh Gupta <utkarsh.gupta@nxp.com> Cc: Breno Lima <breno.lima@nxp.com> Cc: Fabio Estevam <fabio.estevam@nxp.com> --- include/imximage.h | 3 +++ 1 file changed, 3 insertions(+)