| Message ID | 1518702926-18874-13-git-send-email-alex.kiernan@gmail.com |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Convert bootcount drivers to Kconfig | expand |
Hi Alex, Please add at least one sentence to the commit message (not only the topic). A side note - I did not received patch 13/13, It can be found here: http://patchwork.ozlabs.org/patch/873845/ It is also Ok (as I forgotten to remove SINGLEWORD from whitelist).. Above patches seems to be eligible to current mailing (rc2+). The BOOTCOUNT_ADDR conversion would need to wait for merge window, IMHO. Thanks for your effort, Best regards, Łukasz > Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com> > --- > > Changes in v2: None > > drivers/bootcount/Kconfig | 9 ++++++++- > include/configs/ids8313.h | 1 - > scripts/config_whitelist.txt | 1 - > 3 files changed, 8 insertions(+), 3 deletions(-) > > diff --git a/drivers/bootcount/Kconfig b/drivers/bootcount/Kconfig > index ce26e38..1a037f2 100644 > --- a/drivers/bootcount/Kconfig > +++ b/drivers/bootcount/Kconfig > @@ -66,7 +66,14 @@ config BOOTCOUNT_I2C > Enable support for the bootcounter on an i2c (like RTC) > device. CONFIG_SYS_I2C_RTC_ADDR = i2c chip address > BOOTCOUNT_ADDR = i2c addr which is used for the > bootcounter. > - CONFIG_BOOTCOUNT_ALEN = address len > + > +config BOOTCOUNT_ALEN > + int "I2C address length" > + default 1 > + depends on BOOTCOUNT_I2C > + help > + Length of the the I2C address at BOOTCOUNT_ADDR for storing > + the boot counter. > > config BOOTCOUNT_AT91 > bool "Boot counter for Atmel AT91SAM9XE" > diff --git a/include/configs/ids8313.h b/include/configs/ids8313.h > index 4449e27..fb891a3 100644 > --- a/include/configs/ids8313.h > +++ b/include/configs/ids8313.h > @@ -515,7 +515,6 @@ > #define CONFIG_MTD_PARTITIONS > > /* bootcount support */ > -#define CONFIG_BOOTCOUNT_ALEN 1 > #define BOOTCOUNT_ADDR 0x9 > > #define CONFIG_IMAGE_FORMAT_LEGACY > diff --git a/scripts/config_whitelist.txt > b/scripts/config_whitelist.txt index a8380c6..e16085b 100644 > --- a/scripts/config_whitelist.txt > +++ b/scripts/config_whitelist.txt > @@ -147,7 +147,6 @@ CONFIG_BOARD_TYPES > CONFIG_BOOGER > CONFIG_BOOM > CONFIG_BOOTBLOCK > -CONFIG_BOOTCOUNT_ALEN > CONFIG_BOOTFILE > CONFIG_BOOTMAPSZ > CONFIG_BOOTMODE Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
On Fri, Feb 16, 2018 at 9:36 AM, Lukasz Majewski <lukma@denx.de> wrote: > Hi Alex, > > Please add at least one sentence to the commit message (not only the > topic). > Sure. > A side note - I did not received patch 13/13, > > It can be found here: > http://patchwork.ozlabs.org/patch/873845/ > > It is also Ok (as I forgotten to remove SINGLEWORD from whitelist).. > > Above patches seems to be eligible to current mailing (rc2+). > > The BOOTCOUNT_ADDR conversion would need to wait for merge window, IMHO. > I'll split the pieces apart and get the non-BOOTCOUNT_ADDR part out.
diff --git a/drivers/bootcount/Kconfig b/drivers/bootcount/Kconfig index ce26e38..1a037f2 100644 --- a/drivers/bootcount/Kconfig +++ b/drivers/bootcount/Kconfig @@ -66,7 +66,14 @@ config BOOTCOUNT_I2C Enable support for the bootcounter on an i2c (like RTC) device. CONFIG_SYS_I2C_RTC_ADDR = i2c chip address BOOTCOUNT_ADDR = i2c addr which is used for the bootcounter. - CONFIG_BOOTCOUNT_ALEN = address len + +config BOOTCOUNT_ALEN + int "I2C address length" + default 1 + depends on BOOTCOUNT_I2C + help + Length of the the I2C address at BOOTCOUNT_ADDR for storing + the boot counter. config BOOTCOUNT_AT91 bool "Boot counter for Atmel AT91SAM9XE" diff --git a/include/configs/ids8313.h b/include/configs/ids8313.h index 4449e27..fb891a3 100644 --- a/include/configs/ids8313.h +++ b/include/configs/ids8313.h @@ -515,7 +515,6 @@ #define CONFIG_MTD_PARTITIONS /* bootcount support */ -#define CONFIG_BOOTCOUNT_ALEN 1 #define BOOTCOUNT_ADDR 0x9 #define CONFIG_IMAGE_FORMAT_LEGACY diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt index a8380c6..e16085b 100644 --- a/scripts/config_whitelist.txt +++ b/scripts/config_whitelist.txt @@ -147,7 +147,6 @@ CONFIG_BOARD_TYPES CONFIG_BOOGER CONFIG_BOOM CONFIG_BOOTBLOCK -CONFIG_BOOTCOUNT_ALEN CONFIG_BOOTFILE CONFIG_BOOTMAPSZ CONFIG_BOOTMODE
Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com> --- Changes in v2: None drivers/bootcount/Kconfig | 9 ++++++++- include/configs/ids8313.h | 1 - scripts/config_whitelist.txt | 1 - 3 files changed, 8 insertions(+), 3 deletions(-)