| Message ID | 1516055298-7974-1-git-send-email-chrisrblake93@gmail.com |
|---|---|
| State | Accepted |
| Commit | a6968ecb0ad6b06552c97005eba265a4c5761626 |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
| Series | [U-Boot] gpio: sunxi: Add compatible string for H5 PIO | expand |
On Tue, Jan 16, 2018 at 3:58 AM, Chris Blake <chrisrblake93@gmail.com> wrote:
> Due to the changes in https://github.com/linux-sunxi/u-boot-sunxi/commit/8faac0941cd409c6ff3738fbf658de2296f48e9a, allwinner,sun50i-h5-pinctrl needs to be defined otherwise PIO does not work on H5 based boards.
What is the issue observed w/o this?
On Tue, Jan 23, 2018 at 1:09 PM, Jagan Teki <jagannadh.teki@gmail.com> wrote: > On Tue, Jan 16, 2018 at 3:58 AM, Chris Blake <chrisrblake93@gmail.com> wrote: >> Due to the changes in https://github.com/linux-sunxi/u-boot-sunxi/commit/8faac0941cd409c6ff3738fbf658de2296f48e9a, allwinner,sun50i-h5-pinctrl needs to be defined otherwise PIO does not work on H5 based boards. > > What is the issue observed w/o this? Without this, H5 boards that rely on CONFIG_MACPWR for Ethernet do not support networking in u-boot. This also breaks access to GPIOs via the gpio cmd.
On Wed, Jan 24, 2018 at 12:42 AM, Chris Blake <chrisrblake93@gmail.com> wrote: > On Tue, Jan 23, 2018 at 1:09 PM, Jagan Teki <jagannadh.teki@gmail.com> wrote: >> On Tue, Jan 16, 2018 at 3:58 AM, Chris Blake <chrisrblake93@gmail.com> wrote: >>> Due to the changes in https://github.com/linux-sunxi/u-boot-sunxi/commit/8faac0941cd409c6ff3738fbf658de2296f48e9a, allwinner,sun50i-h5-pinctrl needs to be defined otherwise PIO does not work on H5 based boards. >> >> What is the issue observed w/o this? > > Without this, H5 boards that rely on CONFIG_MACPWR for Ethernet do not > support networking in u-boot. This also breaks access to GPIOs via the > gpio cmd. Ok, did you verify it on opi-pc2?
On Tue, Jan 23, 2018 at 1:15 PM, Jagan Teki <jagannadh.teki@gmail.com> wrote: > On Wed, Jan 24, 2018 at 12:42 AM, Chris Blake <chrisrblake93@gmail.com> wrote: >> On Tue, Jan 23, 2018 at 1:09 PM, Jagan Teki <jagannadh.teki@gmail.com> wrote: >>> On Tue, Jan 16, 2018 at 3:58 AM, Chris Blake <chrisrblake93@gmail.com> wrote: >>>> Due to the changes in https://github.com/linux-sunxi/u-boot-sunxi/commit/8faac0941cd409c6ff3738fbf658de2296f48e9a, allwinner,sun50i-h5-pinctrl needs to be defined otherwise PIO does not work on H5 based boards. >>> >>> What is the issue observed w/o this? >> >> Without this, H5 boards that rely on CONFIG_MACPWR for Ethernet do not >> support networking in u-boot. This also breaks access to GPIOs via the >> gpio cmd. > > Ok, did you verify it on opi-pc2? This was verified on a FriendlyARM NanoPi Neo2 and FriendlyARM NanoPi Neo Core2.
On Tue, Jan 16, 2018 at 3:58 AM, Chris Blake <chrisrblake93@gmail.com> wrote: > Due to the changes in https://github.com/linux-sunxi/u-boot-sunxi/commit/8faac0941cd409c6ff3738fbf658de2296f48e9a, allwinner,sun50i-h5-pinctrl needs to be defined otherwise PIO does not work on H5 based boards. > > Signed-off-by: Chris Blake <chrisrblake93@gmail.com> > --- > drivers/gpio/sunxi_gpio.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpio/sunxi_gpio.c b/drivers/gpio/sunxi_gpio.c > index b47cc66..856b7ef 100644 > --- a/drivers/gpio/sunxi_gpio.c > +++ b/drivers/gpio/sunxi_gpio.c > @@ -345,6 +345,7 @@ static const struct udevice_id sunxi_gpio_ids[] = { > ID("allwinner,sun4i-a10-pinctrl", a_all), > ID("allwinner,sun5i-a10s-pinctrl", a_all), > ID("allwinner,sun5i-a13-pinctrl", a_all), > + ID("allwinner,sun50i-h5-pinctrl", a_all), Reviewed-by: Jagan Teki <jagan@openedev.com>
diff --git a/drivers/gpio/sunxi_gpio.c b/drivers/gpio/sunxi_gpio.c index b47cc66..856b7ef 100644 --- a/drivers/gpio/sunxi_gpio.c +++ b/drivers/gpio/sunxi_gpio.c @@ -345,6 +345,7 @@ static const struct udevice_id sunxi_gpio_ids[] = { ID("allwinner,sun4i-a10-pinctrl", a_all), ID("allwinner,sun5i-a10s-pinctrl", a_all), ID("allwinner,sun5i-a13-pinctrl", a_all), + ID("allwinner,sun50i-h5-pinctrl", a_all), ID("allwinner,sun6i-a31-pinctrl", a_all), ID("allwinner,sun6i-a31s-pinctrl", a_all), ID("allwinner,sun7i-a20-pinctrl", a_all),
Due to the changes in https://github.com/linux-sunxi/u-boot-sunxi/commit/8faac0941cd409c6ff3738fbf658de2296f48e9a, allwinner,sun50i-h5-pinctrl needs to be defined otherwise PIO does not work on H5 based boards. Signed-off-by: Chris Blake <chrisrblake93@gmail.com> --- drivers/gpio/sunxi_gpio.c | 1 + 1 file changed, 1 insertion(+) -- 2.7.4