| Message ID | 1514988989-23348-1-git-send-email-trini@konsulko.com |
|---|---|
| State | Accepted |
| Commit | bf52330a507901af2a5581bec99c6da01388a335 |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | [U-Boot] imx: ventana: Rework CONFIG_CMD_GSC code to not be included in SPL | expand |
On Wed, Jan 3, 2018 at 6:16 AM, Tom Rini <trini@konsulko.com> wrote: > The command can only be used from full U-Boot, so do not build it into > SPL. > > Cc: Stefano Babic <sbabic@denx.de> > Cc: Fabio Estevam <fabio.estevam@nxp.com> > Cc: Tim Harvey <tharvey@gateworks.com> > Signed-off-by: Tom Rini <trini@konsulko.com> > --- > board/gateworks/gw_ventana/gsc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/board/gateworks/gw_ventana/gsc.c b/board/gateworks/gw_ventana/gsc.c > index 68b1ddb532e0..f2a01b84deb2 100644 > --- a/board/gateworks/gw_ventana/gsc.c > +++ b/board/gateworks/gw_ventana/gsc.c > @@ -172,7 +172,7 @@ int gsc_boot_wd_disable(void) > return 1; > } > > -#ifdef CONFIG_CMD_GSC > +#if defined(CONFIG_CMD_GSC) && !defined(CONFIG_SPL_BUILD) > static int do_gsc_sleep(cmd_tbl_t *cmdtp, int flag, int argc, > char * const argv[]) > { > -- > 2.7.4 > Acked-by: Tim Harvey <tharvey@gateworks.com> Thanks Tom, Tim
On Wed, Jan 3, 2018 at 12:16 PM, Tom Rini <trini@konsulko.com> wrote: > The command can only be used from full U-Boot, so do not build it into > SPL. > > Cc: Stefano Babic <sbabic@denx.de> > Cc: Fabio Estevam <fabio.estevam@nxp.com> > Cc: Tim Harvey <tharvey@gateworks.com> > Signed-off-by: Tom Rini <trini@konsulko.com> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
On 03/01/2018 15:16, Tom Rini wrote: > The command can only be used from full U-Boot, so do not build it into > SPL. > > Cc: Stefano Babic <sbabic@denx.de> > Cc: Fabio Estevam <fabio.estevam@nxp.com> > Cc: Tim Harvey <tharvey@gateworks.com> > Signed-off-by: Tom Rini <trini@konsulko.com> > --- > board/gateworks/gw_ventana/gsc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/board/gateworks/gw_ventana/gsc.c b/board/gateworks/gw_ventana/gsc.c > index 68b1ddb532e0..f2a01b84deb2 100644 > --- a/board/gateworks/gw_ventana/gsc.c > +++ b/board/gateworks/gw_ventana/gsc.c > @@ -172,7 +172,7 @@ int gsc_boot_wd_disable(void) > return 1; > } > > -#ifdef CONFIG_CMD_GSC > +#if defined(CONFIG_CMD_GSC) && !defined(CONFIG_SPL_BUILD) > static int do_gsc_sleep(cmd_tbl_t *cmdtp, int flag, int argc, > char * const argv[]) > { > Applied to u-boot-imx, thanks ! Best regards, Stefano Babic
diff --git a/board/gateworks/gw_ventana/gsc.c b/board/gateworks/gw_ventana/gsc.c index 68b1ddb532e0..f2a01b84deb2 100644 --- a/board/gateworks/gw_ventana/gsc.c +++ b/board/gateworks/gw_ventana/gsc.c @@ -172,7 +172,7 @@ int gsc_boot_wd_disable(void) return 1; } -#ifdef CONFIG_CMD_GSC +#if defined(CONFIG_CMD_GSC) && !defined(CONFIG_SPL_BUILD) static int do_gsc_sleep(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) {
The command can only be used from full U-Boot, so do not build it into SPL. Cc: Stefano Babic <sbabic@denx.de> Cc: Fabio Estevam <fabio.estevam@nxp.com> Cc: Tim Harvey <tharvey@gateworks.com> Signed-off-by: Tom Rini <trini@konsulko.com> --- board/gateworks/gw_ventana/gsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)