| Message ID | 1513737260-38743-1-git-send-email-ran.wang_1@nxp.com |
|---|---|
| State | Deferred |
| Delegated to: | Marek Vasut |
| Headers | show |
| Series | [U-Boot,RESEND,v2,1/3] armv8: ls1012a: Add USB 2.0 controller phy type for ls1012aqds board | expand |
On 12/20/2017 03:34 AM, Ran Wang wrote: > Without this propertiy, U-Boot will pop warning of 'USB phy type not > defined' when select CONFIG_HAS_FSL_DR_USB. I take it the "propertiy" is the phy_type one , right ? Anyway, applied all 3 . > Signed-off-by: Ran Wang <ran.wang_1@nxp.com> > --- > Change in v2: > None > > arch/arm/dts/fsl-ls1012a-qds.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/dts/fsl-ls1012a-qds.dtsi b/arch/arm/dts/fsl-ls1012a-qds.dtsi > index dde7134..d17cd99 100644 > --- a/arch/arm/dts/fsl-ls1012a-qds.dtsi > +++ b/arch/arm/dts/fsl-ls1012a-qds.dtsi > @@ -121,3 +121,8 @@ > &duart0 { > status = "okay"; > }; > + > +&usb0 { > + status = "okay"; > + phy_type = "ulpi"; > +}; >
Hi Marek, > -----Original Message----- > From: Marek Vasut [mailto:marex@denx.de] > Sent: Wednesday, December 20, 2017 5:02 PM > To: Ran Wang <ran.wang_1@nxp.com>; Albert Aribaud > <albert.u.boot@aribaud.net>; Prabhakar Kushwaha > <prabhakar.kushwaha@nxp.com>; Alison Wang > <alison.wang@freescale.com>; Sumit Garg <sumit.garg@nxp.com>; York Sun > <york.sun@nxp.com>; Bin Meng <bmeng.cn@gmail.com> > Cc: Stefan Roese <sr@denx.de>; Nobuhiro Iwamatsu > <iwamatsu@nigauri.org>; Philipp Tomsich <philipp.tomsich@theobroma- > systems.com>; Konstantin Porotchkin <kostap@marvell.com>; Uri Mashiach > <uri.mashiach@compulab.co.il>; Simon Glass <sjg@chromium.org>; Xiaobo > Xie <xiaobo.xie@nxp.com>; Jiafei Pan <jiafei.pan@nxp.com>; u- > boot@lists.denx.de > Subject: Re: [PATCH RESEND v2 1/3] armv8: ls1012a: Add USB 2.0 controller > phy type for ls1012aqds board > > On 12/20/2017 03:34 AM, Ran Wang wrote: > > Without this propertiy, U-Boot will pop warning of 'USB phy type not > > defined' when select CONFIG_HAS_FSL_DR_USB. > > I take it the "propertiy" is the phy_type one , right ? > Yes, it's phy_type. > Anyway, applied all 3 . > Thank you. > > Signed-off-by: Ran Wang <ran.wang_1@nxp.com> > > --- > > Change in v2: > > None > > > > arch/arm/dts/fsl-ls1012a-qds.dtsi | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/arm/dts/fsl-ls1012a-qds.dtsi > > b/arch/arm/dts/fsl-ls1012a-qds.dtsi > > index dde7134..d17cd99 100644 > > --- a/arch/arm/dts/fsl-ls1012a-qds.dtsi > > +++ b/arch/arm/dts/fsl-ls1012a-qds.dtsi > > @@ -121,3 +121,8 @@ > > &duart0 { > > status = "okay"; > > }; > > + > > +&usb0 { > > + status = "okay"; > > + phy_type = "ulpi"; > > +}; > > > > Best Regards, Ran
On 12/20/2017 10:54 AM, Ran Wang wrote: > Hi Marek, > >> -----Original Message----- >> From: Marek Vasut [mailto:marex@denx.de] >> Sent: Wednesday, December 20, 2017 5:02 PM >> To: Ran Wang <ran.wang_1@nxp.com>; Albert Aribaud >> <albert.u.boot@aribaud.net>; Prabhakar Kushwaha >> <prabhakar.kushwaha@nxp.com>; Alison Wang >> <alison.wang@freescale.com>; Sumit Garg <sumit.garg@nxp.com>; York Sun >> <york.sun@nxp.com>; Bin Meng <bmeng.cn@gmail.com> >> Cc: Stefan Roese <sr@denx.de>; Nobuhiro Iwamatsu >> <iwamatsu@nigauri.org>; Philipp Tomsich <philipp.tomsich@theobroma- >> systems.com>; Konstantin Porotchkin <kostap@marvell.com>; Uri Mashiach >> <uri.mashiach@compulab.co.il>; Simon Glass <sjg@chromium.org>; Xiaobo >> Xie <xiaobo.xie@nxp.com>; Jiafei Pan <jiafei.pan@nxp.com>; u- >> boot@lists.denx.de >> Subject: Re: [PATCH RESEND v2 1/3] armv8: ls1012a: Add USB 2.0 controller >> phy type for ls1012aqds board ^ drop this nonsense please >> On 12/20/2017 03:34 AM, Ran Wang wrote: >>> Without this propertiy, U-Boot will pop warning of 'USB phy type not >>> defined' when select CONFIG_HAS_FSL_DR_USB. >> >> I take it the "propertiy" is the phy_type one , right ? >> > > Yes, it's phy_type. You should be more precise in the commit message. Also, cull the CC list next time.
From: Marek Vasut [mailto:marex@denx.de] Sent: Wednesday, December 20, 2017 6:05 PM > On 12/20/2017 10:54 AM, Ran Wang wrote: > > Hi Marek, > > > >> -----Original Message----- > >> From: Marek Vasut [mailto:marex@denx.de] > >> Sent: Wednesday, December 20, 2017 5:02 PM > >> To: Ran Wang <ran.wang_1@nxp.com>; Albert Aribaud > >> <albert.u.boot@aribaud.net>; Prabhakar Kushwaha > >> <prabhakar.kushwaha@nxp.com>; Alison Wang > >> <alison.wang@freescale.com>; Sumit Garg <sumit.garg@nxp.com>; York > >> Sun <york.sun@nxp.com>; Bin Meng <bmeng.cn@gmail.com> > >> Cc: Stefan Roese <sr@denx.de>; Nobuhiro Iwamatsu > >> <iwamatsu@nigauri.org>; Philipp Tomsich <philipp.tomsich@theobroma- > >> systems.com>; Konstantin Porotchkin <kostap@marvell.com>; Uri > >> Mashiach <uri.mashiach@compulab.co.il>; Simon Glass > >> <sjg@chromium.org>; Xiaobo Xie <xiaobo.xie@nxp.com>; Jiafei Pan > >> <jiafei.pan@nxp.com>; u- boot@lists.denx.de > >> Subject: Re: [PATCH RESEND v2 1/3] armv8: ls1012a: Add USB 2.0 > >> controller phy type for ls1012aqds board > > ^ drop this nonsense please > > >> On 12/20/2017 03:34 AM, Ran Wang wrote: > >>> Without this propertiy, U-Boot will pop warning of 'USB phy type not > >>> defined' when select CONFIG_HAS_FSL_DR_USB. > >> > >> I take it the "propertiy" is the phy_type one , right ? > >> > > > > Yes, it's phy_type. > > You should be more precise in the commit message. Also, cull the CC list next > time. Got it. Thanks for advice. -- Best regards, Ran
diff --git a/arch/arm/dts/fsl-ls1012a-qds.dtsi b/arch/arm/dts/fsl-ls1012a-qds.dtsi index dde7134..d17cd99 100644 --- a/arch/arm/dts/fsl-ls1012a-qds.dtsi +++ b/arch/arm/dts/fsl-ls1012a-qds.dtsi @@ -121,3 +121,8 @@ &duart0 { status = "okay"; }; + +&usb0 { + status = "okay"; + phy_type = "ulpi"; +};
Without this propertiy, U-Boot will pop warning of 'USB phy type not defined' when select CONFIG_HAS_FSL_DR_USB. Signed-off-by: Ran Wang <ran.wang_1@nxp.com> --- Change in v2: None arch/arm/dts/fsl-ls1012a-qds.dtsi | 5 +++++ 1 file changed, 5 insertions(+)