| Message ID | 1513668834-8647-2-git-send-email-ran.wang_1@nxp.com |
|---|---|
| State | Superseded |
| Delegated to: | York Sun |
| Headers | show |
| Series | [U-Boot,1/3] armv8: ls1012a: Add USB 2.0 controller phy type for ls1012aqds board | expand |
On 12/19/2017 08:33 AM, Ran Wang wrote: Commit message explaining what "some" means is missing. > Signed-off-by: Ran Wang <ran.wang_1@nxp.com> > --- > drivers/usb/host/ehci-fsl.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c > index 62c431b..17d1fae 100644 > --- a/drivers/usb/host/ehci-fsl.c > +++ b/drivers/usb/host/ehci-fsl.c > @@ -106,14 +106,14 @@ static int ehci_fsl_probe(struct udevice *dev) > ehci = (struct usb_ehci *)priv->hcd_base; > hccr = (struct ehci_hccr *)(&ehci->caplength); > hcor = (struct ehci_hcor *) > - ((u32)hccr + HC_LENGTH(ehci_readl(&hccr->cr_capbase))); > + ((void *)hccr + HC_LENGTH(ehci_readl(&hccr->cr_capbase))); > > if (ehci_fsl_init(priv, ehci, hccr, hcor) < 0) > return -ENXIO; > > - debug("ehci-fsl: init hccr %x and hcor %x hc_length %d\n", > - (u32)hccr, (u32)hcor, > - (u32)HC_LENGTH(ehci_readl(&hccr->cr_capbase))); > + debug("ehci-fsl: init hccr %p and hcor %p hc_length %d\n", > + (void *)hccr, (void *)hcor, > + HC_LENGTH(ehci_readl(&hccr->cr_capbase))); > > return ehci_register(dev, hccr, hcor, &fsl_ehci_ops, 0, USB_INIT_HOST); > } >
Hi Marek, > -----Original Message----- > From: Marek Vasut [mailto:marex@denx.de] > Sent: Tuesday, December 19, 2017 7:17 PM <snip> > > On 12/19/2017 08:33 AM, Ran Wang wrote: > > Commit message explaining what "some" means is missing. > OK, will explain it in v2 > > Signed-off-by: Ran Wang <ran.wang_1@nxp.com> > > --- > > drivers/usb/host/ehci-fsl.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c > > index 62c431b..17d1fae 100644 > > --- a/drivers/usb/host/ehci-fsl.c > > +++ b/drivers/usb/host/ehci-fsl.c > > @@ -106,14 +106,14 @@ static int ehci_fsl_probe(struct udevice *dev) > > ehci = (struct usb_ehci *)priv->hcd_base; > > hccr = (struct ehci_hccr *)(&ehci->caplength); > > hcor = (struct ehci_hcor *) > > - ((u32)hccr + HC_LENGTH(ehci_readl(&hccr->cr_capbase))); > > + ((void *)hccr + HC_LENGTH(ehci_readl(&hccr->cr_capbase))); > > > > if (ehci_fsl_init(priv, ehci, hccr, hcor) < 0) > > return -ENXIO; > > > > - debug("ehci-fsl: init hccr %x and hcor %x hc_length %d\n", > > - (u32)hccr, (u32)hcor, > > - (u32)HC_LENGTH(ehci_readl(&hccr->cr_capbase))); > > + debug("ehci-fsl: init hccr %p and hcor %p hc_length %d\n", > > + (void *)hccr, (void *)hcor, > > + HC_LENGTH(ehci_readl(&hccr->cr_capbase))); > > > > return ehci_register(dev, hccr, hcor, &fsl_ehci_ops, 0, > > USB_INIT_HOST); } > > > > Best Regards, Ran
diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c index 62c431b..17d1fae 100644 --- a/drivers/usb/host/ehci-fsl.c +++ b/drivers/usb/host/ehci-fsl.c @@ -106,14 +106,14 @@ static int ehci_fsl_probe(struct udevice *dev) ehci = (struct usb_ehci *)priv->hcd_base; hccr = (struct ehci_hccr *)(&ehci->caplength); hcor = (struct ehci_hcor *) - ((u32)hccr + HC_LENGTH(ehci_readl(&hccr->cr_capbase))); + ((void *)hccr + HC_LENGTH(ehci_readl(&hccr->cr_capbase))); if (ehci_fsl_init(priv, ehci, hccr, hcor) < 0) return -ENXIO; - debug("ehci-fsl: init hccr %x and hcor %x hc_length %d\n", - (u32)hccr, (u32)hcor, - (u32)HC_LENGTH(ehci_readl(&hccr->cr_capbase))); + debug("ehci-fsl: init hccr %p and hcor %p hc_length %d\n", + (void *)hccr, (void *)hcor, + HC_LENGTH(ehci_readl(&hccr->cr_capbase))); return ehci_register(dev, hccr, hcor, &fsl_ehci_ops, 0, USB_INIT_HOST); }
Signed-off-by: Ran Wang <ran.wang_1@nxp.com> --- drivers/usb/host/ehci-fsl.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)