[U-Boot,2/3] rockchip: set Pre-reloc malloc pool size to 4kb for rk3368 based boards

The default 1kb pre-reloc malloc pool is not enough for dm
core to enable the dm-pre-reloc device drivers.

Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---

 configs/evb-px5_defconfig      | 1 +
 configs/geekbox_defconfig      | 1 +
 configs/sheep-rk3368_defconfig | 1 +
 3 files changed, 3 insertions(+)

> On 02 Aug 2017, at 15:10, Andy Yan <andy.yan@rock-chips.com> wrote:
> 
> The default 1kb pre-reloc malloc pool is not enough for dm
> core to enable the dm-pre-reloc device drivers.
> 
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> —

Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

See comment below.

> 
> configs/evb-px5_defconfig      | 1 +
> configs/geekbox_defconfig      | 1 +
> configs/sheep-rk3368_defconfig | 1 +
> 3 files changed, 3 insertions(+)
> 
> diff --git a/configs/evb-px5_defconfig b/configs/evb-px5_defconfig
> index dae5094..72e492f 100644
> --- a/configs/evb-px5_defconfig
> +++ b/configs/evb-px5_defconfig
> @@ -1,5 +1,6 @@
> CONFIG_ARM=y
> CONFIG_ARCH_ROCKCHIP=y
> +CONFIG_SYS_MALLOC_F_LEN=0x1000

We even increased this to 0x2000 for TPL/SPL on the lion-board (i.e. RK3368-uQ7).
Should we just make 0x2000 the default for RK3368 (in Kconfig) and reduce the noise in defconfig?

> CONFIG_ROCKCHIP_RK3368=y
> CONFIG_TARGET_EVB_PX5=y
> CONFIG_DEFAULT_DEVICE_TREE="rk3368-px5-evb"
> diff --git a/configs/geekbox_defconfig b/configs/geekbox_defconfig
> index a1944b4..0fd89d2 100644
> --- a/configs/geekbox_defconfig
> +++ b/configs/geekbox_defconfig
> @@ -1,5 +1,6 @@
> CONFIG_ARM=y
> CONFIG_ARCH_ROCKCHIP=y
> +CONFIG_SYS_MALLOC_F_LEN=0x1000
> CONFIG_ROCKCHIP_RK3368=y
> CONFIG_TARGET_GEEKBOX=y
> CONFIG_DEFAULT_DEVICE_TREE="rk3368-geekbox"
> diff --git a/configs/sheep-rk3368_defconfig b/configs/sheep-rk3368_defconfig
> index be00fad..da6b93a 100644
> --- a/configs/sheep-rk3368_defconfig
> +++ b/configs/sheep-rk3368_defconfig
> @@ -1,5 +1,6 @@
> CONFIG_ARM=y
> CONFIG_ARCH_ROCKCHIP=y
> +CONFIG_SYS_MALLOC_F_LEN=0x1000
> CONFIG_ROCKCHIP_RK3368=y
> CONFIG_DEFAULT_DEVICE_TREE="rk3368-sheep"
> CONFIG_DEBUG_UART=y
> -- 
> 2.7.4
> 
>

Am 02.08.2017 um 15:25 schrieb Dr. Philipp Tomsich:
> 
>> On 02 Aug 2017, at 15:10, Andy Yan <andy.yan@rock-chips.com> wrote:
>>
>> The default 1kb pre-reloc malloc pool is not enough for dm
>> core to enable the dm-pre-reloc device drivers.
>>
>> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>> —
> 
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> 
> See comment below.
> 
>>
>> configs/evb-px5_defconfig      | 1 +
>> configs/geekbox_defconfig      | 1 +
>> configs/sheep-rk3368_defconfig | 1 +
>> 3 files changed, 3 insertions(+)
>>
>> diff --git a/configs/evb-px5_defconfig b/configs/evb-px5_defconfig
>> index dae5094..72e492f 100644
>> --- a/configs/evb-px5_defconfig
>> +++ b/configs/evb-px5_defconfig
>> @@ -1,5 +1,6 @@
>> CONFIG_ARM=y
>> CONFIG_ARCH_ROCKCHIP=y
>> +CONFIG_SYS_MALLOC_F_LEN=0x1000
> 
> We even increased this to 0x2000 for TPL/SPL on the lion-board (i.e. RK3368-uQ7).
> Should we just make 0x2000 the default for RK3368 (in Kconfig) and reduce the noise in defconfig?

Is there any downside to it? If not, I'd say yes.

Regards,
Andreas

Hi Philipp:


On 2017年08月02日 21:25, Dr. Philipp Tomsich wrote:
>> On 02 Aug 2017, at 15:10, Andy Yan <andy.yan@rock-chips.com> wrote:
>>
>> The default 1kb pre-reloc malloc pool is not enough for dm
>> core to enable the dm-pre-reloc device drivers.
>>
>> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>> —
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>
> See comment below.
>
>> configs/evb-px5_defconfig      | 1 +
>> configs/geekbox_defconfig      | 1 +
>> configs/sheep-rk3368_defconfig | 1 +
>> 3 files changed, 3 insertions(+)
>>
>> diff --git a/configs/evb-px5_defconfig b/configs/evb-px5_defconfig
>> index dae5094..72e492f 100644
>> --- a/configs/evb-px5_defconfig
>> +++ b/configs/evb-px5_defconfig
>> @@ -1,5 +1,6 @@
>> CONFIG_ARM=y
>> CONFIG_ARCH_ROCKCHIP=y
>> +CONFIG_SYS_MALLOC_F_LEN=0x1000
> We even increased this to 0x2000 for TPL/SPL on the lion-board (i.e. RK3368-uQ7).
> Should we just make 0x2000 the default for RK3368 (in Kconfig) and reduce the noise in defconfig?

I have no problem with it.

>
>> CONFIG_ROCKCHIP_RK3368=y
>> CONFIG_TARGET_EVB_PX5=y
>> CONFIG_DEFAULT_DEVICE_TREE="rk3368-px5-evb"
>> diff --git a/configs/geekbox_defconfig b/configs/geekbox_defconfig
>> index a1944b4..0fd89d2 100644
>> --- a/configs/geekbox_defconfig
>> +++ b/configs/geekbox_defconfig
>> @@ -1,5 +1,6 @@
>> CONFIG_ARM=y
>> CONFIG_ARCH_ROCKCHIP=y
>> +CONFIG_SYS_MALLOC_F_LEN=0x1000
>> CONFIG_ROCKCHIP_RK3368=y
>> CONFIG_TARGET_GEEKBOX=y
>> CONFIG_DEFAULT_DEVICE_TREE="rk3368-geekbox"
>> diff --git a/configs/sheep-rk3368_defconfig b/configs/sheep-rk3368_defconfig
>> index be00fad..da6b93a 100644
>> --- a/configs/sheep-rk3368_defconfig
>> +++ b/configs/sheep-rk3368_defconfig
>> @@ -1,5 +1,6 @@
>> CONFIG_ARM=y
>> CONFIG_ARCH_ROCKCHIP=y
>> +CONFIG_SYS_MALLOC_F_LEN=0x1000
>> CONFIG_ROCKCHIP_RK3368=y
>> CONFIG_DEFAULT_DEVICE_TREE="rk3368-sheep"
>> CONFIG_DEBUG_UART=y
>> -- 
>> 2.7.4
>>
>>
>
>
>

> The default 1kb pre-reloc malloc pool is not enough for dm
> core to enable the dm-pre-reloc device drivers.
> 
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> 
>  configs/evb-px5_defconfig      | 1 +
>  configs/geekbox_defconfig      | 1 +
>  configs/sheep-rk3368_defconfig | 1 +
>  3 files changed, 3 insertions(+)
> 

Applied to u-boot-rockchip, thanks!