| Message ID | 1500981885-21296-2-git-send-email-patrice.chotard@st.com |
|---|---|
| State | Accepted |
| Commit | d38a8ea19c1d82296619557069618aaefc1ad977 |
| Delegated to: | Marek Vasut |
| Headers | show |
On 25 July 2017 at 05:24, <patrice.chotard@st.com> wrote: > From: Patrice Chotard <patrice.chotard@st.com> > > Fix following warnings encountered with platforms > dra7xx_evm and dra7xx_hs_evm : > > arm: + dra7xx_evm > + hccr = (struct xhci_hccr *)devfdt_get_addr(dev); > + ^ > + hcor = (struct xhci_hcor *)((phys_addr_t)hccr + > + ^ > w+drivers/usb/host/xhci-dwc3.c: In function 'xhci_dwc3_probe': > w+drivers/usb/host/xhci-dwc3.c:124:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > w+drivers/usb/host/xhci-dwc3.c:125:30: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > w+drivers/usb/host/xhci-dwc3.c:125:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > arm: + dra7xx_hs_evm > + hccr = (struct xhci_hccr *)devfdt_get_addr(dev); > + ^ > + hcor = (struct xhci_hcor *)((phys_addr_t)hccr + > + ^ > w+drivers/usb/host/xhci-dwc3.c: In function 'xhci_dwc3_probe': > w+drivers/usb/host/xhci-dwc3.c:124:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > w+drivers/usb/host/xhci-dwc3.c:125:30: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > w+drivers/usb/host/xhci-dwc3.c:125:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > > Introduced by 7e65e84 usb: host: xhci-dwc3: Convert driver to DM > > Signed-off-by: Patrice Chotard <patrice.chotard@st.com> > --- > drivers/usb/host/xhci-dwc3.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Thanks for the very clear commit messages. Reviewed-by: Simon Glass <sjg@chromium.org>
diff --git a/drivers/usb/host/xhci-dwc3.c b/drivers/usb/host/xhci-dwc3.c index 541a785..4191a89 100644 --- a/drivers/usb/host/xhci-dwc3.c +++ b/drivers/usb/host/xhci-dwc3.c @@ -121,8 +121,8 @@ static int xhci_dwc3_probe(struct udevice *dev) enum usb_dr_mode dr_mode; int ret; - hccr = (struct xhci_hccr *)devfdt_get_addr(dev); - hcor = (struct xhci_hcor *)((phys_addr_t)hccr + + hccr = (struct xhci_hccr *)((uintptr_t)dev_read_addr(dev)); + hcor = (struct xhci_hcor *)((uintptr_t)hccr + HC_LENGTH(xhci_readl(&(hccr)->cr_capbase))); ret = generic_phy_get_by_index(dev, 0, &plat->usb_phy);